Re: [PATCH] [PATCH][ARM] Fix pr63210.c testcase.

[Ramana Radhakrishnan <ramana.gcc@googlemail.com>]

On Thu, Jul 23, 2015 at 12:15 PM, Alex Velenko <alex.velenko@arm.com> wrote:
> Hi,
>
> This patch prevents testcase pr63210.c from running with -march=armv4t.
> Object size check should be skipped with explicit -march=armv4t, because
> expected size is only correct using pop pc instruction which is unsafe for
> armv4t. For arm_arch_v5t_ok cases, an explicit -march=armv5t flag is set.
>
> Is patch ok for trunk and fsf-5?
>

OK - please apply to both.

Thanks,
Ramana


> gcc/testsuite
>
> 2015-07-23  Alex Velenko  <Alex.Velenko@arm.com>
>
>         * gcc.target/arm/pr63210.c (dg-skip-if): Skip armv4t.
>         (dg-additional-options): Add -march=armv5t if arm_arch_v5t_ok.
> ---
>  gcc/testsuite/gcc.target/arm/pr63210.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/gcc/testsuite/gcc.target/arm/pr63210.c b/gcc/testsuite/gcc.target/arm/pr63210.c
> index c3ae928..9b63a67 100644
> --- a/gcc/testsuite/gcc.target/arm/pr63210.c
> +++ b/gcc/testsuite/gcc.target/arm/pr63210.c
> @@ -1,6 +1,8 @@
>  /* { dg-do assemble } */
>  /* { dg-options "-mthumb -Os " }  */
>  /* { dg-require-effective-target arm_thumb1_ok } */
> +/* { dg-skip-if "do not test on armv4t" { *-*-* } { "-march=armv4t" } } */
> +/* { dg-additional-options "-march=armv5t" {target arm_arch_v5t_ok} } */
>
>  int foo1 (int c);
>  int foo2 (int c);
> --
> 1.8.1.2
>