From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id E621E3858D28; Wed, 3 May 2023 12:31:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E621E3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-94ed7e49541so836278566b.1; Wed, 03 May 2023 05:31:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683117060; x=1685709060; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=P2ZhVP3w8m9saKAQaCeTHgnSvyTVr1wc77E1gEinQ7E=; b=LtBntfwN4zqjOiweDWnkGlC5g/m/OuPcxHfyP6WDd8AAt3HQQhIeJhh4+SbZZW1fw1 +rW6SVlGz0RxgR8MOniYKPXCYJpf7YJMk9iJENly43xDMHI1KRmC2PZOVHuRCQahipxQ eCYGIdL2LvfvhOMiO7vjR3/thG6oMruSV+fKPRlT8lItBqUqAicSnVXvyuacE/tbJpir 06afTX/iaqV+mou3kmXvKuxSunCuYM3yC5Vu6kOO31xTU9/RwkRED0PLx7fvaFMZXl0y GAAd7ATyZdt2oAt4aCse0DRJLi4ByUfXH/mAekFOf+wHo/dTemeosFGqfn5GQV6J6xNY e7pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683117060; x=1685709060; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=P2ZhVP3w8m9saKAQaCeTHgnSvyTVr1wc77E1gEinQ7E=; b=bi9BWLb1kw759rUCYPDWz7n/jl55cHVVlhOq8C/k3RBQNlI14ZSuMwnQfVhVbk5rDv +gvJquXMoMzzGDTuM2/MbZl8tMhEjBYjPbxYA9ViwNKZW3AAgdPYB2fNnxIrU96XW0P4 oSlvz9pQvzRAK+dpzwPS1s5hqvBOmlPGFaXNROO3YeqMdxp3GHCt8zrNnpztlW8KEVoN ScchVuE92F8DhTmYXTxDiSLlxA2NSZBNbHl933v8j0SpikAj4pLXg8Xcqw+tvJt8sExC 4otsJIRqQGVCMRSJYUiQM0DWZtE8qBc+A+ys1AMko7mstI+BQbG1rs59yGQ0h5W/kN/s Q6rg== X-Gm-Message-State: AC+VfDwfnItvcscGXBU/JT+nBujwnL4lTJhSTaOFE1RwhTfeN9FUZhs9 IsnFnO01tQGbLVLj1IhiPZAx7RgPlgj9Psx7/kaog04UcxU= X-Google-Smtp-Source: ACHHUZ66+Kd98hV+YzXGPkC8++e24MELz+qUkVArEM1SBX2LOQZ7i5ZJko+VoOu+ii+IIEdHwpAuL+mkcCIoJvG58qY= X-Received: by 2002:a17:907:1c1f:b0:949:55fd:34fa with SMTP id nc31-20020a1709071c1f00b0094955fd34famr3145916ejc.39.1683117060370; Wed, 03 May 2023 05:31:00 -0700 (PDT) MIME-Version: 1.0 References: <20230501070622.847749-2-tchaikov@gmail.com> <20230503021713.1146069-1-tchaikov@gmail.com> In-Reply-To: From: kefu chai Date: Wed, 3 May 2023 20:30:49 +0800 Message-ID: Subject: Re: [PATCH v2 0/1] Set _M_string_length before calling _M_dispose() To: Jonathan Wakely Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org Content-Type: multipart/alternative; boundary="0000000000007fb58f05fac93a49" X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000007fb58f05fac93a49 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Le mer. 3 mai 2023 =C3=A0 20:22, Jonathan Wakely a =C3= =A9crit : > > > On Wed, 3 May 2023 at 03:17, Kefu Chai via Libstdc++ < > libstdc++@gcc.gnu.org> wrote: > >> Hi Jonathan, >> >> Thank you for your review and suggestion. The change looks great! >> Assigning a value with an immediate zero is indeed much faster. >> >> in v2: >> >> * revised the commit message a little bit, I found it a little bit >> difficult to parse when re-reading it. >> * associated the commit with PR/libstdc++/109703. as I just filed >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D109706, which turns out >> to be a dup of https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D109703 >> >> The rest of the v2 patch is identical to the one attached in your reply. >> >> Would you please taking another look? >> > > Thanks. I've pushed it to trunk as > cbf6c7a1d16490a1e63e9a5ce00e9a5c44c4c2f2 and will backport it too. > > I altered the commit msg again, because "input_iterator" is a C++20 > concept, and here we're just talking about types meeting the old > C[[17InputIterator requirements, not types modelling the concept. I also > added references to the commit and PR that added the > __builtin_unreachable(). > Awesome! The commit message is much better now. Thank you very much for your help! > > >> Kefu Chai (1): >> libstdc++: Set _M_string_length before calling _M_dispose() [PR109703] >> >> libstdc++-v3/include/bits/basic_string.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> -- >> 2.40.1 >> >> -- Regards Kefu Chai --0000000000007fb58f05fac93a49--