Re: PATCH] PR target/65612: Multiversioning doesn't work with DSO nor PIE

[Jack Howarth <howarth.at.gcc@gmail.com>]

On Mon, Mar 30, 2015 at 10:42 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Mon, Mar 30, 2015 at 7:08 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Mon, Mar 30, 2015 at 5:53 PM, Jack Howarth <howarth.at.gcc@gmail.com> wrote:
>>> HJ,
>>>      This patch breaks the bootstrap on targets like darwin which
>>> don't build libgcc_nonshared.a...
>>>
>>> if test -z "$objects"; then \
>>>   echo 'int __libgcc_eh_dummy;' > eh_dummy.c; \
>>>   /sw/src/fink.build/gcc5-5.0.0-1/darwin_objdir/./gcc/xgcc
>>> -B/sw/src/fink.build/gcc5-5.0.0-1/darwin_objdir/./gcc/
>>> -B/sw/lib/gcc5/x86_64-apple-darwin14.3.0/bin/
>>> -B/sw/lib/gcc5/x86_64-apple-darwin14.3.0/lib/ -isystem
>>> /sw/lib/gcc5/x86_64-apple-darwin14.3.0/include -isystem
>>> /sw/lib/gcc5/x86_64-apple-darwin14.3.0/sys-include    -g -O2 -m32 -O2
>>> -g -O2 -DIN_GCC    -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual
>>> -Wno-format -Wstrict-prototypes -Wmissing-prototypes
>>> -Wold-style-definition  -isystem ./include   -pipe -fno-common -g
>>> -DIN_LIBGCC2 -fbuilding-libgcc -fno-stack-protector   -pipe
>>> -fno-common -I. -I. -I../../.././gcc
>>> -I../../../../gcc-5-20150330/libgcc
>>> -I../../../../gcc-5-20150330/libgcc/.
>>> -I../../../../gcc-5-20150330/libgcc/../gcc
>>> -I../../../../gcc-5-20150330/libgcc/../include  -DHAVE_CC_TLS
>>> -DUSE_EMUTLS -fvisibility=hidden -DHIDE_EXPORTS -c eh_dummy.c \
>>>      -o eh_dummy.o; \
>>>   objects=eh_dummy.o; \
>>> fi; \
>>> ar  rc libgcc_nonshared.a $objects
>>> ar: cpuinfo.o: No such file or directory
>>> Makefile:905: recipe for target 'libgcc_nonshared.a' failed
>>> make[5]: *** [libgcc_nonshared.a] Error 1
>>> make[5]: Leaving directory
>>> '/sw/src/fink.build/gcc5-5.0.0-1/darwin_objdir/x86_64-apple-darwin14.3.0/i386/libgcc'
>>> Makefile:1168: recipe for target 'multi-do' failed
>>> make[4]: *** [multi-do] Error 1
>>> make[4]: Leaving directory
>>> '/sw/src/fink.build/gcc5-5.0.0-1/darwin_objdir/x86_64-apple-darwin14.3.0/libgcc'
>>> Makefile:117: recipe for target 'all-multi' failed
>>> make[3]: *** [all-multi] Error 2
>>> make[3]: Leaving directory
>>> '/sw/src/fink.build/gcc5-5.0.0-1/darwin_objdir/x86_64-apple-darwin14.3.0/libgcc'
>>> Makefile:14820: recipe for target 'all-stage1-target-libgcc' failed
>>> make[2]: *** [all-stage1-target-libgcc] Error 2
>>> make[2]: Leaving directory '/sw/src/fink.build/gcc5-5.0.0-1/darwin_objdir'
>>> Makefile:20760: recipe for target 'stage1-bubble' failed
>>> make[1]: *** [stage1-bubble] Error 2
>>> make[1]: Leaving directory '/sw/src/fink.build/gcc5-5.0.0-1/darwin_objdir'
>>> Makefile:21064: recipe for target 'bootstrap' failed
>>> make: *** [bootstrap] Error 2
>>>
>>>           Jack
>>>
>>
>> This one works.  I need to add $(LIB2ADDNONSHARED) $(LIB2ADDSHARED)
>> to iter-items and handle duplicated items in them.
>>
>
> There is no regression on Linux/x86-64.
>
> --
> H.J.

Can this wait for 5.2? Creating new libgcc libraries seems really
invasive for stage4.