From: Jack Howarth <howarth.at.gcc@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] PR rtl-optimization/32219: optimizer causes wrong code in pic/hidden/weak symbol checking
Date: Sat, 07 Feb 2015 02:25:00 -0000 [thread overview]
Message-ID: <CAJMcOU9YNCQ16RLOFg3oEf8C3fzbO+bQ-ZYrR149k=LSU_biTw@mail.gmail.com> (raw)
In-Reply-To: <CAMe9rOr5Ktk_yhfFX9DHAb6Sq=v2SORaY6TbahSiKF9dB1LNSQ@mail.gmail.com>
H.J.,
Where is this new patch?
Jack
On Fri, Feb 6, 2015 at 8:55 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Fri, Feb 6, 2015 at 5:51 PM, Jack Howarth <howarth.at.gcc@gmail.com> wrote:
>> H.J.,
>> This patch also seems to be causing a huge number of regressions
>> in the g++ test suite due to linkage warnings on darwin of the form...
>>
>> ld: warning: direct access in Model::~Model() to global weak symbol
>> vtable for Model means the weak symbol cannot be overridden at
>> runtime. This was likely caused by different translation units being
>> compiled with different visibility settings.
>
> Can you try my new patch?
>
>> Can this change wait until stage1?
>> Jack
>>
>> On Fri, Feb 6, 2015 at 4:41 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>> On Fri, Feb 6, 2015 at 1:31 PM, Jack Howarth <howarth.at.gcc@gmail.com> wrote:
>>>> H.J.,
>>>> On x86_64-apple-darwin14, your patch applied to r220481 results in...
>>>>
>>>> FAIL: gcc.dg/visibility-22.c (test for excess errors)
>>>> FAIL: gcc.dg/visibility-23.c scan-hidden private_extern[ \t_]*_?foo
>>>>
>>>> with...
>>>>
>>>> Executing on host:
>>>> /sw/src/fink.build/gcc50-5.0.0-1000/darwin_objdir/gcc/xgcc
>>>> -B/sw/src/fink.build/gcc50-5.0.0-1000/darwin_objdir/gcc/
>>>> /sw/src/fink.build/gcc50-5.0.0-1000/gcc-5-20150206/gcc/testsuite/gcc.dg/visibility-22.c
>>>> -fno-diagnostics-show-caret -fdiagnostics-color=never -fPIC -lm
>>>> -m32 -o ./visibility-22.exe (timeout = 300)
>>>> spawn -ignore SIGHUP
>>>> /sw/src/fink.build/gcc50-5.0.0-1000/darwin_objdir/gcc/xgcc
>>>> -B/sw/src/fink.build/gcc50-5.0.0-1000/darwin_objdir/gcc/
>>>> /sw/src/fink.build/gcc50-5.0.0-1000/gcc-5-20150206/gcc/testsuite/gcc.dg/visibility-22.c
>>>> -fno-diagnostics-show-caret -fdiagnostics-color=never -fPIC -lm -m32
>>>> -o ./visibility-22.exe^M
>>>> Undefined symbols for architecture i386:^M
>>>> "_foo", referenced from:^M
>>>> _main in ccMD1qjz.o^M
>>>> _main in ccMD1qjz.o^M
>>>> ld: symbol(s) not found for architecture i386^M
>>>> collect2: error: ld returned 1 exit status^M
>>>> compiler exited with status 1
>>>> output is:
>>>> Undefined symbols for architecture i386:^M
>>>> "_foo", referenced from:^M
>>>> _main in ccMD1qjz.o^M
>>>> _main in ccMD1qjz.o^M
>>>> ld: symbol(s) not found for architecture i386^M
>>>> collect2: error: ld returned 1 exit status^M
>>>>
>>>> FAIL: gcc.dg/visibility-22.c (test for excess errors)
>>>>
>>>> Executing on host:
>>>> /sw/src/fink.build/gcc50-5.0.0-1000/darwin_objdir/gcc/xgcc
>>>> -B/sw/src/fink.build/gcc50-5.0.0-1000/darwin_objdir/gcc/
>>>> /sw/src/fink.build/gcc50-5.0.0-1000/gcc-5-20150206/gcc/testsuite/gcc.dg/visibility-23.c
>>>> -fno-diagnostics-show-caret -fdiagnostics-color=never -fPIC -S
>>>> -m32 -o visibility-23.s (timeout = 300)
>>>> spawn -ignore SIGHUP
>>>> /sw/src/fink.build/gcc50-5.0.0-1000/darwin_objdir/gcc/xgcc
>>>> -B/sw/src/fink.build/gcc50-5.0.0-1000/darwin_objdir/gcc/
>>>> /sw/src/fink.build/gcc50-5.0.0-1000/gcc-5-20150206/gcc/testsuite/gcc.dg/visibility-23.c
>>>> -fno-diagnostics-show-caret -fdiagnostics-color=never -fPIC -S -m32 -o
>>>> visibility-23.s^M
>>>> PASS: gcc.dg/visibility-23.c (test for excess errors)
>>>> FAIL: gcc.dg/visibility-23.c scan-hidden private_extern[ \t_]*_?foo
>>>>
>>>
>>> Does Darwin support undefined hidden weak symbol?
>>> Can you compile and gcc/testsuite/gcc.dg/visibility-22.c
>>> with clang on Darwin?
>>>
>>> --
>>> H.J.
>
>
>
> --
> H.J.
next prev parent reply other threads:[~2015-02-07 2:25 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 16:23 H.J. Lu
2015-02-06 21:31 ` Jack Howarth
2015-02-06 21:41 ` H.J. Lu
2015-02-06 21:51 ` Jack Howarth
2015-02-07 1:50 ` H.J. Lu
2015-02-07 1:51 ` Jack Howarth
2015-02-07 1:55 ` H.J. Lu
2015-02-07 2:25 ` Jack Howarth [this message]
2015-02-07 8:28 ` Jack Howarth
2015-02-07 12:27 ` H.J. Lu
2015-02-07 15:11 ` Jack Howarth
2015-02-07 15:25 ` Jack Howarth
2015-02-07 15:56 ` H.J. Lu
2015-02-07 16:45 ` H.J. Lu
2015-02-08 18:24 ` Jack Howarth
2015-02-09 17:26 ` Mike Stump
2015-02-10 18:33 ` Jack Howarth
2015-02-10 21:19 ` Richard Henderson
2015-02-10 21:25 ` H.J. Lu
2015-02-11 14:35 ` Jack Howarth
2015-02-12 6:23 ` [PATCH] PR rtl-optimization/32219: optimizer causees " Richard Henderson
2015-02-12 18:16 ` H.J. Lu
2015-02-12 18:58 ` H.J. Lu
2015-02-12 19:25 ` Richard Henderson
2015-02-12 23:04 ` H.J. Lu
2015-02-12 23:05 ` H.J. Lu
2015-02-13 0:05 ` Richard Henderson
2015-02-13 4:14 ` H.J. Lu
2015-02-13 5:11 ` Richard Henderson
2015-02-18 14:17 ` Alex Velenko
2015-02-19 13:12 ` H.J. Lu
2015-02-19 15:02 ` Richard Henderson
2015-02-19 17:25 ` Alex Velenko
2015-02-19 17:27 ` Richard Henderson
2015-03-03 15:58 ` Alex Velenko
2015-03-05 14:55 ` Alex Velenko
2015-03-05 15:31 ` Ramana Radhakrishnan
2015-03-06 11:14 ` Alex Velenko
2015-02-12 19:16 ` Jack Howarth
2015-02-12 19:18 ` H.J. Lu
2015-02-12 19:39 ` Jack Howarth
2015-02-07 19:37 ` [PATCH] PR rtl-optimization/32219: optimizer causes " Jack Howarth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJMcOU9YNCQ16RLOFg3oEf8C3fzbO+bQ-ZYrR149k=LSU_biTw@mail.gmail.com' \
--to=howarth.at.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).