public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Yuri Gribov <tetra2005@gmail.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Cc: Tom de Vries <tom@codesourcery.com>
Subject: [PATCH] Print relative names in UNSUPPORTED AutoFDO tests
Date: Sun, 09 Jul 2017 19:00:00 -0000	[thread overview]
Message-ID: <CAJOtW+4Uk_rZz8RwzR0QPrtn5mso6=Zs0CV4urJU_ZA5WH7D3Q@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

Hi,

This patch fixes AutoFDO Dejagnu tests to print relative filenames
instead of absolute ones when AutoFDO is unsupported. This is to
prevent spurious differences in dg-cmp-results.sh, like this:
  NA->UNSUPPORTED:
/home/yugr/src/gcc-57371/gcc/testsuite/g++.dg/bprob/g++-bprob-1.C
-fauto-profile
  UNSUPPORTED->NA:
/home/yugr/src/gcc/gcc/testsuite/g++.dg/bprob/g++-bprob-1.C
-fauto-profile

Ok for trunk?

-Y

[-- Attachment #2: autofdo-unsup-fix-1.patch --]
[-- Type: application/octet-stream, Size: 1038 bytes --]

2017-07-09  Yury Gribov  <tetra2005@gmail.com>

gcc/testsuite/
        * lib/profopt.exp: Print relative names in UNSUPPORTED
	AutoFDO tests.

diff -rupN gcc/gcc/testsuite/lib/profopt.exp gcc-compare-checks/gcc/testsuite/lib/profopt.exp
--- gcc/gcc/testsuite/lib/profopt.exp	2017-07-09 17:58:39.000000000 +0200
+++ gcc-compare-checks/gcc/testsuite/lib/profopt.exp	2017-07-09 17:53:45.000000000 +0200
@@ -285,7 +285,7 @@ proc auto-profopt-execute { src } {
 
     if { ! [check_profiling_available "-fauto-profile"] } {
         regsub "(?q)$srcdir/" $src "" testcase
-        unsupported "$src -fauto-profile"
+        unsupported "$testcase -fauto-profile"
         return
     }
     set profile_wrapper [profopt-perf-wrapper]
@@ -451,7 +451,7 @@ proc profopt-execute { src } {
 		verbose "Running $cmd"
 		set id [remote_spawn "" $cmd]
 		if { $id < 0 } {
-		    unsupported "$src -fauto-profile: cannot run create_gcov"
+		    unsupported "$testcase -fauto-profile: cannot run create_gcov"
 		    set status "fail"
 		    return
 		}

             reply	other threads:[~2017-07-09 19:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-09 19:00 Yuri Gribov [this message]
2017-07-10 21:57 ` Mike Stump

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJOtW+4Uk_rZz8RwzR0QPrtn5mso6=Zs0CV4urJU_ZA5WH7D3Q@mail.gmail.com' \
    --to=tetra2005@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=tom@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).