public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Yuri Gribov <tetra2005@gmail.com>
To: Konstantin Serebryany <konstantin.s.serebryany@gmail.com>
Cc: Yury Gribov <y.gribov@samsung.com>,
	GCC Patches <gcc-patches@gcc.gnu.org>,
		Jakub Jelinek <jakub@redhat.com>,
	Marek Polacek <polacek@redhat.com>,
		Dmitry Vyukov <dvyukov@google.com>,
	Dodji Seketeli <dodji@redhat.com>,
		Viacheslav Garbuzov <v.garbuzov@samsung.com>
Subject: Re: [PATCH] Asan static optimization (draft)
Date: Fri, 15 Aug 2014 06:55:00 -0000	[thread overview]
Message-ID: <CAJOtW+6X38UHGkXvkpT0J8znfTJjL0VGoR5UEvrB1nPTefHiCA@mail.gmail.com> (raw)
In-Reply-To: <CAGQ9bdwbhTZUo-To=F87bMu4D0vP7VWydcsaB58+UR_c3AP=qQ@mail.gmail.com>

On Thu, Aug 14, 2014 at 8:53 PM, Konstantin Serebryany
<konstantin.s.serebryany@gmail.com> wrote:
> In order for your work to be generally useful, I'd ask several things:
> - Update https://code.google.com/p/address-sanitizer/wiki/CompileTimeOptimizations
> with examples that will be handled

Done (to be honest I only plan to do full redundancy elimination for
now, hoisting would hopefully follow later). Note I'm still
experimenting so there may be some changes in actual implementation.

> - Create small standalone test cases in C
> - Don't put the tests under GPL (otherwise we'll not be able to reuse
> them in LLVM)

I already have a bunch of tests (which I plan to extend further). How
should I submit them s.t. they could be reused by LLVM?

>>> make sure that sanopt performs conservative optimization
> Yes. I don't know a good solution to this problem, which is why we did
> not attack it before.
> Increasing asan speed will save lots of CPU time, but missing a single software
> bug due to an overly aggressive optimization may cost much more.

Yeah. I thought about manually inspecting optimizations that are
performed for some large files (e.g. GCC's asan.c) and maybe doing
some  random verifications of Asan trophies
(http://code.google.com/p/address-sanitizer/wiki/FoundBugs). Ideally
we'd have some test generator but making a reasonable one for C sounds
laughable. Perhaps there is some prior work on verification of Java
range checks optimizers?

-Y

  reply	other threads:[~2014-08-15  6:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-08 10:26 Yury Gribov
2014-08-08 10:37 ` Jakub Jelinek
2014-08-08 10:43   ` Dmitry Vyukov
2014-08-15  6:59     ` Yuri Gribov
2014-08-14 16:53 ` Konstantin Serebryany
2014-08-15  6:55   ` Yuri Gribov [this message]
2014-08-15 18:34     ` Konstantin Serebryany
2014-08-18 20:06       ` Yuri Gribov
2014-08-19 23:43         ` Konstantin Serebryany
2014-08-20  0:06           ` Konstantin Serebryany

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJOtW+6X38UHGkXvkpT0J8znfTJjL0VGoR5UEvrB1nPTefHiCA@mail.gmail.com \
    --to=tetra2005@gmail.com \
    --cc=dodji@redhat.com \
    --cc=dvyukov@google.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=konstantin.s.serebryany@gmail.com \
    --cc=polacek@redhat.com \
    --cc=v.garbuzov@samsung.com \
    --cc=y.gribov@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).