From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14663 invoked by alias); 13 Jul 2011 00:17:48 -0000 Received: (qmail 14651 invoked by uid 22791); 13 Jul 2011 00:17:46 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Jul 2011 00:17:31 +0000 Received: from wpaz13.hot.corp.google.com (wpaz13.hot.corp.google.com [172.24.198.77]) by smtp-out.google.com with ESMTP id p6D0HTWY032133 for ; Tue, 12 Jul 2011 17:17:29 -0700 Received: from gwm11 (gwm11.prod.google.com [10.200.13.11]) by wpaz13.hot.corp.google.com with ESMTP id p6D0HS1Y023305 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Tue, 12 Jul 2011 17:17:28 -0700 Received: by gwm11 with SMTP id 11so2715968gwm.2 for ; Tue, 12 Jul 2011 17:17:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.150.60.1 with SMTP id i1mr721988yba.58.1310516247904; Tue, 12 Jul 2011 17:17:27 -0700 (PDT) Received: by 10.151.45.18 with HTTP; Tue, 12 Jul 2011 17:17:27 -0700 (PDT) In-Reply-To: <4E1CCB76.3000309@google.com> References: <20110709012047.0D90B1C36BA@gchare.mtv.corp.google.com> <4E1CCB76.3000309@google.com> Date: Wed, 13 Jul 2011 01:05:00 -0000 Message-ID: Subject: Re: [pph] Stream DECL_CHAIN only for VAR/FUNCTION_DECLs that are part of a RECORD_OR_UNION_TYPE (issue4672055) From: Gabriel Charette To: Diego Novillo Cc: reply@codereview.appspotmail.com, crowl@google.com, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-07/txt/msg00977.txt.bz2 On Tue, Jul 12, 2011 at 3:32 PM, Diego Novillo wrote: > On 11-07-12 16:43 , Gabriel Charette wrote: > >> Even if this doesn't break tests anymore, we probably still want this, >> no point adding stuff to the pph image that is not needed... > > Actually, the reverse is true. =A0We want to write out the IL exactly as = the > original parser emitted it. =A0There are things we decide not to write be= cause > they are better re-generated when the pph image is being read (e.g., > function numbers, DECL_RTL), but > Well so lto_input_chain, called from pph_in_chain for every single chain, already reconstructs the DECL_CHAIN on input (DECL_CHAIN is actually set to NULL before streaming it out each element in the chain anyways). The only case where that wasn't true was when we output structs (and unions I think: we need to add a test for unions), because structs don't seem to use output chain (I don't have the code in front of me, but I know they would only output the tree (i.e. the tree was, in that case, responsible for streaming its DECL_CHAIN)). I'm surprised it no longer breaks... I'll have a look when I come back on Friday if it's still a debated issue then. Gab