[gsoc][match-and-simplify] allow multiple patterns inside for ?

[gsoc][match-and-simplify] allow multiple patterns inside for ?

[Prathamesh Kulkarni]

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

Would it be a good idea to allow multiple match_and_simplify within for ?

* genmatch.c (parse_for): Adjust to parse multiple patterns.

Thanks and Regards,
Prathamesh

[-- Attachment #2: multiple-patterns-for.patch --]
[-- Type: text/x-patch, Size: 1533 bytes --]

Index: genmatch.c
===================================================================
--- genmatch.c	(revision 212558)
+++ genmatch.c	(working copy)
@@ -2042,20 +2042,30 @@ parse_for (cpp_reader *r, source_locatio
       opers.safe_push (get_ident (r));
     }
 
-  vec<simplify *> for_simplifiers = vNULL;
-  parse_pattern (r, for_simplifiers);
 
-  for (unsigned i = 0; i < opers.length (); ++i)
+  while (1)
     {
-      for (unsigned j = 0; j < for_simplifiers.length (); ++j)
+      const cpp_token *token = peek (r);
+      if (token->type == CPP_CLOSE_PAREN)
+	break;
+      
+      vec<simplify *> for_simplifiers = vNULL;
+      parse_pattern (r, for_simplifiers);
+      
+      for (unsigned i = 0; i < opers.length (); ++i)
 	{
-	  simplify *s = for_simplifiers[j];
-	  operand *match_op = replace_id (s->match, user_id, opers[i]);
-	  operand *result_op = replace_id (s->result, user_id, opers[i]);
-	  simplify *ns = new simplify (s->name, match_op, s->match_location,
-				       s->ifexpr, s->ifexpr_location,
+	  for (unsigned j = 0; j < for_simplifiers.length (); ++j)
+	    {
+	      simplify *s = for_simplifiers[j];
+	      operand *match_op = replace_id (s->match, user_id, opers[i]);
+	      operand *result_op = replace_id (s->result, user_id, opers[i]);
+
+	      simplify *ns = new simplify (s->name, match_op, s->match_location,
+					   s->ifexpr, s->ifexpr_location,
 				       result_op, s->result_location);
-	  simplifiers.safe_push (ns);
+
+	      simplifiers.safe_push (ns);
+	    }
 	}
     }
 }

Re: [gsoc][match-and-simplify] allow multiple patterns inside for ?

[Prathamesh Kulkarni]

On Wed, Jul 23, 2014 at 3:42 AM, Prathamesh Kulkarni
<bilbotheelffriend@gmail.com> wrote:
> Would it be a good idea to allow multiple match_and_simplify within for ?
allow multiple patterns (match_and_simplify, for).
> * genmatch.c (parse_for): Adjust to parse multiple patterns.
>
> Thanks and Regards,
> Prathamesh

Re: [gsoc][match-and-simplify] allow multiple patterns inside for ?

[Richard Biener]

On Wed, Jul 23, 2014 at 12:12 AM, Prathamesh Kulkarni
<bilbotheelffriend@gmail.com> wrote:
> Would it be a good idea to allow multiple match_and_simplify within for ?

I see no good reason to disallow it.

Thus I have installed the patch.

Thanks,
Richard.

> * genmatch.c (parse_for): Adjust to parse multiple patterns.
>
> Thanks and Regards,
> Prathamesh