From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12112 invoked by alias); 24 Feb 2014 18:31:29 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 12101 invoked by uid 89); 24 Feb 2014 18:31:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oa0-f43.google.com Received: from mail-oa0-f43.google.com (HELO mail-oa0-f43.google.com) (209.85.219.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 24 Feb 2014 18:31:27 +0000 Received: by mail-oa0-f43.google.com with SMTP id i7so4475882oag.16 for ; Mon, 24 Feb 2014 10:31:25 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.182.4.232 with SMTP id n8mr18570132obn.34.1393266685505; Mon, 24 Feb 2014 10:31:25 -0800 (PST) Received: by 10.182.162.36 with HTTP; Mon, 24 Feb 2014 10:31:25 -0800 (PST) In-Reply-To: <20140224175853.GB16545@redhat.com> References: <20140222181444.GJ10901@redhat.com> <20140222194827.GK10901@redhat.com> <20140224175853.GB16545@redhat.com> Date: Mon, 24 Feb 2014 18:31:00 -0000 Message-ID: Subject: Re: [C PATCH] remove goto in c_parser_sizeof_expression From: Prathamesh Kulkarni To: Marek Polacek Cc: gcc-patches@gcc.gnu.org, "Joseph S. Myers" Content-Type: multipart/mixed; boundary=f46d0438946dde0b6a04f32b2d4d X-IsSubscribed: yes X-SW-Source: 2014-02/txt/msg01441.txt.bz2 --f46d0438946dde0b6a04f32b2d4d Content-Type: text/plain; charset=ISO-8859-1 Content-length: 1118 On Mon, Feb 24, 2014 at 11:28 PM, Marek Polacek wrote: > On Mon, Feb 24, 2014 at 11:08:27PM +0530, Prathamesh Kulkarni wrote: >> I apologize for bothering with stupid mistakes. > > No problem, it takes some time to get up to speed. > >> + mark_exp_read (expr.value); >> + if (TREE_CODE (expr.value) == COMPONENT_REF >> + && DECL_C_BIT_FIELD (TREE_OPERAND (expr.value, 1))) >> + error_at (expr_loc, "% applied to a bit-field"); >> + return c_expr_sizeof_expr (expr_loc, expr); >> } > > This still doesn't seem quite right. As I said: > >> > And this should be >> > if (TREE_CODE (expr.value) == COMPONENT_REF >> > && DECL_C_BIT_FIELD (TREE_OPERAND (expr.value, 1))) >> > error_at (expr_loc, "% applied to a bit-field"); >> > return c_expr_sizeof_expr (expr_loc, expr); >> > > > That is, no tab before error_at (...), but four spaces. > (Of course there's no need to retest the patch when making such > trivial adjustments.) > Replaced tab by 4 spaces before error_at. * c-parser.c (c_parser_sizeof_expression): Remove goto sizeof_expr. > Marek --f46d0438946dde0b6a04f32b2d4d Content-Type: text/x-patch; charset=US-ASCII; name="rm-goto.patch" Content-Disposition: attachment; filename="rm-goto.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hs22y44x0 Content-length: 2282 SW5kZXg6IGdjYy9jL2MtcGFyc2VyLmMKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gZ2NjL2MvYy1wYXJzZXIuYwkocmV2aXNpb24gMjA3OTE2KQorKysg Z2NjL2MvYy1wYXJzZXIuYwkod29ya2luZyBjb3B5KQpAQCAtNjUxNCwzMCAr NjUxNCwyOSBAQCBjX3BhcnNlcl9zaXplb2ZfZXhwcmVzc2lvbiAoY19wYXJz ZXIgKnBhCiAJICByZXR1cm4gcmV0OwogCX0KICAgICAgIGlmIChjX3BhcnNl cl9uZXh0X3Rva2VuX2lzIChwYXJzZXIsIENQUF9PUEVOX0JSQUNFKSkKKwll eHByID0gY19wYXJzZXJfcG9zdGZpeF9leHByZXNzaW9uX2FmdGVyX3BhcmVu X3R5cGUgKHBhcnNlciwKKwkJCQkJCQkgICAgIHR5cGVfbmFtZSwKKwkJCQkJ CQkgICAgIGV4cHJfbG9jKTsKKyAgICAgIGVsc2UKIAl7Ci0JICBleHByID0g Y19wYXJzZXJfcG9zdGZpeF9leHByZXNzaW9uX2FmdGVyX3BhcmVuX3R5cGUg KHBhcnNlciwKLQkJCQkJCQkgICAgICAgdHlwZV9uYW1lLAotCQkJCQkJCSAg ICAgICBleHByX2xvYyk7Ci0JICBnb3RvIHNpemVvZl9leHByOworCSAgLyog c2l6ZW9mICggdHlwZS1uYW1lICkuICAqLworCSAgY19pbmhpYml0X2V2YWx1 YXRpb25fd2FybmluZ3MtLTsKKwkgIGluX3NpemVvZi0tOworCSAgcmV0dXJu IGNfZXhwcl9zaXplb2ZfdHlwZSAoZXhwcl9sb2MsIHR5cGVfbmFtZSk7CiAJ fQotICAgICAgLyogc2l6ZW9mICggdHlwZS1uYW1lICkuICAqLwotICAgICAg Y19pbmhpYml0X2V2YWx1YXRpb25fd2FybmluZ3MtLTsKLSAgICAgIGluX3Np emVvZi0tOwotICAgICAgcmV0dXJuIGNfZXhwcl9zaXplb2ZfdHlwZSAoZXhw cl9sb2MsIHR5cGVfbmFtZSk7CiAgICAgfQogICBlbHNlCiAgICAgewogICAg ICAgZXhwcl9sb2MgPSBjX3BhcnNlcl9wZWVrX3Rva2VuIChwYXJzZXIpLT5s b2NhdGlvbjsKICAgICAgIGV4cHIgPSBjX3BhcnNlcl91bmFyeV9leHByZXNz aW9uIChwYXJzZXIpOwotICAgIHNpemVvZl9leHByOgotICAgICAgY19pbmhp Yml0X2V2YWx1YXRpb25fd2FybmluZ3MtLTsKLSAgICAgIGluX3NpemVvZi0t OwotICAgICAgbWFya19leHBfcmVhZCAoZXhwci52YWx1ZSk7Ci0gICAgICBp ZiAoVFJFRV9DT0RFIChleHByLnZhbHVlKSA9PSBDT01QT05FTlRfUkVGCi0J ICAmJiBERUNMX0NfQklUX0ZJRUxEIChUUkVFX09QRVJBTkQgKGV4cHIudmFs dWUsIDEpKSkKLQllcnJvcl9hdCAoZXhwcl9sb2MsICIlPHNpemVvZiU+IGFw cGxpZWQgdG8gYSBiaXQtZmllbGQiKTsKLSAgICAgIHJldHVybiBjX2V4cHJf c2l6ZW9mX2V4cHIgKGV4cHJfbG9jLCBleHByKTsKICAgICB9CisgIGNfaW5o aWJpdF9ldmFsdWF0aW9uX3dhcm5pbmdzLS07CisgIGluX3NpemVvZi0tOwor ICBtYXJrX2V4cF9yZWFkIChleHByLnZhbHVlKTsKKyAgaWYgKFRSRUVfQ09E RSAoZXhwci52YWx1ZSkgPT0gQ09NUE9ORU5UX1JFRgorICAgICAgJiYgREVD TF9DX0JJVF9GSUVMRCAoVFJFRV9PUEVSQU5EIChleHByLnZhbHVlLCAxKSkp CisgICAgZXJyb3JfYXQgKGV4cHJfbG9jLCAiJTxzaXplb2YlPiBhcHBsaWVk IHRvIGEgYml0LWZpZWxkIik7CisgIHJldHVybiBjX2V4cHJfc2l6ZW9mX2V4 cHIgKGV4cHJfbG9jLCBleHByKTsKIH0KIAogLyogUGFyc2UgYW4gYWxpZ25v ZiBleHByZXNzaW9uLiAgKi8K --f46d0438946dde0b6a04f32b2d4d--