* Re: [google-4.6]Backport r183875 to fix incorrect increment/decrement of atomic pointers (issue 6428056)
@ 2012-07-19 22:29 dougkwan
2012-07-19 22:48 ` Jing Yu
0 siblings, 1 reply; 3+ messages in thread
From: dougkwan @ 2012-07-19 22:29 UTC (permalink / raw)
To: jingyu, jyasskin; +Cc: gcc-patches, reply
This seems to be different from r183875. Are the parts chaing
is_look_free() in r183875 necessary? If not why?
http://codereview.appspot.com/6428056/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [google-4.6]Backport r183875 to fix incorrect increment/decrement of atomic pointers (issue 6428056)
2012-07-19 22:29 [google-4.6]Backport r183875 to fix incorrect increment/decrement of atomic pointers (issue 6428056) dougkwan
@ 2012-07-19 22:48 ` Jing Yu
0 siblings, 0 replies; 3+ messages in thread
From: Jing Yu @ 2012-07-19 22:48 UTC (permalink / raw)
To: jingyu, jyasskin, dougkwan, gcc-patches, reply
It is not a straightforward backport.
<atomic> has changed a lot in gcc-4.7. is_lock_free() body is entirely
different between gcc-4.6 and r183875. In gcc-4.6, is_lock_free()
simply returns false or true. Notice that gcc-4.6 defines two
namesapce __atomic0, __atomic2 in separate files (atomic_0.h,
atomic_2.h), which disappear in gcc-4.7.
Even though, the idea behind the bug is the same. The new unit tests
will fail without this patch.
Thanks,
Jing
Even though, the bug is the same. the new unit tests will
On Thu, Jul 19, 2012 at 3:29 PM, <dougkwan@google.com> wrote:
> This seems to be different from r183875. Are the parts chaing
> is_look_free() in r183875 necessary? If not why?
>
> http://codereview.appspot.com/6428056/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [google-4.6]Backport r183875 to fix incorrect increment/decrement of atomic pointers (issue 6428056)
@ 2012-07-19 23:55 dougkwan
0 siblings, 0 replies; 3+ messages in thread
From: dougkwan @ 2012-07-19 23:55 UTC (permalink / raw)
To: jingyu, jyasskin; +Cc: gcc-patches, reply
LGTM.
http://codereview.appspot.com/6428056/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-07-19 23:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-19 22:29 [google-4.6]Backport r183875 to fix incorrect increment/decrement of atomic pointers (issue 6428056) dougkwan
2012-07-19 22:48 ` Jing Yu
2012-07-19 23:55 dougkwan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).