From: Cary Coutant <ccoutant@gmail.com>
To: Alexandre Oliva <aoliva@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, Jason Merrill <jason@redhat.com>
Subject: Re: [PR63238] output alignment debug information
Date: Fri, 17 Mar 2017 03:13:00 -0000 [thread overview]
Message-ID: <CAJimCsH0fFqX7UkE=_x85=kXNR=MJqtOBozkDkRuF9OycFuocg@mail.gmail.com> (raw)
In-Reply-To: <or7f5cfnty.fsf@lxoliva.fsfla.org>
>> This is OK so far, but the DW_AT_alignment attribute also needs to be
>> added to the checksum computation in die_checksum and
>> die_checksum_ordered.
>
> Thanks. I see what to do in die_checksum_ordered, but die_checksum? It
> seems to handle attributes by value class, and AFAICT the classes that
> DW_AT_alignment could use are already covered. What am I missing?
>
> Here's a patch I'm about to start testing. Does it look ok?
Sorry, I read this while I wasn't in a position to reply, then totally
forgot about it. Yes, you're right about die_checksum, sorry. And, for
the record, it looks OK.
-cary
next prev parent reply other threads:[~2017-03-17 3:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-27 4:48 Alexandre Oliva
2016-09-24 0:22 ` Alexandre Oliva
2016-10-19 10:15 ` Alexandre Oliva
2017-01-27 6:37 ` Alexandre Oliva
2017-01-29 18:55 ` Cary Coutant
2017-01-30 17:55 ` Alexandre Oliva
2017-03-17 3:13 ` Cary Coutant [this message]
2017-02-01 15:55 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJimCsH0fFqX7UkE=_x85=kXNR=MJqtOBozkDkRuF9OycFuocg@mail.gmail.com' \
--to=ccoutant@gmail.com \
--cc=aoliva@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).