From: "Håkon Sandsmark" <hsandsmark@gmail.com>
To: Jason Merrill <jason@redhat.com>
Cc: Paolo Carlini <paolo.carlini@oracle.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix PR c++/71546 - lambda capture fails with "was not declared in this scope"
Date: Tue, 27 Feb 2018 21:09:00 -0000 [thread overview]
Message-ID: <CAK0fzjrKs3VURh_n-H6TxH2s5rkzZHx=DmTraNW8hWKwcRjXsQ@mail.gmail.com> (raw)
In-Reply-To: <50043d2b-3ea2-9319-aa24-183920408825@redhat.com>
2018-02-27 22:02 GMT+01:00 Jason Merrill <jason@redhat.com>:
> On 02/27/2018 03:29 PM, Jason Merrill wrote:
>>
>> On 02/27/2018 01:51 PM, Håkon Sandsmark wrote:
>>>
>>> Thanks for the feedback. I chose to take the example from the bug
>>> report verbatim as the test case.
>>>
>>> However, I agree it makes sense to have the simplest possible test
>>> case that reproduces the issue. Here is an updated patch.
>>
>>
>> Thanks!
>>
>>> + /* If there is any qualification still in effect, clear it
>>> + * now; we will be starting fresh with the next capture. */
>>
>>
>> For future reference, we don't add * at the beginning of subsequent lines
>> in a comment. I'll correct that in this patch and check it in.
>
>
> Done. FYI I also renamed the testcase to lambda-init17.C; I sometimes like
> to run e.g. the *lambda* tests as a smoke test, and "pr12345" isn't very
> useful for that.
Thanks for the quick turnaround! I was unsure about the naming of the
file myself.
I'll definitely look into the copyright assignment for the future.
> Jason
Håkon
prev parent reply other threads:[~2018-02-27 21:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 16:42 Håkon Sandsmark
2018-02-27 18:06 ` Paolo Carlini
2018-02-27 18:15 ` Paolo Carlini
2018-02-27 18:51 ` Håkon Sandsmark
2018-02-27 20:29 ` Jason Merrill
2018-02-27 21:02 ` Jason Merrill
2018-02-27 21:09 ` Håkon Sandsmark [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK0fzjrKs3VURh_n-H6TxH2s5rkzZHx=DmTraNW8hWKwcRjXsQ@mail.gmail.com' \
--to=hsandsmark@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=paolo.carlini@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).