* [PATCH] Small fix: add { dg-require-effective-target vect_int } to testsuite/gcc.dg/vect/pr58508.c
@ 2013-11-01 17:47 Cong Hou
2013-11-08 5:46 ` Cong Hou
0 siblings, 1 reply; 7+ messages in thread
From: Cong Hou @ 2013-11-01 17:47 UTC (permalink / raw)
To: GCC Patches
It seems that on some platforms the loops in
testsuite/gcc.dg/vect/pr58508.c may be unable to be vectorized. This
small patch added { dg-require-effective-target vect_int } to make
sure all loops can be vectorized.
thanks,
Cong
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 9d0f4a5..3d9916d 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2013-10-29 Cong Hou <congh@google.com>
+
+ * gcc.dg/vect/pr58508.c: Update.
+
2013-10-15 Cong Hou <congh@google.com>
* gcc.dg/vect/pr58508.c: New test.
diff --git a/gcc/testsuite/gcc.dg/vect/pr58508.c
b/gcc/testsuite/gcc.dg/vect/pr58508.c
index 6484a65..fff7a04 100644
--- a/gcc/testsuite/gcc.dg/vect/pr58508.c
+++ b/gcc/testsuite/gcc.dg/vect/pr58508.c
@@ -1,3 +1,4 @@
+/* { dg-require-effective-target vect_int } */
/* { dg-do compile } */
/* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details" } */
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Small fix: add { dg-require-effective-target vect_int } to testsuite/gcc.dg/vect/pr58508.c
2013-11-01 17:47 [PATCH] Small fix: add { dg-require-effective-target vect_int } to testsuite/gcc.dg/vect/pr58508.c Cong Hou
@ 2013-11-08 5:46 ` Cong Hou
2013-11-08 10:09 ` Richard Biener
2013-11-12 15:14 ` Jakub Jelinek
0 siblings, 2 replies; 7+ messages in thread
From: Cong Hou @ 2013-11-08 5:46 UTC (permalink / raw)
To: GCC Patches
Ping. OK for the trunk?
thanks,
Cong
On Fri, Nov 1, 2013 at 10:47 AM, Cong Hou <congh@google.com> wrote:
> It seems that on some platforms the loops in
> testsuite/gcc.dg/vect/pr58508.c may be unable to be vectorized. This
> small patch added { dg-require-effective-target vect_int } to make
> sure all loops can be vectorized.
>
>
> thanks,
> Cong
>
>
> diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
> index 9d0f4a5..3d9916d 100644
> --- a/gcc/testsuite/ChangeLog
> +++ b/gcc/testsuite/ChangeLog
> @@ -1,3 +1,7 @@
> +2013-10-29 Cong Hou <congh@google.com>
> +
> + * gcc.dg/vect/pr58508.c: Update.
> +
> 2013-10-15 Cong Hou <congh@google.com>
>
> * gcc.dg/vect/pr58508.c: New test.
> diff --git a/gcc/testsuite/gcc.dg/vect/pr58508.c
> b/gcc/testsuite/gcc.dg/vect/pr58508.c
> index 6484a65..fff7a04 100644
> --- a/gcc/testsuite/gcc.dg/vect/pr58508.c
> +++ b/gcc/testsuite/gcc.dg/vect/pr58508.c
> @@ -1,3 +1,4 @@
> +/* { dg-require-effective-target vect_int } */
> /* { dg-do compile } */
> /* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details" } */
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Small fix: add { dg-require-effective-target vect_int } to testsuite/gcc.dg/vect/pr58508.c
2013-11-08 5:46 ` Cong Hou
@ 2013-11-08 10:09 ` Richard Biener
2013-11-12 15:14 ` Jakub Jelinek
1 sibling, 0 replies; 7+ messages in thread
From: Richard Biener @ 2013-11-08 10:09 UTC (permalink / raw)
To: Cong Hou; +Cc: GCC Patches
On Fri, Nov 8, 2013 at 3:24 AM, Cong Hou <congh@google.com> wrote:
> Ping. OK for the trunk?
Ok.
Thanks,
Richard.
>
>
>
> thanks,
> Cong
>
>
> On Fri, Nov 1, 2013 at 10:47 AM, Cong Hou <congh@google.com> wrote:
>> It seems that on some platforms the loops in
>> testsuite/gcc.dg/vect/pr58508.c may be unable to be vectorized. This
>> small patch added { dg-require-effective-target vect_int } to make
>> sure all loops can be vectorized.
>>
>>
>> thanks,
>> Cong
>>
>>
>> diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
>> index 9d0f4a5..3d9916d 100644
>> --- a/gcc/testsuite/ChangeLog
>> +++ b/gcc/testsuite/ChangeLog
>> @@ -1,3 +1,7 @@
>> +2013-10-29 Cong Hou <congh@google.com>
>> +
>> + * gcc.dg/vect/pr58508.c: Update.
>> +
>> 2013-10-15 Cong Hou <congh@google.com>
>>
>> * gcc.dg/vect/pr58508.c: New test.
>> diff --git a/gcc/testsuite/gcc.dg/vect/pr58508.c
>> b/gcc/testsuite/gcc.dg/vect/pr58508.c
>> index 6484a65..fff7a04 100644
>> --- a/gcc/testsuite/gcc.dg/vect/pr58508.c
>> +++ b/gcc/testsuite/gcc.dg/vect/pr58508.c
>> @@ -1,3 +1,4 @@
>> +/* { dg-require-effective-target vect_int } */
>> /* { dg-do compile } */
>> /* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details" } */
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Small fix: add { dg-require-effective-target vect_int } to testsuite/gcc.dg/vect/pr58508.c
2013-11-08 5:46 ` Cong Hou
2013-11-08 10:09 ` Richard Biener
@ 2013-11-12 15:14 ` Jakub Jelinek
2013-11-12 18:26 ` Cong Hou
1 sibling, 1 reply; 7+ messages in thread
From: Jakub Jelinek @ 2013-11-12 15:14 UTC (permalink / raw)
To: Cong Hou; +Cc: GCC Patches
On Thu, Nov 07, 2013 at 06:24:55PM -0800, Cong Hou wrote:
> Ping. OK for the trunk?
> On Fri, Nov 1, 2013 at 10:47 AM, Cong Hou <congh@google.com> wrote:
> > It seems that on some platforms the loops in
> > testsuite/gcc.dg/vect/pr58508.c may be unable to be vectorized. This
> > small patch added { dg-require-effective-target vect_int } to make
> > sure all loops can be vectorized.
> > diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
> > index 9d0f4a5..3d9916d 100644
> > --- a/gcc/testsuite/ChangeLog
> > +++ b/gcc/testsuite/ChangeLog
> > @@ -1,3 +1,7 @@
> > +2013-10-29 Cong Hou <congh@google.com>
> > +
> > + * gcc.dg/vect/pr58508.c: Update.
> > +
> > 2013-10-15 Cong Hou <congh@google.com>
> >
> > * gcc.dg/vect/pr58508.c: New test.
> > diff --git a/gcc/testsuite/gcc.dg/vect/pr58508.c
> > b/gcc/testsuite/gcc.dg/vect/pr58508.c
> > index 6484a65..fff7a04 100644
> > --- a/gcc/testsuite/gcc.dg/vect/pr58508.c
> > +++ b/gcc/testsuite/gcc.dg/vect/pr58508.c
> > @@ -1,3 +1,4 @@
> > +/* { dg-require-effective-target vect_int } */
> > /* { dg-do compile } */
> > /* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details" } */
This isn't the only bug in the testcase. Another one is using
dg-options in gcc.dg/vect/, you should just leave that out,
the default options already include those options, but explicit dg-options
mean that other required options like -msse2 on i?86 aren't added.
Jakub
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Small fix: add { dg-require-effective-target vect_int } to testsuite/gcc.dg/vect/pr58508.c
2013-11-12 15:14 ` Jakub Jelinek
@ 2013-11-12 18:26 ` Cong Hou
2013-11-12 18:34 ` Jakub Jelinek
0 siblings, 1 reply; 7+ messages in thread
From: Cong Hou @ 2013-11-12 18:26 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: GCC Patches
Hi Jakub
Thank you for pointing it out. The updated patch is pasted below. I
will pay attention to it in the future.
thanks,
Cong
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 3d9916d..32a6ff7 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2013-11-12 Cong Hou <congh@google.com>
+
+ * gcc.dg/vect/pr58508.c: Remove dg-options as vect_int is indicated.
+
2013-10-29 Cong Hou <congh@google.com>
* gcc.dg/vect/pr58508.c: Update.
diff --git a/gcc/testsuite/gcc.dg/vect/pr58508.c
b/gcc/testsuite/gcc.dg/vect/pr58508.c
index fff7a04..c4921bb 100644
--- a/gcc/testsuite/gcc.dg/vect/pr58508.c
+++ b/gcc/testsuite/gcc.dg/vect/pr58508.c
@@ -1,6 +1,5 @@
/* { dg-require-effective-target vect_int } */
/* { dg-do compile } */
-/* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details" } */
/* The GCC vectorizer generates loop versioning for the following loop
On Tue, Nov 12, 2013 at 6:05 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Thu, Nov 07, 2013 at 06:24:55PM -0800, Cong Hou wrote:
>> Ping. OK for the trunk?
>> On Fri, Nov 1, 2013 at 10:47 AM, Cong Hou <congh@google.com> wrote:
>> > It seems that on some platforms the loops in
>> > testsuite/gcc.dg/vect/pr58508.c may be unable to be vectorized. This
>> > small patch added { dg-require-effective-target vect_int } to make
>> > sure all loops can be vectorized.
>> > diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
>> > index 9d0f4a5..3d9916d 100644
>> > --- a/gcc/testsuite/ChangeLog
>> > +++ b/gcc/testsuite/ChangeLog
>> > @@ -1,3 +1,7 @@
>> > +2013-10-29 Cong Hou <congh@google.com>
>> > +
>> > + * gcc.dg/vect/pr58508.c: Update.
>> > +
>> > 2013-10-15 Cong Hou <congh@google.com>
>> >
>> > * gcc.dg/vect/pr58508.c: New test.
>> > diff --git a/gcc/testsuite/gcc.dg/vect/pr58508.c
>> > b/gcc/testsuite/gcc.dg/vect/pr58508.c
>> > index 6484a65..fff7a04 100644
>> > --- a/gcc/testsuite/gcc.dg/vect/pr58508.c
>> > +++ b/gcc/testsuite/gcc.dg/vect/pr58508.c
>> > @@ -1,3 +1,4 @@
>> > +/* { dg-require-effective-target vect_int } */
>> > /* { dg-do compile } */
>> > /* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details" } */
>
> This isn't the only bug in the testcase. Another one is using
> dg-options in gcc.dg/vect/, you should just leave that out,
> the default options already include those options, but explicit dg-options
> mean that other required options like -msse2 on i?86 aren't added.
>
> Jakub
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Small fix: add { dg-require-effective-target vect_int } to testsuite/gcc.dg/vect/pr58508.c
2013-11-12 18:26 ` Cong Hou
@ 2013-11-12 18:34 ` Jakub Jelinek
2013-11-12 18:47 ` Cong Hou
0 siblings, 1 reply; 7+ messages in thread
From: Jakub Jelinek @ 2013-11-12 18:34 UTC (permalink / raw)
To: Cong Hou; +Cc: GCC Patches
On Tue, Nov 12, 2013 at 10:04:15AM -0800, Cong Hou wrote:
> Thank you for pointing it out. The updated patch is pasted below. I
> will pay attention to it in the future.
Ok, thanks.
Note, you can use dg-additional-options if needed in g*.dg/vect/, just not
dg-options.
> --- a/gcc/testsuite/ChangeLog
> +++ b/gcc/testsuite/ChangeLog
> @@ -1,3 +1,7 @@
> +2013-11-12 Cong Hou <congh@google.com>
> +
> + * gcc.dg/vect/pr58508.c: Remove dg-options as vect_int is indicated.
> +
> 2013-10-29 Cong Hou <congh@google.com>
>
> * gcc.dg/vect/pr58508.c: Update.
> diff --git a/gcc/testsuite/gcc.dg/vect/pr58508.c
> b/gcc/testsuite/gcc.dg/vect/pr58508.c
> index fff7a04..c4921bb 100644
> --- a/gcc/testsuite/gcc.dg/vect/pr58508.c
> +++ b/gcc/testsuite/gcc.dg/vect/pr58508.c
> @@ -1,6 +1,5 @@
> /* { dg-require-effective-target vect_int } */
> /* { dg-do compile } */
> -/* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details" } */
>
>
> /* The GCC vectorizer generates loop versioning for the following loop
Jakub
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Small fix: add { dg-require-effective-target vect_int } to testsuite/gcc.dg/vect/pr58508.c
2013-11-12 18:34 ` Jakub Jelinek
@ 2013-11-12 18:47 ` Cong Hou
0 siblings, 0 replies; 7+ messages in thread
From: Cong Hou @ 2013-11-12 18:47 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: GCC Patches
Got it!
thanks,
Cong
On Tue, Nov 12, 2013 at 10:05 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Tue, Nov 12, 2013 at 10:04:15AM -0800, Cong Hou wrote:
>> Thank you for pointing it out. The updated patch is pasted below. I
>> will pay attention to it in the future.
>
> Ok, thanks.
> Note, you can use dg-additional-options if needed in g*.dg/vect/, just not
> dg-options.
>
>> --- a/gcc/testsuite/ChangeLog
>> +++ b/gcc/testsuite/ChangeLog
>> @@ -1,3 +1,7 @@
>> +2013-11-12 Cong Hou <congh@google.com>
>> +
>> + * gcc.dg/vect/pr58508.c: Remove dg-options as vect_int is indicated.
>> +
>> 2013-10-29 Cong Hou <congh@google.com>
>>
>> * gcc.dg/vect/pr58508.c: Update.
>> diff --git a/gcc/testsuite/gcc.dg/vect/pr58508.c
>> b/gcc/testsuite/gcc.dg/vect/pr58508.c
>> index fff7a04..c4921bb 100644
>> --- a/gcc/testsuite/gcc.dg/vect/pr58508.c
>> +++ b/gcc/testsuite/gcc.dg/vect/pr58508.c
>> @@ -1,6 +1,5 @@
>> /* { dg-require-effective-target vect_int } */
>> /* { dg-do compile } */
>> -/* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details" } */
>>
>>
>> /* The GCC vectorizer generates loop versioning for the following loop
>
> Jakub
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-11-12 18:10 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-01 17:47 [PATCH] Small fix: add { dg-require-effective-target vect_int } to testsuite/gcc.dg/vect/pr58508.c Cong Hou
2013-11-08 5:46 ` Cong Hou
2013-11-08 10:09 ` Richard Biener
2013-11-12 15:14 ` Jakub Jelinek
2013-11-12 18:26 ` Cong Hou
2013-11-12 18:34 ` Jakub Jelinek
2013-11-12 18:47 ` Cong Hou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).