From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25567 invoked by alias); 11 Jan 2013 17:37:37 -0000 Received: (qmail 25386 invoked by uid 22791); 11 Jan 2013 17:37:35 -0000 X-SWARE-Spam-Status: No, hits=-3.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-oa0-f45.google.com (HELO mail-oa0-f45.google.com) (209.85.219.45) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Jan 2013 17:37:29 +0000 Received: by mail-oa0-f45.google.com with SMTP id i18so2057913oag.18 for ; Fri, 11 Jan 2013 09:37:28 -0800 (PST) MIME-Version: 1.0 Received: by 10.182.193.65 with SMTP id hm1mr9039090obc.32.1357925848630; Fri, 11 Jan 2013 09:37:28 -0800 (PST) Received: by 10.76.34.33 with HTTP; Fri, 11 Jan 2013 09:37:28 -0800 (PST) In-Reply-To: References: Date: Fri, 11 Jan 2013 17:37:00 -0000 Message-ID: Subject: Re: [RFC, middlend] Fix for PR54218 From: George Thomas To: Andrew Pinski Cc: gcc-patches@gcc.gnu.org Content-Type: multipart/mixed; boundary=f46d04478693d6c4c904d306bffb Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-01/txt/msg00622.txt.bz2 --f46d04478693d6c4c904d306bffb Content-Type: text/plain; charset=ISO-8859-1 Content-length: 1393 On Fri, Jan 11, 2013 at 9:53 PM, Andrew Pinski wrote: > On Fri, Jan 11, 2013 at 8:17 AM, George Thomas > wrote: >> Hi, >> >> I am sending a patch which solves the debugging issue (PR 54218). >> >> The fix is to allocate stack space only once for parameters in expand pass. >> >> The patch is attached. Could someone suggest if its right ? > > I have just a formatting issue: > + if (TREE_CODE (SSA_NAME_VAR (var)) != PARM_DECL) > + { > + if (!bitmap_bit_p (SA.partition_has_default_def, i)) > > I think it would have been better if you had done instead: > if (TREE_CODE (SSA_NAME_VAR (var)) != PARM_DECL > && !bitmap_bit_p (SA.partition_has_default_def, i)) > I have attached the updated patch with the changes suggested. Also adding a dejagnu test case to reproduce the bug. > So there are no other white space changes. > > Also missing a changelog entry too. > I am adding the change logs below. 2013-01-11 George Thomas Senthil Kumar Selvaraj PR middle-end/54218 * gcc/cfgexpand.c (expand_used_vars ) :Added a step to not allocate stack space if its a parameter * gcc.dg/pr54218.c : New test Hoping that the changes are fine for trunk. Thanks, George --f46d04478693d6c4c904d306bffb Content-Type: application/octet-stream; name="PR54218.patch" Content-Disposition: attachment; filename="PR54218.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hbtlw7ve0 Content-length: 1940 ZGlmZiAtTmF1cnAgZ2NjL2NmZ2V4cGFuZC5jIGdjYy9jZmdleHBhbmQuYwot LS0gZ2NjL2NmZ2V4cGFuZC5jCTIwMTMtMDEtMTEgMTY6NDA6NDYuMDAwMDAw MDAwICswNTMwCisrKyBnY2MvY2ZnZXhwYW5kLmMJMjAxMy0wMS0xMSAyMjo1 Nzo0OC4wMDAwMDAwMDAgKzA1MzAKQEAgLTE1NjgsMTEgKzE1NjgsMTIgQEAg ZXhwYW5kX3VzZWRfdmFycyAodm9pZCkKIAkgICAgIHdlIGRvbid0IGRvIGFu eXRoaW5nIGhlcmUuICBCdXQgdGhvc2Ugd2hpY2ggZG9uJ3QgY29udGFpbiB0 aGUKIAkgICAgIGRlZmF1bHQgZGVmIChyZXByZXNlbnRpbmcgYSB0ZW1wb3Jh cnkgYmFzZWQgb24gdGhlIHBhcm0vcmVzdWx0KQogCSAgICAgd2UgbmVlZCB0 byBhbGxvY2F0ZSBzcGFjZSBqdXN0IGxpa2UgZm9yIG5vcm1hbCBWQVJfREVD THMuICAqLwotCSAgaWYgKCFiaXRtYXBfYml0X3AgKFNBLnBhcnRpdGlvbl9o YXNfZGVmYXVsdF9kZWYsIGkpKQotCSAgICB7Ci0JICAgICAgZXhwYW5kX29u ZV92YXIgKHZhciwgdHJ1ZSwgdHJ1ZSk7Ci0JICAgICAgZ2NjX2Fzc2VydCAo U0EucGFydGl0aW9uX3RvX3BzZXVkb1tpXSk7Ci0JICAgIH0KKyAgICAgICAg IGlmIChUUkVFX0NPREUgKFNTQV9OQU1FX1ZBUiAodmFyKSkgIT0gUEFSTV9E RUNMCisgICAgICAgICAgJiYgIWJpdG1hcF9iaXRfcCAoU0EucGFydGl0aW9u X2hhc19kZWZhdWx0X2RlZiwgaSkpCisgICAgICAgICAgIHsKKyAgICAgICAg ICAgICBleHBhbmRfb25lX3ZhciAodmFyLCB0cnVlLCB0cnVlKTsKKyAgICAg ICAgICAgICBnY2NfYXNzZXJ0IChTQS5wYXJ0aXRpb25fdG9fcHNldWRvW2ld KTsKKyAgICAgICAgICAgfQogCX0KICAgICB9CiAgIHBvaW50ZXJfbWFwX2Rl c3Ryb3kgKHNzYV9uYW1lX2RlY2xzKTsKZGlmZiAtTmF1cnAgZ2NjL3Rlc3Rz dWl0ZS9nY2MuZGcvcHI1NDIxOC5jIGdjYy90ZXN0c3VpdGUvZ2NjLmRnL3By NTQyMTguYwotLS0gZ2NjL3Rlc3RzdWl0ZS9nY2MuZGcvcHI1NDIxOC5jCTE5 NzAtMDEtMDEgMDU6MzA6MDAuMDAwMDAwMDAwICswNTMwCisrKyBnY2MvdGVz dHN1aXRlL2djYy5kZy9wcjU0MjE4LmMJMjAxMy0wMS0xMSAyMjozOTowNy4w MDAwMDAwMDAgKzA1MzAKQEAgLTAsMCArMSwxNiBAQAorLyogeyBkZy1kbyBy dW4gfSAqLworLyogeyBkZy1vcHRpb25zICItZyAtZnZhci10cmFja2luZyIg fSAqLworLyogeyBkZy1za2lwLWlmICIiIHsgKi0qLSogfSAgeyAiKiIgfSB7 ICItTzAiIH0gfSAqLworCit2b2lkIGZ1bmMoaW50IHApCit7CisgICAgcCA9 IDA7IC8qIHsgZGctZmluYWwgeyBnZGItdGVzdCA4ICJwIiAiMCIgfSB9ICov CisgICAgcCA9IDMyOy8qIHsgZGctZmluYWwgeyBnZGItdGVzdCA4ICJwIiAi NDIiIH0gfSAqLworfQorCitpbnQKK21haW4gKHZvaWQpCit7CisgICAgaW50 IGxvY2FsID0gNDI7CisgICAgZnVuYyhsb2NhbCk7Cit9Cg== --f46d04478693d6c4c904d306bffb--