From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by sourceware.org (Postfix) with ESMTPS id 1BB65385771A for ; Fri, 16 Jun 2023 17:01:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1BB65385771A Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=google.com Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-51a3f911135so916360a12.2 for ; Fri, 16 Jun 2023 10:01:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1686934884; x=1689526884; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=BF5F5T78sqVmuasb0WrIbhefXXyLOzuQSSITQsixq/I=; b=LrPGMuCa5yxsFQCo58t31yglZFGtSg50ONVIcmH2iEFVKez4TQLPWn07teBsf/ZK4r f5e8gf/jy5SmgXLc5MCEkZd3WyjGM9L3yYqc593rI8RlQPaDhGtzkcCakDinOrkP7l5X WpB9nm3QDVZzERsGbPvwWk5P92/sRbd7Fx+FMtpsXhBK//YTeNC5AS80IyQuck52a5nR QqLtiPAdNgzjArBjHw1vzauxUz2Rd67HNs4fpiUaeKNSA2KcaMZ4313ycynzEA2r5nls CScPou5OAnqod4944F64ic+xl4laYz/O6a0DEwc+xivUGVbWBg0okrpUoQ8lx53Qd+pp hW6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686934884; x=1689526884; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BF5F5T78sqVmuasb0WrIbhefXXyLOzuQSSITQsixq/I=; b=IF5py/EaLVIuPhbncrlzph7bphyY5GsZjFE64RHYpc4qzfKtsPCLbkix91b5Xv6cUy wMdVN47FjztK2Cr4mCXC/R+3sOHXLaQ4CsaFESvcCDasX0QYFbbPXN6Wnd2RLh0Uhs9w WywAhByED07GZGnWhf/SMtiuZIPYOLtDCBoCxlg49UITaVfN6UgLgSn3qNvkXxebTpsh f83XQnA6yzL1JPxFWmPYutmMvhZwp/Zp4YWEbfGWtHKJnTQcOJTDNE5APvH9jl0SXGje y7OgE6xdLK0rpVcrGABcy5UfqtooxsDj8CYsdc7eiOXkycyKmijEk36FpofzrT3W70zK qJAw== X-Gm-Message-State: AC+VfDwC6GR4qNczCDLo+2O82ED2ynRrks36fuqlNuKAELCt3MFd+/Jk e5iYbP6saogLCJi7cq1u5n55NWc65z5/7/XmiM5/dQ== X-Google-Smtp-Source: ACHHUZ7zXx2MfRFkIwfFwerRMeKoTo+mVltYVrR2v1bneZn5AFCuC5V1K+qX0rhJe9Sj4SGl0cHAIb8suJzYYdXEGV8= X-Received: by 2002:aa7:d903:0:b0:518:5f8e:53b8 with SMTP id a3-20020aa7d903000000b005185f8e53b8mr1729127edr.13.1686934884571; Fri, 16 Jun 2023 10:01:24 -0700 (PDT) MIME-Version: 1.0 References: <20230616160002.1854983-1-murphyp@linux.ibm.com> In-Reply-To: <20230616160002.1854983-1-murphyp@linux.ibm.com> From: Ian Lance Taylor Date: Fri, 16 Jun 2023 10:01:12 -0700 Message-ID: Subject: Re: [PATCH 1/2] go: update usage of TARGET_AIX to TARGET_AIX_OS To: "Paul E. Murphy" Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-17.1 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Jun 16, 2023 at 9:00=E2=80=AFAM Paul E. Murphy via Gcc-patches wrote: > > TARGET_AIX is defined to a non-zero value on linux and maybe other > powerpc64le targets. This leads to unexpected behavior such as > dropping the .go_export section when linking a shared library > on linux/powerpc64le. > > Instead, use TARGET_AIX_OS to toggle AIX specific behavior. > > Fixes golang/go#60798. > > gcc/go/ChangeLog: > > * go-backend.cc [TARGET_AIX]: Rename and update usage to > TARGET_AIX_OS. > * go-lang.cc: Likewise. This is OK. Thanks. Ian