From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83128 invoked by alias); 19 Jan 2019 00:54:58 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 81652 invoked by uid 89); 19 Jan 2019 00:54:57 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.9 required=5.0 tests=BAYES_00,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.2 spammy= X-HELO: mail-yw1-f65.google.com Received: from mail-yw1-f65.google.com (HELO mail-yw1-f65.google.com) (209.85.161.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 19 Jan 2019 00:54:56 +0000 Received: by mail-yw1-f65.google.com with SMTP id f65so5948880ywc.8 for ; Fri, 18 Jan 2019 16:54:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vOqSaJXlIMMGJyGa3S1QQ2o3orYZYpjbpDg8I9IZ1KE=; b=BJqcPKX3opjTFMpyh2zyv6T7l1SqsAsD4uIX3v2y+p8DM0mI8z/iVGPQTHkanquwfZ M/Bv/+sbPvA9UZiqeddcN00b7SVYWl0hqOwJ4Can2+oj9FGwnKiGxBtn0+kGZC/Wwn2i F6rR6StY36C/WRa3NWsN/0V9MdwCUjcxIt7OM84TtFHbVW+H1U5Ii1PuOwrMXx6Co/IB c3m5Mdq6xm+efOkKDFr3um9DEgeHWz/6qpB+P+Qd2WOba4AjCvvifndGGXmXHO0Wx2zN rUbhnhAPd+jdXbsFkA7hounrkpd3ZIMqR0A4j5MaF5Xxr75//jJj1iiImGur0+r/pRuz seVw== MIME-Version: 1.0 References: <20181211101411.7067-1-tdevries@suse.de> <20181211101411.7067-10-tdevries@suse.de> <994e3488-ac34-4aea-16f8-2195f0c7b2d0@suse.de> <08b4eea6-96d6-ee29-fe8b-aab008565995@suse.de> In-Reply-To: <08b4eea6-96d6-ee29-fe8b-aab008565995@suse.de> From: "Ian Lance Taylor via gcc-patches" Reply-To: Ian Lance Taylor Date: Sat, 19 Jan 2019 00:54:00 -0000 Message-ID: Subject: Re: [PATCH 9/9] [libbacktrace] Add printdwarftest_dwz_cmp.sh test-case To: Tom de Vries Cc: gcc-patches , Ian Lance Taylor Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg01115.txt.bz2 On Fri, Jan 18, 2019 at 4:45 PM Tom de Vries wrote: > > On 18-01-19 15:23, Ian Lance Taylor wrote: > > On Thu, Jan 17, 2019 at 5:59 AM Tom de Vries wrote: > >> > >> now that the rest of the patch series has been committed, here's an > >> updated version of this patch that applies to trunk. > > > > I would much rather put dwarf_data into internal.h than to #include > > "dwarf.c" from a different file. Using #include with a .c file is > > just a bad path to walk down. > > This version avoids the include of dwarf.c. > > Does that look better? > +printdwarftest_SOURCES = > +printdwarftest_LDADD = libbacktrace.la printdwarftest.lo testlib.lo Seems like you could write printdwarftest_SOURCES = printdwarftest.c testlib.c printdwarftest_LDADD = libbacktrace.la > -static int > +int > dwarf_lookup_pc (struct backtrace_state *state, struct dwarf_data *ddata, Ah, I didn't consider this. We can't do this. It will break code like libsanitizer/libbacktrace/backtrace-rename.h. Is there a way that we could run a similar test looking at the output of readelf --debug? Ian