From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by sourceware.org (Postfix) with ESMTPS id 8F9CA385840D for ; Tue, 23 Apr 2024 17:05:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8F9CA385840D Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=golang.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=google.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8F9CA385840D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::52f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713891909; cv=none; b=HHYWFTnuTsA82nGh9Xs9KeiqYDgYPE2A398Qk1U2zvxiZMdt+RDNS3M7R3pxiyt5sl7QcUaks4R2LiE+uh4b6APLh4oY51dXxMyCh/JCVF1xjvulaqVAANamHZDMErQ+0BNx+hZpNUQe9WUT90+RjGXD8ph1cgAnqV5T6088wOA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713891909; c=relaxed/simple; bh=srd3IiBU9yiIY9h4+UBfyxBr3/f84h8vygEMCHhTF7g=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=b/gYygalW6krVseJVA7icl+BqGt1xuZI2i58MXHD3cpWKb73KytM7ZcT+7BxCODwKUzouKpX17842i/RTXSo04P1qYmpm3Em2HJs/1kqKOHdh3s6NEl0o+U4PMtVypa5aabQW0/GMfZuuGdI07iHrCBlB7Rt7wMrVkfRSbI1DUM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pg1-x52f.google.com with SMTP id 41be03b00d2f7-5d81b08d6f2so4306615a12.0 for ; Tue, 23 Apr 2024 10:05:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google-com.20230601.gappssmtp.com; s=20230601; t=1713891905; x=1714496705; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=OUtNjc5zPGGhOLzLIfV83ogdVG+N/55P5yzACnbiKtQ=; b=YM20vDrdzkqIExPkeEGYn7gIissS8ZwUXlD7KIOOy8Nz41gBel9O+YUvlhK9bKDMQZ spNkMHpNr6MuazZEkDZvdK90D3ZyCwg5E1jng/4yk7V5S1DH56iNSMFxFi8aNDrSR4Ca wvPtfimowtaMWENhEuGOQtLgiWB7lvOI8beLfZZgEJ4MzEB3r4plGB5z5iL4gmptpvnU Fsh89YOMeGU9y8lFz8aFMkiPE+NHxJDhVxAhWhNEE4yflpmnaSrNP0dxXankvZuXJi/V hnFBamT0C29ykFysRy+1B9OrN6rwr1YWpRtWIE3ZD/ZNcJmcZjoRAF2uON3p7dOnhEJS P8dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713891905; x=1714496705; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OUtNjc5zPGGhOLzLIfV83ogdVG+N/55P5yzACnbiKtQ=; b=Z1c/VUPdFnPANuT/pQjgQ8uiHYlX+Fa2QQFBK3B9KsuReP+HoiRFTaMt6PljTV7+iW BkT0xZ6/gvLWGo/pS/c79JbBTfSOMyT2nULTa6VN5mH4ASG0pb96cJEcgWQ87z8MdJJp AMg1oUkAJfoJ1z5NrFsvvEemvBqyLRwgnOhp/9tCR8N9lwPFNJLRIz5Fwtn0uYNFR7ku AysGdG89QqqfRF1kSVJ/Fo3kmExQKIesP9AOsz8AbI2F+h8RqsmzsBWa9PSEsLPh/cH6 NAhUt3ofJZTvUgDh2iTYxNU/bWo6WxVybc9+iK0W6k6bqqEvvv7tXEzLnCl9tg6366SZ i8cQ== X-Forwarded-Encrypted: i=1; AJvYcCWmlYEXELaDt/GkCCs16r7IHzhFl6BqsOF3S7asX0gBl/2B+btq9g2t+qbpN9I+cNuKaglmhfEa2/CzCwxcz1zOvEAu9CiYyQ== X-Gm-Message-State: AOJu0YxMkGAApvXQIXlRsGkpm8dE+XS3Qnsu8ZXuxmU+Z391K2CV7IxV tQkmVx6ZLwWPNZRvQbth16A+zqr0FSSDcZwsh4Gr+ckRmZWRFTggWLasWpcCV+4ZXnVglfrW21K 3IeZIVL+RJSYh0CditH4zdrfK3hnAZFqrEXQO8LS+MzjDZQU+/rJs X-Google-Smtp-Source: AGHT+IE0cHweUQICCPvx3RAm5EhrO3fncbGEQ2Jos4T2kLWw2P30OIIIGF7N7PmaDxQBz1ve73qMAGBRykVKakx0FWg= X-Received: by 2002:a17:90a:c001:b0:2ac:c68b:d11e with SMTP id p1-20020a17090ac00100b002acc68bd11emr11438004pjt.20.1713891905051; Tue, 23 Apr 2024 10:05:05 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Ian Lance Taylor Date: Tue, 23 Apr 2024 10:04:47 -0700 Message-ID: Subject: Re: [PATCH] libbacktrace: Avoid GNU ld --compress-debug-sections=zlib-gabi To: Jakub Jelinek Cc: Rainer Orth , gcc-patches@gcc.gnu.org Content-Type: multipart/mixed; boundary="0000000000003060700616c68e63" X-Spam-Status: No, score=-14.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000003060700616c68e63 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Apr 23, 2024 at 7:24=E2=80=AFAM Jakub Jelinek wr= ote: > > What we could do is drop the HAVE_COMPRESSED_DEBUG stuff altogether, and > instead similarly how we have HAVE_COMPRESSED_DEBUG_ZSTD have > HAVE_COMPRESSED_DEBUG_{ZLIB,ZLIB_GABI,ZLIB_GNU} and for each of those > if linker supports them test with that corresponding flag. I think that's right. Committed this patch after testing on x86_64-pc-linux-gnu. While I was at it I added an _alloc version of ctestzstd. Ian * configure.ac: Test --compress-debug-sections=3Dzlib-gnu and --compress-debug-sections=3Dzlib-gabi separately, setting new automake conditionals. * Makefile.am (ctestg, ctestg_alloc): Only build if HAVE_COMPRESSED_DEBUG_ZLIB_GNU. (ctesta, ctesta_alloc): Only build if HAVE_COMPRESSED_DEBUG_ZLIB_GABI. (ctestzstd_alloc): New test if HAVE_COMPRESSED_DEBUG_ZSTD. * configure, Makefile.in: Regenerate. --0000000000003060700616c68e63 Content-Type: text/plain; charset="US-ASCII"; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lvcmxbe70 Mzk0M2RlNjk4NjI3MTQ2NjY1MmNiNjE5ZGJjNjA4ODEwNjBiMTgwYwpkaWZmIC0tZ2l0IGEvbGli YmFja3RyYWNlL01ha2VmaWxlLmFtIGIvbGliYmFja3RyYWNlL01ha2VmaWxlLmFtCmluZGV4IDU2 NzdlY2Q4ODY1Li5iZWQ0MmMyOTMyOSAxMDA2NDQKLS0tIGEvbGliYmFja3RyYWNlL01ha2VmaWxl LmFtCisrKyBiL2xpYmJhY2t0cmFjZS9NYWtlZmlsZS5hbQpAQCAtNDkzLDE5ICs0OTMsMzcgQEAg ZW5kaWYgSEFWRV9PQkpDT1BZX0RFQlVHTElOSwogCSAgJDwKIAkkKE9CSkNPUFkpIC0tc3RyaXAt YWxsICQ8ICRACiAKLWlmIEhBVkVfQ09NUFJFU1NFRF9ERUJVRworaWYgSEFWRV9DT01QUkVTU0VE X0RFQlVHX1pMSUJfR05VCiAKIGN0ZXN0Z19TT1VSQ0VTID0gYnRlc3QuYyB0ZXN0bGliLmMKIGN0 ZXN0Z19DRkxBR1MgPSAkKGxpYmJhY2t0cmFjZV9URVNUX0NGTEFHUykKIGN0ZXN0Z19MREZMQUdT ID0gLVdsLC0tY29tcHJlc3MtZGVidWctc2VjdGlvbnM9emxpYi1nbnUgJChsaWJiYWNrdHJhY2Vf dGVzdGluZ19sZGZsYWdzKQogY3Rlc3RnX0xEQUREID0gbGliYmFja3RyYWNlLmxhCiAKK2N0ZXN0 Z19hbGxvY19TT1VSQ0VTID0gJChjdGVzdGdfU09VUkNFUykKK2N0ZXN0Z19hbGxvY19DRkxBR1Mg PSAkKGN0ZXN0Z19DRkxBR1MpCitjdGVzdGdfYWxsb2NfTERGTEFHUyA9ICQoY3Rlc3RnX0xERkxB R1MpICQobGliYmFja3RyYWNlX3Rlc3RpbmdfbGRmbGFncykKK2N0ZXN0Z19hbGxvY19MREFERCA9 IGxpYmJhY2t0cmFjZV9hbGxvYy5sYQorCitCVUlMRFRFU1RTICs9IGN0ZXN0ZyBjdGVzdGdfYWxs b2MKKworZW5kaWYKKworaWYgSEFWRV9DT01QUkVTU0VEX0RFQlVHX1pMSUJfR0FCSQorCiBjdGVz dGFfU09VUkNFUyA9IGJ0ZXN0LmMgdGVzdGxpYi5jCiBjdGVzdGFfQ0ZMQUdTID0gJChsaWJiYWNr dHJhY2VfVEVTVF9DRkxBR1MpCiBjdGVzdGFfTERGTEFHUyA9IC1XbCwtLWNvbXByZXNzLWRlYnVn LXNlY3Rpb25zPXpsaWItZ2FiaSAkKGxpYmJhY2t0cmFjZV90ZXN0aW5nX2xkZmxhZ3MpCiBjdGVz dGFfTERBREQgPSBsaWJiYWNrdHJhY2UubGEKIAotQlVJTERURVNUUyArPSBjdGVzdGcgY3Rlc3Rh CitjdGVzdGFfYWxsb2NfU09VUkNFUyA9ICQoY3Rlc3RhX1NPVVJDRVMpCitjdGVzdGFfYWxsb2Nf Q0ZMQUdTID0gJChjdGVzdGFfQ0ZMQUdTKQorY3Rlc3RhX2FsbG9jX0xERkxBR1MgPSAkKGN0ZXN0 YV9MREZMQUdTKSAkKGxpYmJhY2t0cmFjZV90ZXN0aW5nX2xkZmxhZ3MpCitjdGVzdGFfYWxsb2Nf TERBREQgPSBsaWJiYWNrdHJhY2VfYWxsb2MubGEKKworQlVJTERURVNUUyArPSBjdGVzdGEgY3Rl c3RhX2FsbG9jCisKK2VuZGlmCiAKIGlmIEhBVkVfQ09NUFJFU1NFRF9ERUJVR19aU1RECiAKQEAg LTUxNCwyMSArNTMyLDEyIEBAIGN0ZXN0enN0ZF9DRkxBR1MgPSAkKGxpYmJhY2t0cmFjZV9URVNU X0NGTEFHUykKIGN0ZXN0enN0ZF9MREZMQUdTID0gLVdsLC0tY29tcHJlc3MtZGVidWctc2VjdGlv bnM9enN0ZCAkKGxpYmJhY2t0cmFjZV90ZXN0aW5nX2xkZmxhZ3MpCiBjdGVzdHpzdGRfTERBREQg PSBsaWJiYWNrdHJhY2UubGEKIAotQlVJTERURVNUUyArPSBjdGVzdHpzdGQKLQotZW5kaWYKLQot Y3Rlc3RnX2FsbG9jX1NPVVJDRVMgPSAkKGN0ZXN0Z19TT1VSQ0VTKQotY3Rlc3RnX2FsbG9jX0NG TEFHUyA9ICQoY3Rlc3RnX0NGTEFHUykKLWN0ZXN0Z19hbGxvY19MREZMQUdTID0gJChjdGVzdGdf TERGTEFHUykgJChsaWJiYWNrdHJhY2VfdGVzdGluZ19sZGZsYWdzKQotY3Rlc3RnX2FsbG9jX0xE QUREID0gbGliYmFja3RyYWNlX2FsbG9jLmxhCi0KLWN0ZXN0YV9hbGxvY19TT1VSQ0VTID0gJChj dGVzdGFfU09VUkNFUykKLWN0ZXN0YV9hbGxvY19DRkxBR1MgPSAkKGN0ZXN0YV9DRkxBR1MpCi1j dGVzdGFfYWxsb2NfTERGTEFHUyA9ICQoY3Rlc3RhX0xERkxBR1MpICQobGliYmFja3RyYWNlX3Rl c3RpbmdfbGRmbGFncykKLWN0ZXN0YV9hbGxvY19MREFERCA9IGxpYmJhY2t0cmFjZV9hbGxvYy5s YQorY3Rlc3R6c3RkX2FsbG9jX1NPVVJDRVMgPSAkKGN0ZXN0enN0ZF9TT1VSQ0VTKQorY3Rlc3R6 c3RkX2FsbG9jX0NGTEFHUyA9ICQoY3Rlc3R6c3RkX0NGTEFHUykKK2N0ZXN0enN0ZF9hbGxvY19M REZMQUdTID0gJChjdGVzdHpzdGRfTERGTEFHUykgJChsaWJiYWNrdHJhY2VfdGVzdGluZ19sZGZs YWdzKQorY3Rlc3R6c3RkX2FsbG9jX0xEQUREID0gbGliYmFja3RyYWNlX2FsbG9jLmxhCiAKLUJV SUxEVEVTVFMgKz0gY3Rlc3RnX2FsbG9jIGN0ZXN0YV9hbGxvYworQlVJTERURVNUUyArPSBjdGVz dHpzdGQgY3Rlc3R6c3RkX2FsbG9jCiAKIGVuZGlmCiAKZGlmZiAtLWdpdCBhL2xpYmJhY2t0cmFj ZS9jb25maWd1cmUuYWMgYi9saWJiYWNrdHJhY2UvY29uZmlndXJlLmFjCmluZGV4IDBmNjFmMmIy OGFiLi4zZTAwNzVhMmI3OSAxMDA2NDQKLS0tIGEvbGliYmFja3RyYWNlL2NvbmZpZ3VyZS5hYwor KysgYi9saWJiYWNrdHJhY2UvY29uZmlndXJlLmFjCkBAIC01MDIsMTYgKzUwMiwyNyBAQCBBQ19M SU5LX0lGRUxTRShbQUNfTEFOR19QUk9HUkFNKCwpXSwKIExERkxBR1M9JExERkxBR1NfaG9sZF0p CiBBTV9DT05ESVRJT05BTChIQVZFX0JVSUxESUQsIHRlc3QgIiRsaWJiYWNrdHJhY2VfY3ZfbGRf YnVpbGRpZCIgPSB5ZXMpCiAKLWRubCBUZXN0IHdoZXRoZXIgdGhlIGxpbmtlciBzdXBwb3J0cyB0 aGUgLS1jb21wcmVzcy1kZWJ1Zy1zZWN0aW9ucyBvcHRpb24uCi1BQ19DQUNIRV9DSEVDSyhbd2hl dGhlciAtLWNvbXByZXNzLWRlYnVnLXNlY3Rpb25zIGlzIHN1cHBvcnRlZF0sCi1bbGliZ29fY3Zf bGRfY29tcHJlc3NdLAorZG5sIFRlc3Qgd2hldGhlciB0aGUgbGlua2VyIHN1cHBvcnRzIHRoZSAt LWNvbXByZXNzLWRlYnVnLXNlY3Rpb25zPXpsaWItZ251Citkbmwgb3B0aW9uLgorQUNfQ0FDSEVf Q0hFQ0soW3doZXRoZXIgLS1jb21wcmVzcy1kZWJ1Zy1zZWN0aW9ucz16bGliLWdudSBpcyBzdXBw b3J0ZWRdLAorW2xpYmdvX2N2X2xkX2NvbXByZXNzX3psaWJfZ251XSwKIFtMREZMQUdTX2hvbGQ9 JExERkxBR1MKIExERkxBR1M9IiRMREZMQUdTIC1XbCwtLWNvbXByZXNzLWRlYnVnLXNlY3Rpb25z PXpsaWItZ251IgogQUNfTElOS19JRkVMU0UoW0FDX0xBTkdfUFJPR1JBTSgsKV0sCi1bbGliZ29f Y3ZfbGRfY29tcHJlc3M9eWVzXSwKLVtsaWJnb19jdl9sZF9jb21wcmVzcz1ub10pCitbbGliZ29f Y3ZfbGRfY29tcHJlc3NfemxpYl9nbnU9eWVzXSwKK1tsaWJnb19jdl9sZF9jb21wcmVzc196bGli X2dudT1ub10pCiBMREZMQUdTPSRMREZMQUdTX2hvbGRdKQotQU1fQ09ORElUSU9OQUwoSEFWRV9D T01QUkVTU0VEX0RFQlVHLCB0ZXN0ICIkbGliZ29fY3ZfbGRfY29tcHJlc3MiID0geWVzKQorQU1f Q09ORElUSU9OQUwoSEFWRV9DT01QUkVTU0VEX0RFQlVHX1pMSUJfR05VLCB0ZXN0ICIkbGliZ29f Y3ZfbGRfY29tcHJlc3NfemxpYl9nbnUiID0geWVzKQorCitBQ19DQUNIRV9DSEVDSyhbd2hldGhl ciAtLWNvbXByZXNzLWRlYnVnLXNlY3Rpb25zPXpsaWItZ2FiaSBpcyBzdXBwb3J0ZWRdLAorW2xp YmdvX2N2X2xkX2NvbXByZXNzX3psaWJfZ2FiaV0sCitbTERGTEFHU19ob2xkPSRMREZMQUdTCitM REZMQUdTPSIkTERGTEFHUyAtV2wsLS1jb21wcmVzcy1kZWJ1Zy1zZWN0aW9ucz16bGliLWdhYmki CitBQ19MSU5LX0lGRUxTRShbQUNfTEFOR19QUk9HUkFNKCwpXSwKK1tsaWJnb19jdl9sZF9jb21w cmVzc196bGliX2dhYmk9eWVzXSwKK1tsaWJnb19jdl9sZF9jb21wcmVzc196bGliX2dhYmk9bm9d KQorTERGTEFHUz0kTERGTEFHU19ob2xkXSkKK0FNX0NPTkRJVElPTkFMKEhBVkVfQ09NUFJFU1NF RF9ERUJVR19aTElCX0dBQkksIHRlc3QgIiRsaWJnb19jdl9sZF9jb21wcmVzc196bGliX2dhYmki ID0geWVzKQogCiBBQ19DSEVDS19MSUIoW3pzdGRdLCBbWlNURF9jb21wcmVzc10sCiAgICAgW0FD X0RFRklORShIQVZFX1pTVEQsIDEsIFtEZWZpbmUgaWYgLWx6c3RkIGlzIGF2YWlsYWJsZS5dKV0p Cg== --0000000000003060700616c68e63--