From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59010 invoked by alias); 8 Apr 2015 14:08:09 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 58923 invoked by uid 89); 8 Apr 2015 14:08:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_50,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-wi0-f171.google.com Received: from mail-wi0-f171.google.com (HELO mail-wi0-f171.google.com) (209.85.212.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 08 Apr 2015 14:08:07 +0000 Received: by widjs5 with SMTP id js5so33941937wid.1 for ; Wed, 08 Apr 2015 07:08:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=/Bl1DbjXNM58I9O3sQtS8z2lQPJN80s26xmHOSKvxxs=; b=Li7vWipElIknIfKU4XMyb643O3kJJLNO8ub3nwrPMH5sTDJTPU8tUjHZaH1d46mmf2 hdSpErIHg2E2WHzARvdsJn10DkhMMZ9BfS7/a91ouWMMV9WPzaLeOhG1Lohs8tVJS8ru 1Ig+oTyh0vqX68lQqkVSiTboiquXoEOW9TUySi2LzrqUg1SMgQk/tpff7uOEOzvXcF5s e0zotSmYuN6lAlwTZchvzfSIoHN1e/E8ubMaGw0ogF7/TcTZ0ErEzCQNmdNP8SQHOBNT 17zigN40s1H2/IRaaW8H6RL0h9gZpJHCzBLqRqWFnRBwrhTgWOTfnEx5qANj1RtBjk3Z 1QUw== X-Gm-Message-State: ALoCoQmjYSD5axEsqyOy9r5C9iYisYbeam58VYZsHwpr2EacKj6ipqzHI+Gsm7BrJ2r+8Xff47OU MIME-Version: 1.0 X-Received: by 10.194.6.228 with SMTP id e4mr50032925wja.63.1428502084645; Wed, 08 Apr 2015 07:08:04 -0700 (PDT) Received: by 10.180.84.38 with HTTP; Wed, 8 Apr 2015 07:08:04 -0700 (PDT) In-Reply-To: References: Date: Wed, 08 Apr 2015 14:08:00 -0000 Message-ID: Subject: Re: [libgo] Remove Solaris 11.1+ zone_net_addr_t treatment From: Ian Lance Taylor To: Rainer Orth Cc: gcc-patches , "gofrontend-dev@googlegroups.com" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00316.txt.bz2 On Wed, Apr 8, 2015 at 6:48 AM, Rainer Orth wrote: > Ian Lance Taylor writes: > >> On Mon, Nov 3, 2014 at 8:59 AM, Rainer Orth wrote: >>> >>> The recent godump changes broke Solaris 11.1+ bootstrap in libgo: >>> before, gen-sysinfo.so had >>> >>> type _zone_net_addr_t struct { zna_family uint16; zna_plen uint16; >>> zna_addru struct { znau_addr6 _in6_addr; }; } >>> >>> which was filtered out by mksysinfo.sh due to the use of _in6_addr. >>> >>> After the change, there's now >>> >>> type _zone_net_addr_t struct { zna_family uint16; zna_plen uint16; >>> zna_addru struct { znau_addr6 [16]byte; Godump_0_align [0]uint32; }; } >>> >>> instead, not filtered, but added a second time by the _zone_net_addr_t >>> code in mksysinfo.sh, which leads to redefinition warnings/errors. >>> >>> Simply removing the old _zone_net_addr_t fragment fixes this and >>> restores bootstrap. >>> >>> Bootstrapped without regressions on i386-pc-solaris2.1[01], ok for >>> mainline? >> >> >> I just got back to this. Committed to mainline. Thanks. > > Sorry for the late reply, but between the time I submitted the patch and > you committing it, something changed and the mksysinfo.sh fragment > became necessary again. In fact, without it Solaris 11 bootstrap is > broken. To avoid any confusion, can you send me the patch I should apply to mainline? Ian