From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 121820 invoked by alias); 16 Jan 2019 01:06:27 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 121802 invoked by uid 89); 16 Jan 2019 01:06:26 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.4 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.2 spammy=alt, Hx-languages-length:1803, HX-Google-Smtp-Source:ALg8bN7 X-HELO: mail-yb1-f194.google.com Received: from mail-yb1-f194.google.com (HELO mail-yb1-f194.google.com) (209.85.219.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 Jan 2019 01:06:24 +0000 Received: by mail-yb1-f194.google.com with SMTP id s17so1857168ybp.6 for ; Tue, 15 Jan 2019 17:06:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=golang-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Vme/e5IAxcFvab2Cq+W2coxwSII4zpB/4v9svRoQbLs=; b=UPiLMx8i0sUIKhbfKjZkC19zj/357eaJgh9wiDo+1rkK27GpFAQmuebuiaiTS3xKLm fzgSmvn3XOU51JKXhz4ZZNrGd33kmb32AfOBrA69BOsyLzXXuQ1yq0F5HeOSWYNLXj1L Zh4JiJfZ3dMYNcG8Q4YUkOJ4EiyC1IQI3yWRLWZOfSrfpEwExKmY0GYXex82NoGQ2zWJ nqI7ZSFu7wKW/ZEcVIe4QATP1FMN+mZaqw7iy1RIisC4FV0KBCQdQicuLPvuDaYG08Xl umU8mXS8nRddmP5TSaNsuOnSYb0DoTJ1UgtdYi1bJjFhNz6tA9+VzaJn6EdSS5Tqy+lU HM0A== MIME-Version: 1.0 References: <20181211101411.7067-1-tdevries@suse.de> <20181211101411.7067-4-tdevries@suse.de> In-Reply-To: <20181211101411.7067-4-tdevries@suse.de> From: Ian Lance Taylor Date: Wed, 16 Jan 2019 01:06:00 -0000 Message-ID: Subject: Re: [PATCH 3/9] [libbacktrace] Handle alt FORMS without .gnu_debugaltlink To: Tom de Vries Cc: gcc-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg00883.txt.bz2 On Tue, Dec 11, 2018 at 2:14 AM Tom de Vries wrote: > > Handle DW_FORM_GNU_strp_alt and DW_FORM_GNU_ref_alt references robustly in > presence of missing .gnu_debugaltlink file. > > 2018-11-11 Tom de Vries > > * dwarf.c (enum attr_val_encoding): Add ATTR_VAL_NONE. > (read_attribute): Add altlink parameter. Handle missing altlink for > DW_FORM_GNU_strp_alt and DW_FORM_GNU_ref_alt. > (find_address_ranges, build_address_map, build_dwarf_data): Add and > handle altlink parameter. > (read_referenced_name, read_function_entry): Add argument to > read_attribute call. > read_attribute (enum dwarf_form form, struct dwarf_buf *buf, > int is_dwarf64, int version, int addrsize, > const unsigned char *dwarf_str, size_t dwarf_str_size, > - struct attr_val *val) > + struct attr_val *val, struct dwarf_data *altlink) > { altlink is not a result parameter, so it should be before val. > @@ -1277,7 +1289,8 @@ find_address_ranges (struct backtrace_state *state, uintptr_t base_address, > size_t dwarf_ranges_size, > int is_bigendian, backtrace_error_callback error_callback, > void *data, struct unit *u, > - struct unit_addrs_vector *addrs) > + struct unit_addrs_vector *addrs, > + struct dwarf_data *altlink) Same. altlink should be before the error_callback parameter. > @@ -1431,7 +1444,8 @@ build_address_map (struct backtrace_state *state, uintptr_t base_address, > const unsigned char *dwarf_ranges, size_t dwarf_ranges_size, > const unsigned char *dwarf_str, size_t dwarf_str_size, > int is_bigendian, backtrace_error_callback error_callback, > - void *data, struct unit_addrs_vector *addrs) > + void *data, struct unit_addrs_vector *addrs, > + struct dwarf_data *altlink) Same. Ian