From: Ian Lance Taylor <iant@golang.org>
To: "Martin Liška" <mliska@suse.cz>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Handle jobserver file descriptors in btest.
Date: Fri, 22 Oct 2021 10:32:36 -0700 [thread overview]
Message-ID: <CAKOQZ8wUQb4o4sWs0Y+VucnS-o2q+R+gw6D1rLRqvKZ4ivGOnA@mail.gmail.com> (raw)
In-Reply-To: <6a4d6886-87a2-d6fe-578e-c7a0dc0bbcc1@suse.cz>
On Fri, Oct 22, 2021 at 1:15 AM Martin Liška <mliska@suse.cz> wrote:
>
> On 10/21/21 20:15, Ian Lance Taylor wrote:
> > On Thu, Oct 21, 2021 at 12:48 AM Martin Liška <mliska@suse.cz> wrote:
> >>
> >> The patch is about sensitive handling of file descriptors opened
> >> by make's jobserver.
> >
> > Thanks. I think a better approach would be, at the start of main,
> > fstat the descriptors up to 10 and record the ones for which fstat
> > succeeds. Then at the end of main only check the descriptors for
> > which fstat failed earlier.
>
> Sure, makes sense.
>
> >
> > I can work on that at some point if you don't want to tackle it.
>
> I've just done that in the attached patch.
>
> Is it fine?
This is OK.
Thanks.
Ian
prev parent reply other threads:[~2021-10-22 17:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 7:47 Martin Liška
2021-10-21 18:15 ` Ian Lance Taylor
2021-10-22 8:15 ` Martin Liška
2021-10-22 17:32 ` Ian Lance Taylor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKOQZ8wUQb4o4sWs0Y+VucnS-o2q+R+gw6D1rLRqvKZ4ivGOnA@mail.gmail.com \
--to=iant@golang.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=mliska@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).