From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <iant@google.com>
Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com
 [IPv6:2a00:1450:4864:20::129])
 by sourceware.org (Postfix) with ESMTPS id 05EAC3858416
 for <gcc-patches@gcc.gnu.org>; Fri, 22 Oct 2021 17:32:51 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 05EAC3858416
Received: by mail-lf1-x129.google.com with SMTP id i6so2119073lfv.9
 for <gcc-patches@gcc.gnu.org>; Fri, 22 Oct 2021 10:32:50 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc:content-transfer-encoding;
 bh=K6bWrga5tv8VC3HqEkoMAlKz2hRQqrCv2qbnLH4afzE=;
 b=pKR3rNWzPNStN6R5vZlzeTQz7kSmzJ2uU6QKInEGOwRYYjMjQJc2H7JN3uOMXqGQg1
 9budmdYfFhdvKbqp1wVWaUE2iNcHV35HLdPh62OOdCDXv2pQVo8+LYKLqPozE45ohGvT
 1V12FMLL4zQK7K3FlhBiXUMBsMvMSgNxa8CV3DrWuybzAfjZ7aa7QdPNsn5GrbYl8VDk
 w4DgCE03aZga9z2490znWy7ozVNoMF7G/A56Myv1GRksxWPj8X1/OqpoVvckC6d0X3VS
 zCBLQyTpw/jjEiiyiW4nhBccf+D6Q6FsY/frIzsfcOsdQ6nRW1ckyn9o1DSNm7wO27jV
 3abQ==
X-Gm-Message-State: AOAM532Kf3YsN5YbzZ9HniBUPu1vkpGbeXX7vjuvanoh2PuzROFEfGh7
 Drag9NH6iNJQ5LlEQu1gKyxJP1E0x9JYxXvk0fovCQ==
X-Google-Smtp-Source: ABdhPJzFkOKo4Jbep7ImulQ3nplraS39ONIY/Jtb1nWal0fJUmLTQFrH4ZhzIu1CAc/DMUJVaIMHaTZsqW2Jj+iELdU=
X-Received: by 2002:a05:6512:3503:: with SMTP id h3mr932951lfs.1.1634923969342; 
 Fri, 22 Oct 2021 10:32:49 -0700 (PDT)
MIME-Version: 1.0
References: <88d036b7-5304-3673-318f-2ebc159c8b16@suse.cz>
 <CAKOQZ8wWKZVbtdO51n1HGpxNkkK9XHOYMWz9fV-EsTX0SSanRw@mail.gmail.com>
 <6a4d6886-87a2-d6fe-578e-c7a0dc0bbcc1@suse.cz>
In-Reply-To: <6a4d6886-87a2-d6fe-578e-c7a0dc0bbcc1@suse.cz>
From: Ian Lance Taylor <iant@golang.org>
Date: Fri, 22 Oct 2021 10:32:36 -0700
Message-ID: <CAKOQZ8wUQb4o4sWs0Y+VucnS-o2q+R+gw6D1rLRqvKZ4ivGOnA@mail.gmail.com>
Subject: Re: [PATCH] Handle jobserver file descriptors in btest.
To: =?UTF-8?Q?Martin_Li=C5=A1ka?= <mliska@suse.cz>
Cc: gcc-patches@gcc.gnu.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,
 SPF_PASS, TXREP,
 USER_IN_DEF_SPF_WL autolearn=no autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Oct 2021 17:32:52 -0000

On Fri, Oct 22, 2021 at 1:15 AM Martin Li=C5=A1ka <mliska@suse.cz> wrote:
>
> On 10/21/21 20:15, Ian Lance Taylor wrote:
> > On Thu, Oct 21, 2021 at 12:48 AM Martin Li=C5=A1ka <mliska@suse.cz> wro=
te:
> >>
> >> The patch is about sensitive handling of file descriptors opened
> >> by make's jobserver.
> >
> > Thanks.  I think a better approach would be, at the start of main,
> > fstat the descriptors up to 10 and record the ones for which fstat
> > succeeds.  Then at the end of main only check the descriptors for
> > which fstat failed earlier.
>
> Sure, makes sense.
>
> >
> > I can work on that at some point if you don't want to tackle it.
>
> I've just done that in the attached patch.
>
> Is it fine?

This is OK.

Thanks.

Ian