libgo patch committed: redirect mkrsysinfo.sh grep output to /dev/null

libgo patch committed: redirect mkrsysinfo.sh grep output to /dev/null

[Ian Lance Taylor]

[-- Attachment #1: Type: text/plain, Size: 273 bytes --]

This patch to libgo redirects the output of a grep command in
mkrsysinfo.sh to /dev/null.  The output otherwise appears in the
middle of a build log, where it is harmless but confusing.
Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu.  Committed
to mainline.

Ian

[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 919 bytes --]

Index: gcc/go/gofrontend/MERGE
===================================================================
--- gcc/go/gofrontend/MERGE	(revision 241432)
+++ gcc/go/gofrontend/MERGE	(working copy)
@@ -1,4 +1,4 @@
-6d9929a1641b180e724c2fdcdd55f6a254f1dec0
+7fb11c908ddab4932cc416f16657cec3bc878a1a
 
 The first line of this file holds the git revision number of the last
 merge done from the gofrontend repository.
Index: libgo/mkrsysinfo.sh
===================================================================
--- libgo/mkrsysinfo.sh	(revision 241347)
+++ libgo/mkrsysinfo.sh	(working copy)
@@ -78,7 +78,7 @@ if grep '^const _epoll_data_offset ' ${O
   fi
 fi
 # Make sure EPOLLET is positive.
-if grep '^const _EPOLLET = [0-9]' gen-sysinfo.go; then
+if grep '^const _EPOLLET = [0-9]' gen-sysinfo.go > /dev/null 2>&1; then
   echo "const _EPOLLETpos = _EPOLLET" >> ${OUT}
 else
   echo "const _EPOLLETpos = 0x80000000" >> ${OUT}

Re: libgo patch committed: redirect mkrsysinfo.sh grep output to /dev/null

[Bernhard Reutner-Fischer]

On Fri, 28 Oct 2016 10:55:18 -0700
Ian Lance Taylor <iant@golang.org> wrote:

> This patch to libgo redirects the output of a grep command in
> mkrsysinfo.sh to /dev/null.  The output otherwise appears in the

grep -q exists since at least SUSv2, fwiw.
thanks,

> middle of a build log, where it is harmless but confusing.
> Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu.  Committed
> to mainline.
> 
> Ian

Re: libgo patch committed: redirect mkrsysinfo.sh grep output to /dev/null

[Ian Lance Taylor]

On Fri, Nov 19, 2021 at 3:47 AM Bernhard Reutner-Fischer via
Gcc-patches <gcc-patches@gcc.gnu.org> wrote:
>
> On Fri, 28 Oct 2016 10:55:18 -0700
> Ian Lance Taylor <iant@golang.org> wrote:
>
> > This patch to libgo redirects the output of a grep command in
> > mkrsysinfo.sh to /dev/null.  The output otherwise appears in the
>
> grep -q exists since at least SUSv2, fwiw.

There has traditionally been confusion between grep -q and grep -s.
Older grep programs supported -s but not -q.  Perhaps that confusion
is all cleared up now on all systems that GCC supports.  I don't know.
I do know that the patch I applied five years ago works everywhere.

Ian