From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by sourceware.org (Postfix) with ESMTPS id EB29B3858D37 for ; Thu, 30 Nov 2023 19:44:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EB29B3858D37 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=golang.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=google.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EB29B3858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1030 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701373442; cv=none; b=dz4j4Amd6310mTucaQZn/12DQa6rQD7TC8DlVEI39Bdicauc7PjX6Q2gpzVJaLaHkFmQUfYhQ4Mnh5SEp9pVXZK7AYNZb3orNh48RooxdlzSR5vtglqDJ4wpKoEof/SRmJNtcWvJhgqGPbcRkYSvp2ie5iO5YbsxK9eso2MyS+o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701373442; c=relaxed/simple; bh=0cCNH8x7Ix/ri8AliEOLey5KFChsK1w5mFN4bZTcdM8=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=tR8g2ZPDjFt/rK06ec+k8x7rsXAltmMN6xsLZNk5+V6Z7620ZrHGNEaET0+0cOQGO81DQfmAse21Gf4cy2Z8z84iimqNScNEKtF3UQe89+hl7YHvdoinOCUZas7OyHIURElShHTzRZDcR4U1kBPEFO5ASPayiAQiTHQghXph3hg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x1030.google.com with SMTP id 98e67ed59e1d1-2859bde1d62so1375105a91.2 for ; Thu, 30 Nov 2023 11:44:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google-com.20230601.gappssmtp.com; s=20230601; t=1701373440; x=1701978240; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=TWbQ9IJJJsZfm7U6twY+PX/p7stEN7cVsawiOWaJdaA=; b=KNVDvfwZ9ZXlMumMKLBHkwTZzc1yRSFpt0ra5usEhNBtRpkiIggQACInP43bw0l4nW hZrgVFIHJZN9A9e2eUzXW/KZhk1xc133f6+BlnebQEKiN6v195U5EOezoDAXKIfFNs/i 20IQkl2Y+/BL/E8Po0dUAJI8YGp+rDlDSaGACmn7eewO6ZAU65MBGf072C8V4cagvCdE p8l62XccI0Y2XWzExUgtJOYeggoTi34JJg8/U3esYQbJu1x3RHhzJy7yEBD7+3e3CI84 1QF4FiUOgplqKG79uWU6RBs1xCyRcAj6KIHbhIhkRdx/v4a/7tYX96bEfZ/Sap5r7Br8 IT8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701373440; x=1701978240; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TWbQ9IJJJsZfm7U6twY+PX/p7stEN7cVsawiOWaJdaA=; b=MLtvSW871bwnuPcEBHPFPFKj2YieVqwZ+6cRxen8ByX1JWg2RGkLlkTn6mq62Bh0bo u7yFdqYqMUMrd/OLaRSi9QD746qCkAVikpVA0PmdyapNUWyOmjFuArC5wPMvgDzgGVBS YsGcgvbMRvrqD10UpmUkbk+9jmxKXiuAgxVkUj1XQfTBI1k2/W5oEeUandWrGNwzP30K 7jnRdIOnCL5EbQ7YtYxQiLSslN/02Ebmgs8gb1T2xdoy+Z/uXnisEi6Znl3lEgHY9fwi HrU8qXWvYW4K0fcCoXxioMot3l4gZxq//Ayh1QXX9+bNAx0zVd0vJOivfavpmMCcit2G eNHw== X-Gm-Message-State: AOJu0YzUAqX5shmhazxir8OfP/YeQ3ImNiu0mMg+qb6punTC+o3JjNwy N+VRk1N3eJHfD9f2uKetPG8VMg3FGr8UyfOSUSX+2A== X-Google-Smtp-Source: AGHT+IFu4qD64M5vjPI/9eoAL0GLr/x1F0430t+YmwM62D/+f2zD/GTHCYyICer6KybLwg8K7jZTzwdf0KIpAVJmWxs= X-Received: by 2002:a17:90a:e7c8:b0:285:b6cb:6ab1 with SMTP id kb8-20020a17090ae7c800b00285b6cb6ab1mr17654095pjb.28.1701373439691; Thu, 30 Nov 2023 11:43:59 -0800 (PST) MIME-Version: 1.0 References: <92993a50-9667-45da-a62-5089e7e052f8@codesourcery.com> <14111ba7-615b-b2e9-6fba-e7bee3728182@codesourcery.com> <9B1D2B19-B4EB-48B0-91EE-9AC33B392875@gmail.com> <2abef445-3ba3-7b8a-29e7-ba736592e325@codesourcery.com> <3CB9E78B-65BF-4706-B13B-01422C42830B@gmail.com> <11A36820-BC70-4A8C-8EAE-85E5CA6FD9F6@gmail.com> In-Reply-To: <11A36820-BC70-4A8C-8EAE-85E5CA6FD9F6@gmail.com> From: Ian Lance Taylor Date: Thu, 30 Nov 2023 11:43:47 -0800 Message-ID: Subject: Re: Darwin: Replace environment runpath with embedded [PR88590] To: FX Coudert Cc: GCC Patches , Iain Sandoe Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-16.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, Oct 22, 2023 at 2:18=E2=80=AFPM FX Coudert wr= ote: > > Thanks a lot Alexandre for the review! This patch changed the files lingo/configure.ac and libgo/configure. Those files live in an upstream repository and should be changed there and then merged into the GCC repo, as described in libgo/README.gcc. This is not a big deal, and I can take care of changing the upstream repository. But I don't understand the changes in libgo. As far as I can tell, all they do is add an automake conditional that is never used. Is there any reason for that? Should I just revert the changes to libgo? To be clear, I am asking about this change in git revision 6a6d3817afa02bbcd2388c8e005da6faf88932f1 and the corresponding change in the generated file libgo/configure.ac. Thanks. diff --git a/libgo/configure.ac b/libgo/configure.ac index 54c35c0903c..e8d66f8415d 100644 --- a/libgo/configure.ac +++ b/libgo/configure.ac @@ -53,6 +53,7 @@ AC_LIBTOOL_DLOPEN AM_PROG_LIBTOOL AC_SUBST(enable_shared) AC_SUBST(enable_static) +AM_CONDITIONAL([ENABLE_DARWIN_AT_RPATH], [test x$enable_darwin_at_rpath =3D xyes]) CC_FOR_BUILD=3D${CC_FOR_BUILD:-gcc} AC_SUBST(CC_FOR_BUILD)