From: Ian Lance Taylor <iant@google.com>
To: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: Patch RFA: With -fnon-call-exceptions sync builtins may throw
Date: Mon, 04 Nov 2013 22:25:00 -0000 [thread overview]
Message-ID: <CAKOQZ8wtLP1HgB4nf99z64=CLKvAdqTYkTwZVYahqsUrNgGGaQ@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1311042221170.4111@laptop-mg.saclay.inria.fr>
[-- Attachment #1: Type: text/plain, Size: 1496 bytes --]
On Mon, Nov 4, 2013 at 1:24 PM, Marc Glisse <marc.glisse@inria.fr> wrote:
> On Mon, 4 Nov 2013, Ian Lance Taylor wrote:
>
>> 2013-11-04 Ian Lance Taylor <iant@google.com>
>>
>> * builtins.def (ATTR_NOTHROWCALL_LEAF_LIST): Define.
>> * sync-builtins.def: Use ATTR_NOTHROWCALL_LEAF_LIST for all sync
>> builtins that take pointers.
>> * lto-opts.c (lto_write_options): Write -fnon-call-exceptions
>> if set.
>> * lto-wrapper.c (merge_and_complain): Collect
>> OPT_fnon_call_exceptions.
>> (run_gcc): Pass -fnon-call-exceptions.
>
>
> Hello,
>
> I am seeing a bootstrap failure that seems related:
>
> /data/repos/gcc/pristine/gcc/builtins.def:220:2: error: 'ATTR_LEAF_LIST' was
> not declared in this scope
> ATTR_LEAF_LIST : ATTR_NOTHROW_LEAF_LIST)
> ^
> /data/repos/gcc/pristine/gcc/fortran/f95-lang.c:1034:4: note: in definition
> of macro 'DEF_SYNC_BUILTIN'
> attr);
> ^
> /data/repos/gcc/pristine/gcc/fortran/../sync-builtins.def:32:21: note: in
> expansion of macro 'ATTR_NOTHROWCALL_LEAF_LIST'
> BT_FN_VOID_VAR, ATTR_NOTHROWCALL_LEAF_LIST)
> ^
> make[3]: *** [fortran/f95-lang.o] Error 1
My apologies for the breakage. I tested Ada, but I somehow failed to
test Fortran.
Fixed with this patch. Bootstrapped and ran Fortran testsuite on
x86_64-unknown-linux-gnu. Committed to mainline.
Ian
2013-11-04 Ian Lance Taylor <iant@google.com>
* f95-lang.c (ATTR_LEAF_LIST): Define.
[-- Attachment #2: foo.patch --]
[-- Type: text/x-patch, Size: 590 bytes --]
Index: fortran/f95-lang.c
===================================================================
--- fortran/f95-lang.c (revision 204367)
+++ fortran/f95-lang.c (working copy)
@@ -531,8 +531,9 @@
return decl;
}
-/* So far we need just these 6 attribute types. */
+/* So far we need just these 7 attribute types. */
#define ATTR_NULL 0
+#define ATTR_LEAF_LIST (ECF_LEAF)
#define ATTR_NOTHROW_LEAF_LIST (ECF_NOTHROW | ECF_LEAF)
#define ATTR_NOTHROW_LEAF_MALLOC_LIST (ECF_NOTHROW | ECF_LEAF | ECF_MALLOC)
#define ATTR_CONST_NOTHROW_LEAF_LIST (ECF_NOTHROW | ECF_LEAF | ECF_CONST)
next prev parent reply other threads:[~2013-11-04 22:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-04 6:01 Ian Lance Taylor
2013-11-04 11:58 ` Richard Biener
2013-11-04 16:45 ` Ian Lance Taylor
2013-11-04 18:13 ` Richard Biener
2013-11-04 21:28 ` Marc Glisse
2013-11-04 22:25 ` Ian Lance Taylor [this message]
2013-11-05 10:06 ` Andreas Schwab
2013-11-04 21:44 Dominique Dhumieres
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKOQZ8wtLP1HgB4nf99z64=CLKvAdqTYkTwZVYahqsUrNgGGaQ@mail.gmail.com' \
--to=iant@google.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).