From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9652 invoked by alias); 4 Oct 2014 01:26:01 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 9638 invoked by uid 89); 4 Oct 2014 01:25:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-ob0-f172.google.com Received: from mail-ob0-f172.google.com (HELO mail-ob0-f172.google.com) (209.85.214.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 04 Oct 2014 01:25:57 +0000 Received: by mail-ob0-f172.google.com with SMTP id wo20so1758727obc.3 for ; Fri, 03 Oct 2014 18:25:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=G5K/Ce6M+ZpICrHFDzhZ8xbTTFGvL18KevJnNqlRaPE=; b=HlMqDLc/nPLPjoSKLIjdFmO3Y/JrMsogSbCOegpJGVBy8BkRozEixXYmjzPOv/0tSP TNvRCUTbK5uZkuBth2g294vU4D9y6hwUYpvxhkDy3ShbZQQRZW7+ofMutyp8zmt0Zoel FD6ZrbPSv1B9ewBOtC7rte75tNsQAuclHwwhVNh1u9T35bVB+tKl529Hqoup15yPHiV2 PyIIhDtOx2/romAqTeOcBJdPTKKORUFmfUc0vKV9EyVLSx7X2VGLJ0RFNT7EulYZKiZm zragNP98Th+Sf6q+0f4nYBSwf0NjJWV5pO067RozMHFmIix8QCTZZRhlOYrx6tovPdBJ k1Nw== X-Gm-Message-State: ALoCoQnWmsLwMg5W1HVaxZIefmlhZnOTaYsd4vNVMyBw0zdILxy2RFSLtxg4EcyqXJE3vKK/4Nqb MIME-Version: 1.0 X-Received: by 10.182.79.37 with SMTP id g5mr11020022obx.41.1412385955635; Fri, 03 Oct 2014 18:25:55 -0700 (PDT) Received: by 10.60.35.227 with HTTP; Fri, 3 Oct 2014 18:25:55 -0700 (PDT) In-Reply-To: <20140909125610.GF25290@linux.vnet.ibm.com> References: <20140909124446.GA25290@linux.vnet.ibm.com> <20140909125610.GF25290@linux.vnet.ibm.com> Date: Sat, 04 Oct 2014 01:26:00 -0000 Message-ID: Subject: Re: [gofrontend-dev] [PATCH 5/9] Gccgo port to s390[x] -- part I From: Ian Lance Taylor To: vogt@linux.vnet.ibm.com, gcc-patches , "gofrontend-dev@googlegroups.com" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00363.txt.bz2 On Tue, Sep 9, 2014 at 5:56 AM, Dominik Vogt wrote: > This optional cleanup patch fixes some sloppy programming in the > x86 libgo/go/debug/elf library that had given me a very hard time > to debug and fix when porting the code to s390[x]. See commit > comment for details. > > ChangeLog > 2014-09-05 Dominik Vogt > > * libgo/go/debug/elf/file.go (applyRelocationsAMD64): > Fix the calculation of some relocations; do not assume that the symbol > value is always zero. The code checks that it is using only STT_SECTION symbols. An STT_SECTION symbol in an object file can be reasonably expected to have a value of zero. Since in practice this only applies to debug sections, I doubt it would work at all if the STT_SECTION symbol had a non-zero value and that value were added in. So I'm not convinced that this patch is necessary. I'm sorry that the code gave you a hard time, but as far as I can see it's not sloppy and it's not wrong. Ian