public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Ian Lance Taylor <iant@golang.org>
To: Nikhil Benesch <nikhil.benesch@gmail.com>
Cc: Rainer Orth <ro@cebitec.uni-bielefeld.de>,
	gcc-patches <gcc-patches@gnu.org>
Subject: Re: [PATCH] Correct -fdump-go-spec's handling of incomplete types
Date: Sun, 13 Dec 2020 23:39:45 -0800	[thread overview]
Message-ID: <CAKOQZ8x5-Ay6tWJErH4dh3zrxAPYOeW81h_7OXfnuwRNJ2b2dw@mail.gmail.com> (raw)
In-Reply-To: <cf92a200-deb2-67b0-f71e-ae8eb96009a2@gmail.com>

On Sun, Dec 13, 2020 at 3:30 PM Nikhil Benesch <nikhil.benesch@gmail.com> wrote:
>
> On 12/13/20 4:55 PM, Nikhil Benesch wrote:
> > There are a few more hurdles before this patch is ready for commit. The
> > changes to godump.c deserve new test cases. [...]
>
> Updated patch attached, as promised, and is ready for review.
>
> gcc/:
>         * godump.c (go_output_typedef): Suppress typedefs whose name
>         matches the tag of the underlying struct, union, or enum.
>         Output declarations for enums that do not appear in typedefs.
> gcc/testsuite:
>         * gcc.misc-tests/godump-1.c: Add test cases.
>
> I don't have write access, so whoever reviews, please commit if approved.

Thanks.  Committed.

Ian

  reply	other threads:[~2020-12-14  7:40 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-08 22:57 Nikhil Benesch
2020-12-10  2:48 ` Ian Lance Taylor
2020-12-10 19:18   ` Rainer Orth
2020-12-10 19:31     ` Nikhil Benesch
2020-12-10 19:34       ` Rainer Orth
2020-12-10 19:49         ` Nikhil Benesch
2020-12-10 21:44           ` Rainer Orth
2020-12-13 21:55             ` Nikhil Benesch
2020-12-13 23:30               ` Nikhil Benesch
2020-12-14  7:39                 ` Ian Lance Taylor [this message]
2020-12-14  8:22                   ` Nikhil Benesch
2020-12-14 10:30               ` Rainer Orth
2020-12-15  3:14                 ` Nikhil Benesch
2020-12-15  3:34                   ` Ian Lance Taylor
2020-12-15  3:48                     ` Nikhil Benesch
2020-12-15  8:00                       ` Nikhil Benesch
2020-12-16 14:00                         ` Nikhil Benesch
2020-12-16 19:20                           ` Rainer Orth
2020-12-16 20:13                             ` Nikhil Benesch
2020-12-17  4:59                               ` Nikhil Benesch
2020-12-17 12:28                                 ` Rainer Orth
2020-12-17 16:31                                   ` Nikhil Benesch
2020-12-17 18:05                                     ` Ian Lance Taylor
2020-12-17 18:21                                       ` Nikhil Benesch
2020-12-21  4:16                                         ` Ian Lance Taylor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKOQZ8x5-Ay6tWJErH4dh3zrxAPYOeW81h_7OXfnuwRNJ2b2dw@mail.gmail.com \
    --to=iant@golang.org \
    --cc=gcc-patches@gnu.org \
    --cc=nikhil.benesch@gmail.com \
    --cc=ro@cebitec.uni-bielefeld.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).