From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27130 invoked by alias); 27 Jan 2013 02:40:54 -0000 Received: (qmail 26990 invoked by uid 22791); 27 Jan 2013 02:40:52 -0000 X-SWARE-Spam-Status: No, hits=-6.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-ob0-f176.google.com (HELO mail-ob0-f176.google.com) (209.85.214.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 27 Jan 2013 02:40:45 +0000 Received: by mail-ob0-f176.google.com with SMTP id v19so1725150obq.7 for ; Sat, 26 Jan 2013 18:40:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=i4JiGr+F0BdyKSK1TEUFT+Z11zrNXbobrz/FhYgd9DU=; b=Q2TGhL7idw8B2qRw9PwO1laJtFi3PhtYsXnKYnPh/6Dl+ypVPDQm5UnXUVzc/cVJ+a qcKIHGzDzjPtgUREGUCISmY6fA867Jq5wvJp66nHpeqIRloSNDornDBkdsTem2ve2SLI iXpFLDnLSYbHq+6mX2h0BoTdZK556PxHNL7H5Sz4gg0BC5ArbPIuUHn942fBawS51ad9 G2V53VQEqUDKsYeuFXEEAKJIwwovod9uV46McLepVYPQkRQfLhsPKpHdEj3ynRlMOnHp ZvHvuFkCik/kBMtRjQLzL9Ba3db8qkc5vudZTVw8NG4F81ZuS37Bn5rzme2nQYlFLgGT 8lpA== MIME-Version: 1.0 X-Received: by 10.60.3.193 with SMTP id e1mr8373773oee.39.1359254444818; Sat, 26 Jan 2013 18:40:44 -0800 (PST) Received: by 10.182.23.39 with HTTP; Sat, 26 Jan 2013 18:40:44 -0800 (PST) In-Reply-To: <201301252220.39972.vapier@gentoo.org> References: <1356305421-13533-1-git-send-email-vapier@gentoo.org> <201301151245.14337.vapier@gentoo.org> <201301252220.39972.vapier@gentoo.org> Date: Sun, 27 Jan 2013 02:40:00 -0000 Message-ID: Subject: Re: [PATCH 1/2] [pr53679] libgo: add a --enable-werror configure flag From: Ian Lance Taylor To: Mike Frysinger Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQnBStPfJM+pYD8KYDSXTRy1srYJ761LJ7fIGSYx5xns2+qOOhc3i7Bpe0d15wevu7VZDttsT5ZxEAEUiG4wYnJ0U+MLKGlZsT+fWrq4b5sgjdUjHJ7nKcd4kiJTNqkpoE6ZnMoz3BOvHDxyVEdThmKjo2cTaje8nqZYKY7HLCGXM8ZVJt4at36jbD8Rsxt14X8LILMn X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-01/txt/msg01275.txt.bz2 On Fri, Jan 25, 2013 at 7:20 PM, Mike Frysinger wrote: > On Friday 25 January 2013 19:13:55 Ian Lance Taylor wrote: >> On Tue, Jan 15, 2013 at 9:45 AM, Mike Frysinger wrote: >> > On Tuesday 15 January 2013 09:56:06 Ian Lance Taylor wrote: >> >> On Sun, Dec 23, 2012 at 3:30 PM, Mike Frysinger wrote: >> >> > diff --git a/libgo/configure.ac b/libgo/configure.ac >> >> > index 8cde50b..63d8cbc 100644 >> >> > --- a/libgo/configure.ac >> >> > +++ b/libgo/configure.ac >> >> > @@ -50,8 +50,11 @@ AC_PROG_AWK >> >> > >> >> > WARN_FLAGS='-Wall -Wextra -Wwrite-strings -Wcast-qual' >> >> > AC_SUBST(WARN_FLAGS) >> >> > >> >> > -dnl FIXME: This should be controlled by --enable-maintainer-mode. >> >> > -WERROR="-Werror" >> >> > +AC_ARG_ENABLE(werror, [AS_HELP_STRING([--enable-werror], >> >> > + [turns on -Werror >> >> > @<:@default=yes@:>@])]) +if test "x$enable_werror" != "xno"; then >> >> > + WERROR="-Werror" >> >> > +fi >> >> > >> >> > AC_SUBST(WERROR) >> >> > >> >> > glibgo_toolexecdir=no >> >> >> >> Can you say something about when you needed this? What errors were you >> >> seeing? >> > >> > the referenced PR describes one: >> > /build/src/gcc-4.7.1/libgo/runtime/print.c: In function 'gwrite': >> > /build/src/gcc-4.7.1/libgo/runtime/print.c:20:3: error: ignoring return >> > value of 'write', declared with attribute warn_unused_result >> > [-Werror=unused-result] cc1: all warnings being treated as errors >> > >> > this bites distros that enable security settings by default (such as >> > fortify and ssp). but ignoring even that, i don't believe releases >> > should build all the time with -Werror -- i'm fine with defaulting to on >> > as long as there is a configure flag to turn it off which is what this >> > does like is already handled in much of the sourceware tree. -Werror is >> > great for development, but sucks when deployed on actual systems. the >> > assumptions made at time of checkin rarely stay constant forever (in >> > this case, a changing lib C can easily break it). -mike >> >> Thanks for the explanation. >> >> Committed to mainline. > > thanks! mind if i commit it to gcc-4.6 and gcc-4.7 too ? I certainly don't mind. You should probably get agreement from the release managers although this seems safe enough. Ian