From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127788 invoked by alias); 16 Jan 2019 01:10:26 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 127690 invoked by uid 89); 16 Jan 2019 01:10:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.9 required=5.0 tests=BAYES_00,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.2 spammy= X-HELO: mail-yb1-f195.google.com Received: from mail-yb1-f195.google.com (HELO mail-yb1-f195.google.com) (209.85.219.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 Jan 2019 01:10:24 +0000 Received: by mail-yb1-f195.google.com with SMTP id o73so1880445ybc.0 for ; Tue, 15 Jan 2019 17:10:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9N+zRNwbWbQxJ+L4216HZCZjftTxSSHQL8J1m813rew=; b=eIhw3JJurFsY1VAFrkbQuC5wcFCJ3surF0Gi0H0pAVcgxeYtaD+vtlq7+4ZbhP3RqH gINDiJKD0i/xDOzje06wsT7Z2FDlCi78syPTncuQaW18EHZUsLlUtZAUyejaVsSoKsCi 4qk1HZE1Puu9RHUgL5eaRPWPogCgKKKtbX8oEXoA9K33GedHV/YXfQznamcvRJsyfeFz J6gPWZ4CgjtNmljMcpAic1wIh3QUoMTJvu1Q3ydgFEtxkdb7afHdpc6OsXKI/L3GNrMv zpU3g/+r9z6DUxqLq/XxjpwOppxRTmUFpVJBiV/+ikZJqGE6A49qCH01pgc1qjX4Xc/T AbWg== MIME-Version: 1.0 References: <20181211101411.7067-1-tdevries@suse.de> <20181211101411.7067-6-tdevries@suse.de> In-Reply-To: <20181211101411.7067-6-tdevries@suse.de> From: "Ian Lance Taylor via gcc-patches" Reply-To: Ian Lance Taylor Date: Wed, 16 Jan 2019 01:10:00 -0000 Message-ID: Subject: Re: [PATCH 5/9] [libbacktrace] Unify function name preference handling To: Tom de Vries Cc: gcc-patches , Ian Lance Taylor Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg00885.txt.bz2 On Tue, Dec 11, 2018 at 2:15 AM Tom de Vries wrote: > > Both read_function_entry and read_referenced_name implement a priority scheme > for names. The priorities are: > - 1st: DW_AT_linkage_name > - 2nd: Name from DW_AT_abstract_origin or DW_AT_specification > - 3rd: DW_AT_name. > > Ensure both functions fully adhere to it. > > 2018-11-21 Tom de Vries > > * dwarf.c (read_referenced_name): Don't allow DW_AT_name to override any > name. > (read_function_entry): Same. Don't allow name found via > DW_AT_abstract_origin or case DW_AT_specification to override linkage > name. This is OK. Thanks. Ian