From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by sourceware.org (Postfix) with ESMTPS id 64B333858D37 for ; Fri, 23 Jun 2023 03:31:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 64B333858D37 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=golang.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=google.com Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-51bec5c09ecso101199a12.2 for ; Thu, 22 Jun 2023 20:31:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=golang-org.20221208.gappssmtp.com; s=20221208; t=1687491071; x=1690083071; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=DAzEbFhHUN6vpSl44cr+PyZiy06i1cT+gTVrKUtLBq0=; b=YEET0uaa7r3bjfGJDYRm2J7UD2aph0oWqkNn1wm9t1nhVUuzOCbYqkBEq4s2TvZUpq laKuMSXyMYd13Fpm1RGSEJTJdCnu8bqOFGg8C6DxQ1XtzVVVx8fBiIMxqP7L1GU4xOSJ RMQc79a2k4qYHF9ZVKE1jTUeT6C8IjTCjF6Xt/cpaZbD01E09BSR1rdxMR29Lj8uZ20b nZ2dD9wXBkPChiYdKOqlklklUq1UeEgrPIamYi2HApXIdmNjdwkOX8hURIouTAILzEGE HgcRDyEruu6W3JDxesNWfkSudEP5/PqP7egXLxJeDMaztP1FmXvXcWa+c2v96Exq8zvm YfgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687491071; x=1690083071; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DAzEbFhHUN6vpSl44cr+PyZiy06i1cT+gTVrKUtLBq0=; b=iVlsac8O3LzPZRpTT+ipMImjrOS5vIdQ3TpH8WaLNPv4PyY/9CjjcdLqtTYj0ssCmI 2xQ39DcpdPxxyjSY4bhhtTl8j3YB7UEnDvPvR5qMO9kOKL9sjtqD4E8E0Akq73mCJGwC tbzE/ufyZQR1npHxRY34nOIYs2qunmjkvmdf+aitJ7W2hupZL7NPSKvgp9o+eiwgBu71 NTxlpWlA0ZriUU12zEnqWGH6FcxHLuHqEjM6rqJJvJUfD04GhnEHTHgHp47Bm4bWZb32 cCeXPSxc9cYfjwGnuo447oz80APf2M5na98wQ1AX4xCZLUZa0eL9VQYWx2fQqpv/ASnT FjyA== X-Gm-Message-State: AC+VfDzYSLQ1IBHj+x8IQIvpAfTs+tVBeNqeJ5wSinCzJ8MPdCQ0LlcP fAPsD/UkgB2grqMdqC9MyBnU73L+g3K9QsO1DtcCYA== X-Google-Smtp-Source: ACHHUZ6gBtuwa+ozolgElAYXwHDwa3aQcjXfznXnEs9Ui/rwSf4GSb88mN96h8Vm+eCyKym9JiS84L08n6BbWLm4+OE= X-Received: by 2002:a50:e604:0:b0:518:9174:9b5f with SMTP id y4-20020a50e604000000b0051891749b5fmr16614930edm.1.1687491070747; Thu, 22 Jun 2023 20:31:10 -0700 (PDT) MIME-Version: 1.0 References: <20230616160002.1854983-1-murphyp@linux.ibm.com> In-Reply-To: From: Ian Lance Taylor Date: Thu, 22 Jun 2023 20:30:58 -0700 Message-ID: Subject: Re: [PATCH 1/2] go: update usage of TARGET_AIX to TARGET_AIX_OS To: Peter Bergner Cc: "Paul E. Murphy" , gcc-patches Content-Type: multipart/alternative; boundary="000000000000d5b05305fec3a1f3" X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,USER_IN_DEF_SPF_WL autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000d5b05305fec3a1f3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Jun 22, 2023, 4:47 PM Peter Bergner wrote: > On 6/22/23 6:37 PM, Peter Bergner via Gcc-patches wrote: > > On 6/16/23 12:01 PM, Ian Lance Taylor via Gcc-patches wrote: > >> On Fri, Jun 16, 2023 at 9:00=E2=80=AFAM Paul E. Murphy via Gcc-patches > >> wrote: > >>> > >>> TARGET_AIX is defined to a non-zero value on linux and maybe other > >>> powerpc64le targets. This leads to unexpected behavior such as > >>> dropping the .go_export section when linking a shared library > >>> on linux/powerpc64le. > >>> > >>> Instead, use TARGET_AIX_OS to toggle AIX specific behavior. > >>> > >>> Fixes golang/go#60798. > >>> > >>> gcc/go/ChangeLog: > >>> > >>> * go-backend.cc [TARGET_AIX]: Rename and update usage to > >>> TARGET_AIX_OS. > >>> * go-lang.cc: Likewise. > >> > >> This is OK. > >> > >> Thanks. > >> > >> Ian > > > > I pushed this to trunk for Paul. > > I see this is broken on the release branches too. Are backports ok > after some burn-in on trunk? > Yes. Thanks. Ian > --000000000000d5b05305fec3a1f3--