From: Ian Lance Taylor <iant@golang.org>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: "Ian Lance Taylor via Gcc-patches" <gcc-patches@gcc.gnu.org>,
gofrontend-dev <gofrontend-dev@googlegroups.com>,
"Sören Tempel" <soeren@soeren-tempel.net>
Subject: Re: libgo patch committed: Use a C function to call mmap
Date: Tue, 20 Jun 2023 12:37:03 -0700 [thread overview]
Message-ID: <CAKOQZ8xwkvVe7CoK9EVKZvjDgRfOdDH0eBWximW2x6R0SVrneA@mail.gmail.com> (raw)
In-Reply-To: <87bkhanfrl.fsf@igel.home>
On Tue, Jun 20, 2023 at 11:35 AM Andreas Schwab <schwab@linux-m68k.org> wrote:
>
> On Jun 20 2023, Ian Lance Taylor via Gcc-patches wrote:
>
> > This libgo patches changes the runtime pacakge to use a C function to call mmap.
> >
> > The final argument to mmap, of type off_t, varies. In
> > https://go.dev/cl/445375
> > (https://gcc.gnu.org/pipermail/gcc-patches/2022-October/604158.html)
> > we changed it to always use the C off_t type, but that broke 32-bit
> > big-endian Linux systems.
>
> This has nothing to do with big-endian, armv7 isn't big-endian.
OK, but I think that it does have something to do with big-endian.
The bug was that on some 32-bit systems it was passing a 64-bit value
to a function that expected a 32-bit value. The problem didn't show
up on 32-bit x86 because it is little-endian, and did show up on
32-bit PPC because it is big-endian. I guess the armv7 case was
failing for a different reason.
Ian
next prev parent reply other threads:[~2023-06-20 19:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 16:57 Ian Lance Taylor
2023-06-20 18:35 ` Andreas Schwab
2023-06-20 19:37 ` Ian Lance Taylor [this message]
2023-06-20 21:21 ` Andreas Schwab
2023-06-21 3:33 ` [gofrontend-dev] " Cherry Mui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKOQZ8xwkvVe7CoK9EVKZvjDgRfOdDH0eBWximW2x6R0SVrneA@mail.gmail.com \
--to=iant@golang.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gofrontend-dev@googlegroups.com \
--cc=schwab@linux-m68k.org \
--cc=soeren@soeren-tempel.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).