From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-491376-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 109920 invoked by alias); 30 Nov 2018 14:46:47 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 109910 invoked by uid 89); 30 Nov 2018 14:46:47 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-9.4 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,TIME_LIMIT_EXCEEDED,USER_IN_DEF_SPF_WL autolearn=unavailable version=3.3.2 spammy=Hx-languages-length:1384
X-HELO: mail-yw1-f65.google.com
Received: from mail-yw1-f65.google.com (HELO mail-yw1-f65.google.com) (209.85.161.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 30 Nov 2018 14:46:37 +0000
Received: by mail-yw1-f65.google.com with SMTP id q11so2359363ywa.0        for <gcc-patches@gcc.gnu.org>; Fri, 30 Nov 2018 06:46:36 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=google.com; s=20161025;        h=mime-version:in-reply-to:references:from:date:message-id:subject:to         :cc;        bh=fxZ4x6m55jVB8suhlGRn88kkTlmQLVWck8Yv0YAEymM=;        b=R5X0Qc1o8XsPBOiEXnZqTgaYmhe+bzGFqxUkVoF9UnfhHniua7yQsHUcy94xOE5eF8         c7U0hvRUzgm3FtmDgNFxJ/8d000SfUqn/xNN5PCajzaiZPzL8ahCvHjJZ6XDMygLAVWl         sinN5Xs0eBO6EVpHnKTIT0x79Ps6odtC3fGq0ZZm5WhsvlGsPuwAVjVAN3wQ5TjJSGy8         VIj2rHs58ZANvtPmVjSxbdX7g9ZQMtqdjxBSctLguTRqgep4HG8nsoVmZDyL4RVsYqEm         Szc0P3wbMbqvCzG0fe105iUcx7OdrVMY1feKe6bGAHXtIEhD8g0jsjyjrC+USfDS0HVZ         xtGw==
MIME-Version: 1.0
Received: by 2002:a0d:eb4e:0:0:0:0:0 with HTTP; Fri, 30 Nov 2018 06:46:34 -0800 (PST)
In-Reply-To: <b4883a8d-0859-3cf2-3df1-38c1214fc645@suse.de>
References: <20181123205612.GA3609@delia> <CAKOQZ8wUvdV0fjKnLvvyX9oQv7YK_FkzRyJRf=12B4kQ2YwVag@mail.gmail.com> <b4883a8d-0859-3cf2-3df1-38c1214fc645@suse.de>
From: "Ian Lance Taylor via gcc-patches" <gcc-patches@gcc.gnu.org>
Reply-To: Ian Lance Taylor <iant@google.com>
Date: Fri, 30 Nov 2018 14:46:00 -0000
Message-ID: <CAKOQZ8yDRa7CBjkGBgMSw0gWPy3fbgA2UKrCZ1_ArToRW-B0TQ@mail.gmail.com>
Subject: Re: [PATCH 4/4][libbacktrace] Add tests for unused formats
To: Tom de Vries <tdevries@suse.de>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, Ian Lance Taylor <ian@airs.com>
Content-Type: text/plain; charset="UTF-8"
X-IsSubscribed: yes
X-SW-Source: 2018-11/txt/msg02578.txt.bz2

On Fri, Nov 30, 2018 at 1:06 AM, Tom de Vries <tdevries@suse.de> wrote:
> On 29-11-18 19:28, Ian Lance Taylor wrote:
>> On Fri, Nov 23, 2018 at 12:56 PM, Tom de Vries <tdevries@suse.de> wrote:
>>>
>>> When building libbacktrace, we typically use elf.c, and don't build pecoff.c,
>>> xcoff.c or unknown.c
>>>
>>> Add testcases that use unused format to ensure that we also build and
>>> test those on a typical development setup.
>>>
>>> Bootstrapped and reg-tested on x86_64.
>>>
>>> OK for trunk?
>>>
>>> Thanks,
>>> - Tom
>>>
>>> [libbacktrace] Add tests for unused formats
>>>
>>> 2018-11-23  Tom de Vries  <tdevries@suse.de>
>>>
>>>         * configure.ac (NOT_HAVE_FORMAT_ELF, NOT_HAVE_FORMAT_PECOFF)
>>>         (NOT_HAVE_FORMAT_UNKNOWN, NOT_HAVE_FORMAT_XCOFF_32)
>>>         (NOT_HAVE_FORMAT_XCOFF_64): New AM_CONDITIONAL.
>>>         * configure: Regenerate.
>>>         * Makefile.am (check_PROGRAMS): Add test_elf, test_xcoff_32,
>>>         test_xcoff_64, test_pecoff and test_unknown.
>>>         * Makefile.in: Regenerate.
>>>         * test_format.c: New file.
>>
>>
>> Again it seems feasible to avoid GNU make features, and skip the
>> negative conditionals and just build the tests for all formats
>> including the one on the current system.  It's not worth adding the
>> complexity to avoid building the test.  Thanks.
>
> Done.
>
> OK for trunk?

This is OK.

Thanks.

Ian