From: Ian Lance Taylor <iant@google.com>
To: Richard Biener <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org, Diego Novillo <dnovillo@google.com>
Subject: Re: [PATCH] Fix PR54659, include gmp.h from system.h
Date: Fri, 21 Dec 2012 16:00:00 -0000 [thread overview]
Message-ID: <CAKOQZ8yFGSc_jYfk2dr=16FXKNaAasvL+p1cwsbU804OBnyZ+w@mail.gmail.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1212211411260.6889@zhemvz.fhfr.qr>
[-- Attachment #1: Type: text/plain, Size: 546 bytes --]
On Fri, Dec 21, 2012 at 5:14 AM, Richard Biener <rguenther@suse.de> wrote:
>
> After the Ada fix including gmp.h from system.h is trivial
> (by means of double-int.h it was included from almost everywhere
> already)
>
> Bootstrapped on x86_64-unknown-linux-gnu, testing in progress.
>
> Ok for trunk? (Go frontend "unfixed")
Fixed like so. Bootstrapped and ran Go testsuite on
x86_64-unknown-linux-gnu. Committed to mainline.
Ian
2012-12-21 Ian Lance Taylor <iant@google.com>
PR bootstrap/54659
* go-system.h: Don't include <cstdio>.
[-- Attachment #2: foo.patch --]
[-- Type: application/octet-stream, Size: 3081 bytes --]
Index: gcc/go/gofrontend/runtime.cc
===================================================================
--- gcc/go/gofrontend/runtime.cc (revision 194666)
+++ gcc/go/gofrontend/runtime.cc (working copy)
@@ -6,8 +6,6 @@
#include "go-system.h"
-#include <gmp.h>
-
#include "gogo.h"
#include "types.h"
#include "expressions.h"
Index: gcc/go/gofrontend/expressions.h
===================================================================
--- gcc/go/gofrontend/expressions.h (revision 194666)
+++ gcc/go/gofrontend/expressions.h (working copy)
@@ -7,7 +7,6 @@
#ifndef GO_EXPRESSIONS_H
#define GO_EXPRESSIONS_H
-#include <gmp.h>
#include <mpfr.h>
#include "operator.h"
Index: gcc/go/gofrontend/statements.cc
===================================================================
--- gcc/go/gofrontend/statements.cc (revision 194666)
+++ gcc/go/gofrontend/statements.cc (working copy)
@@ -6,8 +6,6 @@
#include "go-system.h"
-#include <gmp.h>
-
#include "go-c.h"
#include "types.h"
#include "expressions.h"
Index: gcc/go/gofrontend/gogo-tree.cc
===================================================================
--- gcc/go/gofrontend/gogo-tree.cc (revision 194666)
+++ gcc/go/gofrontend/gogo-tree.cc (working copy)
@@ -6,8 +6,6 @@
#include "go-system.h"
-#include <gmp.h>
-
#include "toplev.h"
#include "tree.h"
#include "gimple.h"
Index: gcc/go/gofrontend/types.cc
===================================================================
--- gcc/go/gofrontend/types.cc (revision 194666)
+++ gcc/go/gofrontend/types.cc (working copy)
@@ -6,8 +6,6 @@
#include "go-system.h"
-#include <gmp.h>
-
#include "toplev.h"
#include "intl.h"
#include "tree.h"
Index: gcc/go/gofrontend/expressions.cc
===================================================================
--- gcc/go/gofrontend/expressions.cc (revision 194666)
+++ gcc/go/gofrontend/expressions.cc (working copy)
@@ -8,8 +8,6 @@
#include <algorithm>
-#include <gmp.h>
-
#include "toplev.h"
#include "intl.h"
#include "tree.h"
Index: gcc/go/gofrontend/lex.h
===================================================================
--- gcc/go/gofrontend/lex.h (revision 194666)
+++ gcc/go/gofrontend/lex.h (working copy)
@@ -7,7 +7,6 @@
#ifndef GO_LEX_H
#define GO_LEX_H
-#include <gmp.h>
#include <mpfr.h>
#include "operator.h"
Index: gcc/go/go-system.h
===================================================================
--- gcc/go/go-system.h (revision 194666)
+++ gcc/go/go-system.h (working copy)
@@ -125,15 +125,6 @@ struct hash<T*>
// system.h.
#include <iostream>
-// Some versions of gmp.h assume that #include <iostream> will define
-// std::FILE. This is not true with libstdc++ 4.3 and later. This is
-// fixed in GMP 4.3, but at this point we don't know which version of
-// GMP is in use. Since the top level configure script accepts GMP
-// 4.2, at least for now we #include <cstdio> to ensure that GMP 4.2
-// will work. FIXME: This can be removed when we require GMP 4.3 or
-// later.
-#include <cstdio>
-
#include "system.h"
#include "ansidecl.h"
#include "coretypes.h"
next prev parent reply other threads:[~2012-12-21 16:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-21 13:15 Richard Biener
2012-12-21 13:17 ` Jakub Jelinek
2012-12-21 16:00 ` Ian Lance Taylor [this message]
2013-01-08 18:50 ` H.J. Lu
2013-01-09 2:31 ` Iyer, Balaji V
2013-01-09 8:36 ` Richard Biener
2012-12-21 16:26 Dominique Dhumieres
2012-12-21 19:03 ` Ian Lance Taylor
2012-12-21 20:06 ` Dominique Dhumieres
2012-12-21 21:20 ` Dominique Dhumieres
2012-12-22 1:56 ` Gerald Pfeifer
2012-12-22 8:55 ` Richard Biener
2012-12-22 9:50 ` Andreas Schwab
2012-12-22 10:43 ` Richard Biener
2012-12-22 10:52 ` Dominique Dhumieres
2012-12-22 11:14 ` Richard Sandiford
2012-12-22 11:03 ` Andreas Schwab
2012-12-27 16:11 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKOQZ8yFGSc_jYfk2dr=16FXKNaAasvL+p1cwsbU804OBnyZ+w@mail.gmail.com' \
--to=iant@google.com \
--cc=dnovillo@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).