From: "Ian Lance Taylor via gcc-patches" <gcc-patches@gcc.gnu.org>
To: Eduard-Mihai Burtescu <eddyb@lyken.rs>
Cc: Ian Lance Taylor <ian@airs.com>, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Refactor rust-demangle to be independent of C++ demangling.
Date: Fri, 08 Nov 2019 17:44:00 -0000 [thread overview]
Message-ID: <CAKOQZ8yk6=mf9U4_8KYwAeTfKReNoCh6UVDt2CTT5i6d2NPPag@mail.gmail.com> (raw)
In-Reply-To: <67791184-49ab-47ad-80a0-ed0be425b336@www.fastmail.com>
On Fri, Nov 8, 2019 at 9:02 AM Eduard-Mihai Burtescu <eddyb@lyken.rs> wrote:
>
> Ping #2 for https://gcc.gnu.org/ml/gcc-patches/2019-10/msg01830.html
> Original patch (without the early exit optimization): https://gcc.gnu.org/ml/gcc-patches/2019-10/msg01591.html
Sorry for letting this slide.
Do we need the CHECK_OR and ERROR_AND macros? Is there anything like
those elsewhere in the libiberty or GCC sources? I would rather than
have ordinary code than obscure macros.
Ian
> On Wed, Oct 30, 2019, at 6:46 PM, Eduard-Mihai Burtescu wrote:
> > Ping: https://gcc.gnu.org/ml/gcc-patches/2019-10/msg01830.html
> > Original patch (without the early exit optimization):
> > https://gcc.gnu.org/ml/gcc-patches/2019-10/msg01591.html
> >
> > Thanks,
> > - Eddy B.
> >
> > On Fri, Oct 25, 2019, at 3:44 PM, Eduard-Mihai Burtescu wrote:
> > > > This can be further optimized by using memcmp in place of strncmp, since from
> > > > the length check you know that you won't see the null terminator among the three
> > > > chars you're checking.
> > >
> > > Fair enough, here's the combined changelog/diff, with memcmp:
next prev parent reply other threads:[~2019-11-08 17:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 18:24 Eduard-Mihai Burtescu
2019-10-22 18:48 ` Ian Lance Taylor via gcc-patches
2019-10-23 14:29 ` Eduard-Mihai Burtescu
2019-10-23 16:37 ` Alexander Monakov
2019-10-23 16:41 ` Segher Boessenkool
2019-10-23 17:19 ` Jakub Jelinek
2019-10-23 17:29 ` Segher Boessenkool
2019-10-23 17:37 ` Jakub Jelinek
2019-10-23 17:43 ` Segher Boessenkool
2019-10-25 12:46 ` Eduard-Mihai Burtescu
2019-10-30 16:56 ` Eduard-Mihai Burtescu
2019-11-08 17:02 ` Eduard-Mihai Burtescu
2019-11-08 17:44 ` Ian Lance Taylor via gcc-patches [this message]
2019-11-08 19:17 ` Eduard-Mihai Burtescu
2019-11-08 19:23 ` Ian Lance Taylor via gcc-patches
2019-11-15 21:00 ` Eduard-Mihai Burtescu
2019-11-16 15:39 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKOQZ8yk6=mf9U4_8KYwAeTfKReNoCh6UVDt2CTT5i6d2NPPag@mail.gmail.com' \
--to=gcc-patches@gcc.gnu.org \
--cc=eddyb@lyken.rs \
--cc=ian@airs.com \
--cc=iant@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).