Re: libgcc patch committed: Change __real_pthread_create ref to be non-weak

[Ian Lance Taylor <iant@google.com>]

On Mon, Jan 14, 2013 at 11:33 AM, Ian Lance Taylor <iant@google.com> wrote:
> The declaration of __real_pthread_create in generic-morestack-thread.c
> had attribute weak.  Note that this code is linked with --wrap
> pthread_create, so the reference to __real_pthread_create is really to
> pthread_create.  Using weak was incorrect, because the reference really
> is a strong one.  There is no support for __real_pthread_create aka
> pthread_create to not be defined.  It caused some Go programs to fail
> when linking statically, because a weak reference does not cause a
> symbol definition to be included from an archive.  If there was no other
> reason to include pthread_create, then pthread_create would never be
> defined, so the call to __real_pthread_create would crash at runtime.
>
> This fixes a regression, as static linking of Go programs used to work.
>
> Bootstrapped and ran Go testsuite and split-stack tests on
> x86_64-unknown-linux-gnu.  Committed to mainline.

Sigh, this turned out to be wrong because it causes libgcc_s.so to
require libpthread.so.

Reverted.

Ian