From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128704 invoked by alias); 18 Oct 2018 23:03:01 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 128681 invoked by uid 89); 18 Oct 2018 23:03:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-17.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.2 spammy=1898, eat, HX-Received:4ec9, marxin X-HELO: mail-yw1-f66.google.com Received: from mail-yw1-f66.google.com (HELO mail-yw1-f66.google.com) (209.85.161.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 18 Oct 2018 23:02:58 +0000 Received: by mail-yw1-f66.google.com with SMTP id m127-v6so12497028ywb.0 for ; Thu, 18 Oct 2018 16:02:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=xor3/OX/UW+tOYbuu/kyu4SBEmJbN6bixKT+6zpo7ns=; b=TtqcSAfDTXa1qL4jELRwepXaYfOqEC5RW7gE8x4GT++hjstWYbsvdhovIF+GVxmtq9 gcKjGMRPwOVDM1F6lm5Ij6joIMtJi8nlVG812W/46FuspEQ2lyeyUi7opME6ApzzK12a DrFfftan+BtRalG+fEyqi/r898nQFqFxwwlKRQFh0FLNSsXte2dfbtW7Pkr1IIMIsuYi FRn7yGMYDglr7R+D7PYKr5O66El4u3cUufkGAUM5THDSPDCMzxQORVS53mYHrAGD7jwP Va2AeUjwzl3KVjC+M53H1efnvP54kk1cZSquTXkFO5pXAvnmI9x1FbR+0V6oesjoz1JW acqQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=golang-org.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=xor3/OX/UW+tOYbuu/kyu4SBEmJbN6bixKT+6zpo7ns=; b=KxCDLIiZOU76gDicTn9Gk2c7WVOv7Kj8XzEmzIGH78tNxMlec4E/57vLn0hNU6zQNo n5ITz1A3nNzLr+sc31nBrRNUpQZPd5HXDMOWP8TWCBfCHdRiEFtVDCYlL8yp23QwsuwE oadxoljjyCBg1RyteAJHv8Ng57uxP08BRixNgnt6MbBxBMusK7el/sgjiVwJcTZSQOD3 ZgMv0+hRch1WnbSJgot4R4i5tkPG2jlr6R0eqAY2lUS7ZhVac/4hRXN8j1WJEe/LdLcd PPEMO8j+I6waMl0yrFE0v0MKwQJAPiE8mA3DYqxdxHyzgkKszbGwseyGyqcCuAtzDUPr fItw== MIME-Version: 1.0 Sender: iant@google.com Received: by 2002:a0d:fd04:0:0:0:0:0 with HTTP; Thu, 18 Oct 2018 16:02:55 -0700 (PDT) In-Reply-To: <192f112275eb2c7bc74fdd3b91c0b32882695d22.1537774329.git.mliska@suse.cz> References: <192f112275eb2c7bc74fdd3b91c0b32882695d22.1537774329.git.mliska@suse.cz> From: Ian Lance Taylor Date: Thu, 18 Oct 2018 23:55:00 -0000 Message-ID: Subject: Re: [PATCH 2/4] Remove unused functions and fields. To: marxin Cc: gcc-patches Content-Type: multipart/mixed; boundary="0000000000009aeb67057888c94f" X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg01161.txt.bz2 --0000000000009aeb67057888c94f Content-Type: text/plain; charset="UTF-8" Content-length: 1130 On Sat, Sep 22, 2018 at 12:08 PM, marxin wrote: > > gcc/go/ChangeLog: > > 2018-09-24 Martin Liska > > * gofrontend/escape.cc (Gogo::analyze_escape): Remove > usage of a parameter. > (Gogo::assign_connectivity): Likewise. > (class Escape_analysis_tag): Likewise. > (Gogo::tag_function): Likewise. > * gofrontend/expressions.cc (Call_expression::do_type): Likewise. > * gofrontend/gogo.h (class Gogo): Likewise. > * gofrontend/types.cc (class Call_multiple_result_type): Likewise. > (Type::make_call_multiple_result_type): Likewise. > * gofrontend/types.h (class Type): Likewise. > * gofrontend/wb.cc (class Check_escape): Likewise. > (Gogo::add_write_barriers): Likewise. HI, unfortunately this is wrong. As described in gcc/go/gofrontend/README, the files in that directory are mirrored from a separate repository (the same is true of the files in the libgo directory). You should not make changes to them directly in the GCC repository. I have reverted these changes, as follows. Sorry. Ian --0000000000009aeb67057888c94f Content-Type: text/plain; charset="US-ASCII"; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jnf6xuh31 Content-length: 7406 SW5kZXg6IGdjYy9nby9nb2Zyb250ZW5kL2VzY2FwZS5jYwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBnY2MvZ28vZ29mcm9udGVuZC9lc2NhcGUuY2MJ KHJldmlzaW9uIDI2NTI5MykKKysrIGdjYy9nby9nb2Zyb250ZW5kL2VzY2Fw ZS5jYwkod29ya2luZyBjb3B5KQpAQCAtOTc5LDcgKzk3OSw3IEBAIEdvZ286 OmFuYWx5emVfZXNjYXBlKCkKICAgICAgIGZvciAoc3RkOjp2ZWN0b3I8TmFt ZWRfb2JqZWN0Kj46Oml0ZXJhdG9yIGZuID0gc3RhY2suYmVnaW4oKTsKICAg ICAgICAgICAgZm4gIT0gc3RhY2suZW5kKCk7CiAgICAgICAgICAgICsrZm4p Ci0JdGhpcy0+dGFnX2Z1bmN0aW9uKCpmbik7CisgICAgICAgIHRoaXMtPnRh Z19mdW5jdGlvbihjb250ZXh0LCAqZm4pOwogCiAgICAgICBpZiAodGhpcy0+ ZGVidWdfZXNjYXBlX2xldmVsKCkgIT0gMCkKIAl7CkBAIC0xMjMyLDEwICsx MjMyLDEwIEBAIEVzY2FwZV9hbmFseXNpc19sb29wOjpzdGF0ZW1lbnQoQmxv Y2sqLAogY2xhc3MgRXNjYXBlX2FuYWx5c2lzX2Fzc2lnbiA6IHB1YmxpYyBU cmF2ZXJzZQogewogcHVibGljOgotICBFc2NhcGVfYW5hbHlzaXNfYXNzaWdu KEVzY2FwZV9jb250ZXh0KiBjb250ZXh0KQorICBFc2NhcGVfYW5hbHlzaXNf YXNzaWduKEVzY2FwZV9jb250ZXh0KiBjb250ZXh0LCBOYW1lZF9vYmplY3Qq IGZuKQogICAgIDogVHJhdmVyc2UodHJhdmVyc2Vfc3RhdGVtZW50cwogCSAg ICAgICB8IHRyYXZlcnNlX2V4cHJlc3Npb25zKSwKLSAgICAgIGNvbnRleHRf KGNvbnRleHQpCisgICAgICBjb250ZXh0Xyhjb250ZXh0KSwgZm5fKGZuKQog ICB7IH0KIAogICAvLyBNb2RlbCBzdGF0ZW1lbnRzIHdpdGhpbiBhIGZ1bmN0 aW9uIGFzIGFzc2lnbm1lbnRzIGFuZCBmbG93cyBiZXR3ZWVuIG5vZGVzLgpA QCAtMTI3Miw2ICsxMjcyLDggQEAgcHVibGljOgogcHJpdmF0ZToKICAgLy8g VGhlIGVzY2FwZSBjb250ZXh0IGZvciB0aGlzIHNldCBvZiBmdW5jdGlvbnMu CiAgIEVzY2FwZV9jb250ZXh0KiBjb250ZXh0XzsKKyAgLy8gVGhlIGN1cnJl bnQgZnVuY3Rpb24gYmVpbmcgYW5hbHl6ZWQuCisgIE5hbWVkX29iamVjdCog Zm5fOwogfTsKIAogLy8gSGVscGVyIGZ1bmN0aW9uIHRvIGRldGVjdCBzZWxm IGFzc2lnbm1lbnQgbGlrZSB0aGUgZm9sbG93aW5nLgpAQCAtMjcwMiw3ICsy NzA0LDcgQEAgR29nbzo6YXNzaWduX2Nvbm5lY3Rpdml0eShFc2NhcGVfY29u dGV4dAogICBpbnQgc2F2ZV9kZXB0aCA9IGNvbnRleHQtPmxvb3BfZGVwdGgo KTsKICAgY29udGV4dC0+c2V0X2xvb3BfZGVwdGgoMSk7CiAKLSAgRXNjYXBl X2FuYWx5c2lzX2Fzc2lnbiBlYShjb250ZXh0KTsKKyAgRXNjYXBlX2FuYWx5 c2lzX2Fzc2lnbiBlYShjb250ZXh0LCBmbik7CiAgIEZ1bmN0aW9uOjpSZXN1 bHRzKiByZXMgPSBmbi0+ZnVuY192YWx1ZSgpLT5yZXN1bHRfdmFyaWFibGVz KCk7CiAgIGlmIChyZXMgIT0gTlVMTCkKICAgICB7CkBAIC0zMjY1LDEzICsz MjY3LDE3IEBAIEdvZ286OnByb3BhZ2F0ZV9lc2NhcGUoRXNjYXBlX2NvbnRl eHQqIGMKIGNsYXNzIEVzY2FwZV9hbmFseXNpc190YWcKIHsKICBwdWJsaWM6 Ci0gIEVzY2FwZV9hbmFseXNpc190YWcoKQorICBFc2NhcGVfYW5hbHlzaXNf dGFnKEVzY2FwZV9jb250ZXh0KiBjb250ZXh0KQorICAgIDogY29udGV4dF8o Y29udGV4dCkKICAgeyB9CiAKICAgLy8gQWRkIG5vdGVzIHRvIHRoZSBmdW5j dGlvbidzIHR5cGUgYWJvdXQgdGhlIGVzY2FwZSBpbmZvcm1hdGlvbiBvZiBp dHMKICAgLy8gaW5wdXQgcGFyYW1ldGVycy4KICAgdm9pZAogICB0YWcoTmFt ZWRfb2JqZWN0KiBmbik7CisKKyBwcml2YXRlOgorICBFc2NhcGVfY29udGV4 dCogY29udGV4dF87CiB9OwogCiB2b2lkCkBAIC0zMzc5LDkgKzMzODUsOSBA QCBFc2NhcGVfYW5hbHlzaXNfdGFnOjp0YWcoTmFtZWRfb2JqZWN0KiBmCiAv LyByZXRhaW4gYW5hbHlzaXMgcmVzdWx0cyBhY3Jvc3MgaW1wb3J0cy4KIAog dm9pZAotR29nbzo6dGFnX2Z1bmN0aW9uKE5hbWVkX29iamVjdCogZm4pCitH b2dvOjp0YWdfZnVuY3Rpb24oRXNjYXBlX2NvbnRleHQqIGNvbnRleHQsIE5h bWVkX29iamVjdCogZm4pCiB7Ci0gIEVzY2FwZV9hbmFseXNpc190YWcgZWF0 OworICBFc2NhcGVfYW5hbHlzaXNfdGFnIGVhdChjb250ZXh0KTsKICAgZWF0 LnRhZyhmbik7CiB9CiAKSW5kZXg6IGdjYy9nby9nb2Zyb250ZW5kL2V4cHJl c3Npb25zLmNjCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGdjYy9nby9n b2Zyb250ZW5kL2V4cHJlc3Npb25zLmNjCShyZXZpc2lvbiAyNjUyOTMpCisr KyBnY2MvZ28vZ29mcm9udGVuZC9leHByZXNzaW9ucy5jYwkod29ya2luZyBj b3B5KQpAQCAtMTAxMDgsNyArMTAxMDgsNyBAQCBDYWxsX2V4cHJlc3Npb246 OmRvX3R5cGUoKQogICBlbHNlIGlmIChyZXN1bHRzLT5zaXplKCkgPT0gMSkK ICAgICByZXQgPSByZXN1bHRzLT5iZWdpbigpLT50eXBlKCk7CiAgIGVsc2UK LSAgICByZXQgPSBUeXBlOjptYWtlX2NhbGxfbXVsdGlwbGVfcmVzdWx0X3R5 cGUoKTsKKyAgICByZXQgPSBUeXBlOjptYWtlX2NhbGxfbXVsdGlwbGVfcmVz dWx0X3R5cGUodGhpcyk7CiAKICAgdGhpcy0+dHlwZV8gPSByZXQ7CiAKSW5k ZXg6IGdjYy9nby9nb2Zyb250ZW5kL2dvZ28uaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBnY2MvZ28vZ29mcm9udGVuZC9nb2dvLmgJKHJldmlzaW9u IDI2NTI4NykKKysrIGdjYy9nby9nb2Zyb250ZW5kL2dvZ28uaAkod29ya2lu ZyBjb3B5KQpAQCAtNjgwLDcgKzY4MCw3IEBAIGNsYXNzIEdvZ28KICAgLy8g QWRkIG5vdGVzIGFib3V0IHRoZSBlc2NhcGUgbGV2ZWwgb2YgYSBmdW5jdGlv bidzIGlucHV0IGFuZCBvdXRwdXQKICAgLy8gcGFyYW1ldGVycyBmb3IgZXhw b3J0aW5nIGFuZCBpbXBvcnRpbmcgdG9wIGxldmVsIGZ1bmN0aW9ucy4gCiAg IHZvaWQKLSAgdGFnX2Z1bmN0aW9uKE5hbWVkX29iamVjdCopOworICB0YWdf ZnVuY3Rpb24oRXNjYXBlX2NvbnRleHQqLCBOYW1lZF9vYmplY3QqKTsKIAog ICAvLyBSZWNsYWltIG1lbW9yeSBvZiBlc2NhcGUgYW5hbHlzaXMgTm9kZXMu CiAgIHZvaWQKSW5kZXg6IGdjYy9nby9nb2Zyb250ZW5kL3R5cGVzLmNjCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIGdjYy9nby9nb2Zyb250ZW5kL3R5 cGVzLmNjCShyZXZpc2lvbiAyNjUyOTMpCisrKyBnY2MvZ28vZ29mcm9udGVu ZC90eXBlcy5jYwkod29ya2luZyBjb3B5KQpAQCAtNTQ0MSw4ICs1NDQxLDkg QEAgVHlwZTo6bWFrZV9uaWxfdHlwZSgpCiBjbGFzcyBDYWxsX211bHRpcGxl X3Jlc3VsdF90eXBlIDogcHVibGljIFR5cGUKIHsKICBwdWJsaWM6Ci0gIENh bGxfbXVsdGlwbGVfcmVzdWx0X3R5cGUoKQotICAgIDogVHlwZShUWVBFX0NB TExfTVVMVElQTEVfUkVTVUxUKQorICBDYWxsX211bHRpcGxlX3Jlc3VsdF90 eXBlKENhbGxfZXhwcmVzc2lvbiogY2FsbCkKKyAgICA6IFR5cGUoVFlQRV9D QUxMX01VTFRJUExFX1JFU1VMVCksCisgICAgICBjYWxsXyhjYWxsKQogICB7 IH0KIAogIHByb3RlY3RlZDoKQEAgLTU0NzUsMTQgKzU0NzYsMTggQEAgY2xh c3MgQ2FsbF9tdWx0aXBsZV9yZXN1bHRfdHlwZSA6IHB1YmxpYwogICB2b2lk CiAgIGRvX21hbmdsZWRfbmFtZShHb2dvKiwgc3RkOjpzdHJpbmcqKSBjb25z dAogICB7IGdvX2Fzc2VydChzYXdfZXJyb3JzKCkpOyB9CisKKyBwcml2YXRl OgorICAvLyBUaGUgZXhwcmVzc2lvbiBiZWluZyBjYWxsZWQuCisgIENhbGxf ZXhwcmVzc2lvbiogY2FsbF87CiB9OwogCiAvLyBNYWtlIGEgY2FsbCByZXN1 bHQgdHlwZS4KIAogVHlwZSoKLVR5cGU6Om1ha2VfY2FsbF9tdWx0aXBsZV9y ZXN1bHRfdHlwZSgpCitUeXBlOjptYWtlX2NhbGxfbXVsdGlwbGVfcmVzdWx0 X3R5cGUoQ2FsbF9leHByZXNzaW9uKiBjYWxsKQogewotICByZXR1cm4gbmV3 IENhbGxfbXVsdGlwbGVfcmVzdWx0X3R5cGUoKTsKKyAgcmV0dXJuIG5ldyBD YWxsX211bHRpcGxlX3Jlc3VsdF90eXBlKGNhbGwpOwogfQogCiAvLyBDbGFz cyBTdHJ1Y3RfZmllbGQuCkluZGV4OiBnY2MvZ28vZ29mcm9udGVuZC90eXBl cy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGdjYy9nby9nb2Zyb250 ZW5kL3R5cGVzLmgJKHJldmlzaW9uIDI2NTI5MykKKysrIGdjYy9nby9nb2Zy b250ZW5kL3R5cGVzLmgJKHdvcmtpbmcgY29weSkKQEAgLTUxMSw3ICs1MTEs NyBAQCBjbGFzcyBUeXBlCiAgIG1ha2VfbmlsX3R5cGUoKTsKIAogICBzdGF0 aWMgVHlwZSoKLSAgbWFrZV9jYWxsX211bHRpcGxlX3Jlc3VsdF90eXBlKCk7 CisgIG1ha2VfY2FsbF9tdWx0aXBsZV9yZXN1bHRfdHlwZShDYWxsX2V4cHJl c3Npb24qKTsKIAogICBzdGF0aWMgU3RydWN0X3R5cGUqCiAgIG1ha2Vfc3Ry dWN0X3R5cGUoU3RydWN0X2ZpZWxkX2xpc3QqIGZpZWxkcywgTG9jYXRpb24p OwpJbmRleDogZ2NjL2dvL2dvZnJvbnRlbmQvd2IuY2MKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gZ2NjL2dvL2dvZnJvbnRlbmQvd2IuY2MJKHJldmlz aW9uIDI2NTI5MykKKysrIGdjYy9nby9nb2Zyb250ZW5kL3diLmNjCSh3b3Jr aW5nIGNvcHkpCkBAIC0xODksOCArMTg5LDkgQEAgTWFya19hZGRyZXNzX3Rh a2VuOjpleHByZXNzaW9uKEV4cHJlc3NpbwogY2xhc3MgQ2hlY2tfZXNjYXBl IDogcHVibGljIFRyYXZlcnNlCiB7CiAgcHVibGljOgotICBDaGVja19lc2Nh cGUoKQotICAgIDogVHJhdmVyc2UodHJhdmVyc2VfZXhwcmVzc2lvbnMgfCB0 cmF2ZXJzZV92YXJpYWJsZXMpCisgIENoZWNrX2VzY2FwZShHb2dvKiBnb2dv KQorICAgIDogVHJhdmVyc2UodHJhdmVyc2VfZXhwcmVzc2lvbnMgfCB0cmF2 ZXJzZV92YXJpYWJsZXMpLAorICAgICAgZ29nb18oZ29nbykKICAgeyB9CiAK ICAgaW50CkBAIC0xOTgsNiArMTk5LDkgQEAgY2xhc3MgQ2hlY2tfZXNjYXBl IDogcHVibGljIFRyYXZlcnNlCiAKICAgaW50CiAgIHZhcmlhYmxlKE5hbWVk X29iamVjdCopOworCisgcHJpdmF0ZToKKyAgR29nbyogZ29nb187CiB9Owog CiBpbnQKQEAgLTYxNyw3ICs2MjEsNyBAQCBHb2dvOjphZGRfd3JpdGVfYmFy cmllcnMoKQogICAgIHsKICAgICAgIHRoaXMtPnByb3BhZ2F0ZV93cml0ZWJh cnJpZXJyZWMoKTsKIAotICAgICAgQ2hlY2tfZXNjYXBlIGNoazsKKyAgICAg IENoZWNrX2VzY2FwZSBjaGsodGhpcyk7CiAgICAgICB0aGlzLT50cmF2ZXJz ZSgmY2hrKTsKICAgICB9CiAK --0000000000009aeb67057888c94f--