From: Ian Lance Taylor <iant@google.com>
To: John Marino <gnugcc@marino.st>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
"libstdc++" <libstdc++@gcc.gnu.org>,
Binutils <binutils@sourceware.org>,
gdb-patches@sourceware.org
Subject: Re: [PING] Contributing new gcc targets: i386-*-dragonfly and x86-64-*-dragonfly
Date: Wed, 30 Apr 2014 00:07:00 -0000 [thread overview]
Message-ID: <CAKOQZ8zVX9=gcKfO0VUcq4-=T962Ji2n2h3ntBz2z5Mhz6i_Vw@mail.gmail.com> (raw)
In-Reply-To: <535FF173.2060008@marino.st>
On Tue, Apr 29, 2014 at 2:37 PM, John Marino <gnugcc@marino.st> wrote:
>
>> I don't understand the benefit of libgcc/enable-execute-stack-bsd.c.
>> The code seems the same as the existing
>> libgcc/enable-execute-stack-mprotect.c. All you are changing is
>> omitting need_enable_exec_stack. If you just drop the FreeBSD
>> constructor, you will get the behaviour you want.
>
> With the caveat that this patch is over 2 years old, I just took a look
> at both files. I would have not needed to modify this file at all for
> DragonFly. In fact, I seem to recall that I didn't modify it for
> DragonFly, but rather for FreeBSD. If I had to guess, it would be that
> I found mprotect() was needed regardless of value of kern.stackprot. I
> must have traced some test failures back to this.
>
> Which I guess that's what you mean - just delete the block between "#if
> defined __FreeBSD__" and the next #elif which should be equivalent. I
> can tweak the patch set to do that.
Yes.
> And what about the dl_iterate_phdr changes? Do they look good to you?
They looked fine to me but I'm not a build system maintainer.
Ian
next prev parent reply other threads:[~2014-04-29 23:48 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-19 19:41 John Marino
2014-04-20 19:05 ` Jonathan Wakely
2014-04-21 4:41 ` John Marino
2014-04-29 15:39 ` [PING] " John Marino
2014-04-29 17:25 ` Ian Lance Taylor
2014-04-29 18:50 ` John Marino
2014-04-30 0:07 ` Ian Lance Taylor [this message]
2014-05-01 23:03 ` Joseph S. Myers
2014-05-01 23:46 ` John Marino
2014-05-02 17:49 ` Joseph S. Myers
2014-05-02 18:17 ` John Marino
2014-05-02 20:15 ` Joseph S. Myers
2014-05-02 20:20 ` John Marino
2014-05-03 7:12 ` John Marino
2014-05-08 13:15 ` Jonathan Wakely
2014-05-08 13:32 ` Jeff Law
2014-05-08 13:36 ` John Marino
2014-05-09 5:27 ` Jeff Law
2014-05-09 7:15 ` John Marino
2014-05-12 16:59 ` Jeff Law
2014-05-12 17:10 ` John Marino
2014-05-12 17:14 ` Jeff Law
2014-05-13 14:10 ` Jonathan Wakely
2014-05-21 11:43 ` Jonathan Wakely
2015-04-09 20:12 ` [doc] Add John Marino to doc/contrib.texi (was: Contributing new gcc targets: i386-*-dragonfly and x86-64-*-dragonfly) Gerald Pfeifer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKOQZ8zVX9=gcKfO0VUcq4-=T962Ji2n2h3ntBz2z5Mhz6i_Vw@mail.gmail.com' \
--to=iant@google.com \
--cc=binutils@sourceware.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=gnugcc@marino.st \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).