From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29849 invoked by alias); 5 Mar 2013 05:31:37 -0000 Received: (qmail 29836 invoked by uid 22791); 5 Mar 2013 05:31:36 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-oa0-f46.google.com (HELO mail-oa0-f46.google.com) (209.85.219.46) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 05 Mar 2013 05:31:30 +0000 Received: by mail-oa0-f46.google.com with SMTP id k1so10279935oag.19 for ; Mon, 04 Mar 2013 21:31:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=GemhixYwOiSnOwKM0pykzxpcVgi5P2mC/ljhJodaIUs=; b=Op9d7cBkUxftrhbf71+TJeYyH7bjgTOnPiKHKeTnL8FuWv5Fp1/KJZEeXNSDb870Zm F4WRtE9lJG4XqaO5EeY5OGBKd+u3MAIZhWSBXHmoFmQcxuGc7WJjutPW32+lKg7VBLzH a6X6U2ppdviL42XGZeb0Xb/uNpss4KtH7YmuP6LSQ41Uc7I0p3dUU7iTF2z2+YAnHQIh XZAA79PSnYwdNCCt6i1e1NDja4BLQAeJ/WNodS6m7E16F8xuyMWr6+FYID2oFLk+cFnv O2j7QYs/J+Gejra3vlRnjVjEOzErot2RINkqz9ZRe9/51EhqNyO35Jc1vNlgPBurXP3O VtLg== MIME-Version: 1.0 X-Received: by 10.60.19.101 with SMTP id d5mr17077832oee.115.1362461490144; Mon, 04 Mar 2013 21:31:30 -0800 (PST) Received: by 10.182.5.137 with HTTP; Mon, 4 Mar 2013 21:31:30 -0800 (PST) In-Reply-To: <201303041911.52652.vapier@gentoo.org> References: <1356305421-13533-1-git-send-email-vapier@gentoo.org> <201301252220.39972.vapier@gentoo.org> <201303041911.52652.vapier@gentoo.org> Date: Tue, 05 Mar 2013 05:31:00 -0000 Message-ID: Subject: Re: [PATCH 1/2] [pr53679] libgo: add a --enable-werror configure flag From: Ian Lance Taylor To: Mike Frysinger Cc: gcc-patches@gcc.gnu.org, Diego Novillo Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQlZYppBEfsI9VIMpVKnCuOOHorAIu+4jDsS5hlcUatYTktroUfINvKnwaOiRo5WMIc8Fh2I3vFY84xPyToK5dD4rjQXMZu0hkKFZjDu4hWuKKFGp8mBN9bwvhPsip7QULwn0dhsPkQCpc5+8CnMyl6/xxhj1PDrRdXOlXQ+RsK6vwtPw2DC4jySlMGzVa+TnvSAmFJX X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-03/txt/msg00150.txt.bz2 On Mon, Mar 4, 2013 at 4:11 PM, Mike Frysinger wrote: > On Saturday 26 January 2013 21:40:44 Ian Lance Taylor wrote: >> On Fri, Jan 25, 2013 at 7:20 PM, Mike Frysinger wrote: >> > On Friday 25 January 2013 19:13:55 Ian Lance Taylor wrote: >> >> On Tue, Jan 15, 2013 at 9:45 AM, Mike Frysinger wrote: >> >> > On Tuesday 15 January 2013 09:56:06 Ian Lance Taylor wrote: >> >> >> On Sun, Dec 23, 2012 at 3:30 PM, Mike Frysinger wrote: >> >> >> > diff --git a/libgo/configure.ac b/libgo/configure.ac >> >> >> > index 8cde50b..63d8cbc 100644 >> >> >> > --- a/libgo/configure.ac >> >> >> > +++ b/libgo/configure.ac >> >> >> > @@ -50,8 +50,11 @@ AC_PROG_AWK >> >> >> > >> >> >> > WARN_FLAGS='-Wall -Wextra -Wwrite-strings -Wcast-qual' >> >> >> > AC_SUBST(WARN_FLAGS) >> >> >> > >> >> >> > -dnl FIXME: This should be controlled by --enable-maintainer-mode. >> >> >> > -WERROR="-Werror" >> >> >> > +AC_ARG_ENABLE(werror, [AS_HELP_STRING([--enable-werror], >> >> >> > + [turns on -Werror >> >> >> > @<:@default=yes@:>@])]) +if test "x$enable_werror" != "xno"; then >> >> >> > + WERROR="-Werror" >> >> >> > +fi >> >> >> > >> >> >> > AC_SUBST(WERROR) >> >> >> > >> >> >> > glibgo_toolexecdir=no >> >> >> >> >> >> Can you say something about when you needed this? What errors were >> >> >> you seeing? >> >> > >> >> > the referenced PR describes one: >> >> > /build/src/gcc-4.7.1/libgo/runtime/print.c: In function 'gwrite': >> >> > /build/src/gcc-4.7.1/libgo/runtime/print.c:20:3: error: ignoring >> >> > return value of 'write', declared with attribute warn_unused_result >> >> > [-Werror=unused-result] cc1: all warnings being treated as errors >> >> > >> >> > this bites distros that enable security settings by default (such as >> >> > fortify and ssp). but ignoring even that, i don't believe releases >> >> > should build all the time with -Werror -- i'm fine with defaulting to >> >> > on as long as there is a configure flag to turn it off which is what >> >> > this does like is already handled in much of the sourceware tree. >> >> > -Werror is great for development, but sucks when deployed on actual >> >> > systems. the assumptions made at time of checkin rarely stay >> >> > constant forever (in this case, a changing lib C can easily break >> >> > it). -mike >> >> >> >> Thanks for the explanation. >> >> >> >> Committed to mainline. >> > >> > thanks! mind if i commit it to gcc-4.6 and gcc-4.7 too ? >> >> I certainly don't mind. You should probably get agreement from the >> release managers although this seems safe enough. > > can you approve merges to the google branches ? that's really where i want > this :). No, I don't work on those branches. Sorry. CC'ed dnovillo@google.com. Ian