From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1703 invoked by alias); 15 Jan 2013 14:56:13 -0000 Received: (qmail 1693 invoked by uid 22791); 15 Jan 2013 14:56:13 -0000 X-SWARE-Spam-Status: No, hits=-4.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD,URIBL_BLACK X-Spam-Check-By: sourceware.org Received: from mail-oa0-f42.google.com (HELO mail-oa0-f42.google.com) (209.85.219.42) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Jan 2013 14:56:07 +0000 Received: by mail-oa0-f42.google.com with SMTP id j1so198224oag.15 for ; Tue, 15 Jan 2013 06:56:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-gm-message-state; bh=Ov09sSQQOwa6kmDtqQ0ikc1D1jp0UFxgQsr6ZTE37Wo=; b=IQT2q29o8yRSm8zfGbYIvDfz0uc6hhZuyqhyuULXqabv71zet+MLG5UeSLWqMErgfh mszBeG7CRJe/QLgUayH5PUkTu8MV+TEbvBXpSbVSz31YB1sDNeZhjooTmKMFpq8xiaNK Wk339ZtscQE1LVZdHsodGl8G/Obyns6yVVpw7zXxVi5oJFIaOog0aPQHvxjsL43ZC6h7 TOXAdq44tucWDYwxgiZ76h+0R+vDT6oKnpANr608Pcz2GFah5w5ZQnRFqtbpd80MpCii I0j9wbaEOUy5LpvIlH/4DBfvk93zoAPoSwqlZAEoRLxG+cO28vhyE4/UMsKZ24RdqqpF 8FZg== MIME-Version: 1.0 Received: by 10.60.2.103 with SMTP id 7mr56026478oet.79.1358261766762; Tue, 15 Jan 2013 06:56:06 -0800 (PST) Received: by 10.182.88.36 with HTTP; Tue, 15 Jan 2013 06:56:06 -0800 (PST) In-Reply-To: <1356305421-13533-1-git-send-email-vapier@gentoo.org> References: <1356305421-13533-1-git-send-email-vapier@gentoo.org> Date: Tue, 15 Jan 2013 14:56:00 -0000 Message-ID: Subject: Re: [PATCH 1/2] [pr53679] libgo: add a --enable-werror configure flag From: Ian Lance Taylor To: Mike Frysinger Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQlvCeDUJay6vZrssfWoDYUidmTH1MxHjcDGdxU+UNa3OpqdTXiKqT9JoZTbQqM0i39+sAaKwipxCr1I+zQ98H8Vii6+wXKQKM2lPU6UTFMYOzUvFqBCgGO7ccLHMYlp4RNFvNy2Zlr6Cygw6px+q4gkj1FtK+lzjvXEsz1rxi+QErAymgRa2xgEk3Atp52DFZyXO5G3 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-01/txt/msg00781.txt.bz2 On Sun, Dec 23, 2012 at 3:30 PM, Mike Frysinger wrote: > diff --git a/libgo/configure.ac b/libgo/configure.ac > index 8cde50b..63d8cbc 100644 > --- a/libgo/configure.ac > +++ b/libgo/configure.ac > @@ -50,8 +50,11 @@ AC_PROG_AWK > WARN_FLAGS='-Wall -Wextra -Wwrite-strings -Wcast-qual' > AC_SUBST(WARN_FLAGS) > > -dnl FIXME: This should be controlled by --enable-maintainer-mode. > -WERROR="-Werror" > +AC_ARG_ENABLE(werror, [AS_HELP_STRING([--enable-werror], > + [turns on -Werror @<:@default=yes@:>@])]) > +if test "x$enable_werror" != "xno"; then > + WERROR="-Werror" > +fi > AC_SUBST(WERROR) > > glibgo_toolexecdir=no Can you say something about when you needed this? What errors were you seeing? Ian