From: "Ian Lance Taylor via gcc-patches" <gcc-patches@gcc.gnu.org>
To: Rainer Orth <ro@cebitec.uni-bielefeld.de>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, gofrontend-dev@googlegroups.com
Subject: Re: [build, libgcc, libgo] Adapt Solaris 12 references
Date: Tue, 14 Nov 2017 15:40:00 -0000 [thread overview]
Message-ID: <CAKOQZ8zwtsH_vPVTZ6n1wVsvinN1kPkPYwTP5Aygsd0y97=nhQ@mail.gmail.com> (raw)
In-Reply-To: <yddzi7p2muf.fsf@CeBiTec.Uni-Bielefeld.DE>
On Tue, Nov 14, 2017 at 2:09 AM, Rainer Orth
<ro@cebitec.uni-bielefeld.de> wrote:
>
>> With the change in the Solaris release model (no more major releases
>> like Solaris 12 but only minor ones like 11.4), the Solaris 12
>> references in GCC need to be adapted.
>>
>> The following patch does this, consisting mostly of comment changes.
>>
>> Only a few changes bear comment:
>>
>> * Solaris 11.4 introduced __cxa_atexit, so we have to enable it on
>> *-*-solaris2.11. Not a problem for native builds which check for the
>> actual availability of the function.
>>
>> * gcc.dg/torture/pr60092.c was xfailed on *-*-solaris2.11*, but the
>> underlying bug was fixed in Solaris 12/11.4. However, now 11.3 and
>> 11.4 have the same configure triplet. To avoid noise on the newest
>> release, I've removed the xfail.
>>
>> I've left a few references to Solaris 12 builds in
>> libstdc++-v3/acinclude.m4 because those hadn't been renamed
>> retroactively, of course.
>>
>> install.texi needs some work, too, but I'll address this separately
>> because there's more than just the version change.
>>
>> Bootstrapped without regressions on {i386-pc, sparc-sun}-solaris2.1[01]
>> (both Solaris 11.3 and 11.4). I believe I need approval only for the
>> libgo parts.
>
> how should we proceed with the libgo part of this patch? I can checkin
> the rest (which contains functional changes) now and omit the libgo
> part (either for now or completely, given that it consists only of
> comment changes).
Sorry, I've fallen behind a bit on gccgo/libgo patch review. I've now
committed your patch to libgo trunk.
>> I'm going to backport the patch to the gcc-7 and gcc-6 branches after a
>> bit of soak time.
>
> What's the procedure for libgo here? IIUC, only the trunk version of
> libgo is imported from upstream, while changes to branches can go in
> directly.
That is correct. Backporting gcc/go/gofrontend and libgo patches to
release branches is always fine with me if the release managers are OK
with it.
Ian
next prev parent reply other threads:[~2017-11-14 14:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 10:18 Rainer Orth
2017-11-14 10:43 ` Rainer Orth
2017-11-14 15:40 ` Ian Lance Taylor via gcc-patches [this message]
2017-11-15 9:54 ` Rainer Orth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKOQZ8zwtsH_vPVTZ6n1wVsvinN1kPkPYwTP5Aygsd0y97=nhQ@mail.gmail.com' \
--to=gcc-patches@gcc.gnu.org \
--cc=gofrontend-dev@googlegroups.com \
--cc=iant@google.com \
--cc=ro@cebitec.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).