[testsuite] Adding target nonpic to certain tests part. 2

[testsuite] Adding target nonpic to certain tests part. 2

[Alexander Ivchenko]

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

Hi,

Another bunch of tests that fails with -fpic.

from here: http://gcc.gnu.org/ml/gcc-patches/2013-01/msg00539.html
"Since -fpic option is turned on by default in Android we have certain test
fails. The reason for that is that those tests rely on the
availability of functions, defined in them
and with -fpic compiler conservatively assumes that they are
AVAIL_OVERWRITABLE."

 I added {target nonpic} to them as before.


Is it ok for trunk?


thanks,
Alexander

[-- Attachment #2: add_target_nonpic.patch --]
[-- Type: application/octet-stream, Size: 2837 bytes --]

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index d0f01c8..b150ea3 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,12 @@
+2013-06-05  Alexander Ivchenko  <alexander.ivchenko@intel.com>
+
+	* g++.dg/pr48484.C: Add target nonpic.
+	* gcc.dg/ipa/inline-4.c: Ditto.
+	* gcc.dg/ipa/inlinehint-1.c: Ditto.
+	* gcc.dg/ipa/inlinehint-2.c: Ditto.
+	* gcc.dg/ipa/inlinehint-3.c: Ditto.
+	* gcc.dg/tm/nested-2.c: Ditto.
+
 2013-05-27  Richard Biener  <rguenther@suse.de>
 
 	PR tree-optimization/57396
diff --git a/gcc/testsuite/g++.dg/pr48484.C b/gcc/testsuite/g++.dg/pr48484.C
index 3f17f39..7dad697 100644
--- a/gcc/testsuite/g++.dg/pr48484.C
+++ b/gcc/testsuite/g++.dg/pr48484.C
@@ -1,4 +1,4 @@
-/* { dg-do compile } */
+/* { dg-do compile { target nonpic } } */
 /* { dg-options "-O -finline-functions -finline-small-functions -Wuninitialized" }  */
 
 
diff --git a/gcc/testsuite/gcc.dg/ipa/inline-4.c b/gcc/testsuite/gcc.dg/ipa/inline-4.c
index 66019b3..f193051 100644
--- a/gcc/testsuite/gcc.dg/ipa/inline-4.c
+++ b/gcc/testsuite/gcc.dg/ipa/inline-4.c
@@ -1,4 +1,4 @@
-/* { dg-do compile } */
+/* { dg-do compile { target nonpic} } */
 /* { dg-options "-Os -c -fdump-ipa-inline -fno-early-inlining -fno-partial-inlining -fno-ipa-cp"  } */
 
 void do_something (int shall_i_work)
diff --git a/gcc/testsuite/gcc.dg/ipa/inlinehint-1.c b/gcc/testsuite/gcc.dg/ipa/inlinehint-1.c
index 9810e25..a10adf7 100644
--- a/gcc/testsuite/gcc.dg/ipa/inlinehint-1.c
+++ b/gcc/testsuite/gcc.dg/ipa/inlinehint-1.c
@@ -1,3 +1,4 @@
+/* { dg-require-effective-target nonpic } */
 /* { dg-options "-O3 -c -fdump-ipa-inline-details -fno-early-inlining -fno-ipa-cp"  } */
 test (int a)
 {
diff --git a/gcc/testsuite/gcc.dg/ipa/inlinehint-2.c b/gcc/testsuite/gcc.dg/ipa/inlinehint-2.c
index a06d725..2cd4a08 100644
--- a/gcc/testsuite/gcc.dg/ipa/inlinehint-2.c
+++ b/gcc/testsuite/gcc.dg/ipa/inlinehint-2.c
@@ -1,3 +1,4 @@
+/* { dg-require-effective-target nonpic } */
 /* { dg-options "-O3 -c -fdump-ipa-inline-details -fno-early-inlining -fno-ipa-cp"  } */
 t(int s, void **p)
 {
diff --git a/gcc/testsuite/gcc.dg/ipa/inlinehint-3.c b/gcc/testsuite/gcc.dg/ipa/inlinehint-3.c
index 110ae44..21728d7 100644
--- a/gcc/testsuite/gcc.dg/ipa/inlinehint-3.c
+++ b/gcc/testsuite/gcc.dg/ipa/inlinehint-3.c
@@ -1,3 +1,4 @@
+/* { dg-require-effective-target nonpic } */
 /* { dg-options "-O3 -c -fdump-ipa-inline-details -fno-early-inlining -fno-ipa-cp"  } */
 void abort (void);
 int sum;
diff --git a/gcc/testsuite/gcc.dg/tm/nested-2.c b/gcc/testsuite/gcc.dg/tm/nested-2.c
index 205ca8d..6816d9f 100644
--- a/gcc/testsuite/gcc.dg/tm/nested-2.c
+++ b/gcc/testsuite/gcc.dg/tm/nested-2.c
@@ -1,4 +1,4 @@
-/* { dg-do compile } */
+/* { dg-do compile { target nonpic } } */
 /* { dg-options "-fgnu-tm" } */
 
 void foobar(void)

Re: [testsuite] Adding target nonpic to certain tests part. 2

[Patrick Marlier]

[-- Attachment #1: Type: text/plain, Size: 764 bytes --]

Hi Alexander,

At least for TM testcase, I would prefer to add 'transaction_safe'
attribute on foobar as in the attached patch.
Aldy and Richard H: What do you think?

Thanks,
--
Patrick

On Wed, Jun 5, 2013 at 1:13 PM, Alexander Ivchenko <aivchenk@gmail.com> wrote:
> Hi,
>
> Another bunch of tests that fails with -fpic.
>
> from here: http://gcc.gnu.org/ml/gcc-patches/2013-01/msg00539.html
> "Since -fpic option is turned on by default in Android we have certain test
> fails. The reason for that is that those tests rely on the
> availability of functions, defined in them
> and with -fpic compiler conservatively assumes that they are
> AVAIL_OVERWRITABLE."
>
>  I added {target nonpic} to them as before.
>
>
> Is it ok for trunk?
>
>
> thanks,
> Alexander

[-- Attachment #2: tm-nested-2.patch --]
[-- Type: application/octet-stream, Size: 403 bytes --]

Index: gcc/testsuite/gcc.dg/tm/nested-2.c
===================================================================
--- gcc/testsuite/gcc.dg/tm/nested-2.c	(revision 198341)
+++ gcc/testsuite/gcc.dg/tm/nested-2.c	(working copy)
@@ -1,6 +1,8 @@
 /* { dg-do compile } */
 /* { dg-options "-fgnu-tm" } */
 
+void foobar(void) __attribute__((transaction_safe));
+
 void foobar(void)
 {
     __transaction_atomic {

Re: [testsuite] Adding target nonpic to certain tests part. 2

[Alexander Ivchenko]

[-- Attachment #1: Type: text/plain, Size: 940 bytes --]

Yep, that also works for us. I updated the patch. Is it ok for trunk?

--Alexander

2013/6/5 Patrick Marlier <patrick.marlier@gmail.com>:
> Hi Alexander,
>
> At least for TM testcase, I would prefer to add 'transaction_safe'
> attribute on foobar as in the attached patch.
> Aldy and Richard H: What do you think?
>
> Thanks,
> --
> Patrick
>
> On Wed, Jun 5, 2013 at 1:13 PM, Alexander Ivchenko <aivchenk@gmail.com> wrote:
>> Hi,
>>
>> Another bunch of tests that fails with -fpic.
>>
>> from here: http://gcc.gnu.org/ml/gcc-patches/2013-01/msg00539.html
>> "Since -fpic option is turned on by default in Android we have certain test
>> fails. The reason for that is that those tests rely on the
>> availability of functions, defined in them
>> and with -fpic compiler conservatively assumes that they are
>> AVAIL_OVERWRITABLE."
>>
>>  I added {target nonpic} to them as before.
>>
>>
>> Is it ok for trunk?
>>
>>
>> thanks,
>> Alexander

[-- Attachment #2: add_target_nonpic_02.patch --]
[-- Type: application/octet-stream, Size: 3238 bytes --]

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 611404d..b5ff90f 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,8 +1,17 @@
+2013-06-11  Alexander Ivchenko  <alexander.ivchenko@intel.com>
+
+	* g++.dg/pr48484.C: Add target nonpic.
+	* gcc.dg/ipa/inline-4.c: Ditto.
+	* gcc.dg/ipa/inlinehint-1.c: Ditto.
+	* gcc.dg/ipa/inlinehint-2.c: Ditto.
+	* gcc.dg/ipa/inlinehint-3.c: Ditto.
+	* gcc.dg/tm/nested-2.c: : Declare foobar as transaction_safe.
+
 2013-06-10  Balaji V. Iyer  <balaji.v.iyer@intel.com>
 
 	PR c/57563
 	* c-c++-common/cilk-plus/AN/builtin_fn_mutating.c (main): Fixed a bug
-	in how we check __sec_reduce_mutating function's result.	
+	in how we check __sec_reduce_mutating function's result.
 
 2013-06-10  Michael Meissner  <meissner@linux.vnet.ibm.com>
 	    Pat Haugen <pthaugen@us.ibm.com>
diff --git a/gcc/testsuite/g++.dg/pr48484.C b/gcc/testsuite/g++.dg/pr48484.C
index 3f17f39..7dad697 100644
--- a/gcc/testsuite/g++.dg/pr48484.C
+++ b/gcc/testsuite/g++.dg/pr48484.C
@@ -1,4 +1,4 @@
-/* { dg-do compile } */
+/* { dg-do compile { target nonpic } } */
 /* { dg-options "-O -finline-functions -finline-small-functions -Wuninitialized" }  */
 
 
diff --git a/gcc/testsuite/gcc.dg/ipa/inline-4.c b/gcc/testsuite/gcc.dg/ipa/inline-4.c
index 66019b3..f193051 100644
--- a/gcc/testsuite/gcc.dg/ipa/inline-4.c
+++ b/gcc/testsuite/gcc.dg/ipa/inline-4.c
@@ -1,4 +1,4 @@
-/* { dg-do compile } */
+/* { dg-do compile { target nonpic} } */
 /* { dg-options "-Os -c -fdump-ipa-inline -fno-early-inlining -fno-partial-inlining -fno-ipa-cp"  } */
 
 void do_something (int shall_i_work)
diff --git a/gcc/testsuite/gcc.dg/ipa/inlinehint-1.c b/gcc/testsuite/gcc.dg/ipa/inlinehint-1.c
index 9810e25..a10adf7 100644
--- a/gcc/testsuite/gcc.dg/ipa/inlinehint-1.c
+++ b/gcc/testsuite/gcc.dg/ipa/inlinehint-1.c
@@ -1,3 +1,4 @@
+/* { dg-require-effective-target nonpic } */
 /* { dg-options "-O3 -c -fdump-ipa-inline-details -fno-early-inlining -fno-ipa-cp"  } */
 test (int a)
 {
diff --git a/gcc/testsuite/gcc.dg/ipa/inlinehint-2.c b/gcc/testsuite/gcc.dg/ipa/inlinehint-2.c
index a06d725..2cd4a08 100644
--- a/gcc/testsuite/gcc.dg/ipa/inlinehint-2.c
+++ b/gcc/testsuite/gcc.dg/ipa/inlinehint-2.c
@@ -1,3 +1,4 @@
+/* { dg-require-effective-target nonpic } */
 /* { dg-options "-O3 -c -fdump-ipa-inline-details -fno-early-inlining -fno-ipa-cp"  } */
 t(int s, void **p)
 {
diff --git a/gcc/testsuite/gcc.dg/ipa/inlinehint-3.c b/gcc/testsuite/gcc.dg/ipa/inlinehint-3.c
index 110ae44..21728d7 100644
--- a/gcc/testsuite/gcc.dg/ipa/inlinehint-3.c
+++ b/gcc/testsuite/gcc.dg/ipa/inlinehint-3.c
@@ -1,3 +1,4 @@
+/* { dg-require-effective-target nonpic } */
 /* { dg-options "-O3 -c -fdump-ipa-inline-details -fno-early-inlining -fno-ipa-cp"  } */
 void abort (void);
 int sum;
diff --git a/gcc/testsuite/gcc.dg/tm/nested-2.c b/gcc/testsuite/gcc.dg/tm/nested-2.c
index 205ca8d..42a4341 100644
--- a/gcc/testsuite/gcc.dg/tm/nested-2.c
+++ b/gcc/testsuite/gcc.dg/tm/nested-2.c
@@ -1,6 +1,8 @@
-/* { dg-do compile } */
+/* { dg-do compile { target nonpic } } */
 /* { dg-options "-fgnu-tm" } */
 
+void foobar(void) __attribute__((transaction_safe));
+
 void foobar(void)
 {
     __transaction_atomic {

Re: [testsuite] Adding target nonpic to certain tests part. 2

[Alexander Ivchenko]

[-- Attachment #1: Type: text/plain, Size: 1703 bytes --]

*Ping*

>>> Another bunch of tests that fails with -fpic.
>>>
>>> from here: http://gcc.gnu.org/ml/gcc-patches/2013-01/msg00539.html
>>> "Since -fpic option is turned on by default in Android we have certain test
>>> fails. The reason for that is that those tests rely on the
>>> availability of functions, defined in them
>>> and with -fpic compiler conservatively assumes that they are
>>> AVAIL_OVERWRITABLE."
>>>
>>>  I added {target nonpic} to them as before.

Is the attached patch ok?

We already did that for some tests before here:
http://gcc.gnu.org/ml/gcc-patches/2013-03/msg00975.html
So, considering that, it should be a pretty obvious fix.

thanks,
Alexander

2013/6/11 Alexander Ivchenko <aivchenk@gmail.com>:
> Yep, that also works for us. I updated the patch. Is it ok for trunk?
>
> --Alexander
>
> 2013/6/5 Patrick Marlier <patrick.marlier@gmail.com>:
>> Hi Alexander,
>>
>> At least for TM testcase, I would prefer to add 'transaction_safe'
>> attribute on foobar as in the attached patch.
>> Aldy and Richard H: What do you think?
>>
>> Thanks,
>> --
>> Patrick
>>
>> On Wed, Jun 5, 2013 at 1:13 PM, Alexander Ivchenko <aivchenk@gmail.com> wrote:
>>> Hi,
>>>
>>> Another bunch of tests that fails with -fpic.
>>>
>>> from here: http://gcc.gnu.org/ml/gcc-patches/2013-01/msg00539.html
>>> "Since -fpic option is turned on by default in Android we have certain test
>>> fails. The reason for that is that those tests rely on the
>>> availability of functions, defined in them
>>> and with -fpic compiler conservatively assumes that they are
>>> AVAIL_OVERWRITABLE."
>>>
>>>  I added {target nonpic} to them as before.
>>>
>>>
>>> Is it ok for trunk?
>>>
>>>
>>> thanks,
>>> Alexander

[-- Attachment #2: add_target_nonpic_03.patch --]
[-- Type: application/octet-stream, Size: 4334 bytes --]

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 8de216f..60bd85f 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,15 @@
+2013-07-08  Alexander Ivchenko  <alexander.ivchenko@intel.com>
+
+	* g++.dg/pr48484.C: Add target nonpic.
+	* gcc.dg/ipa/inline-4.c: Ditto.
+	* gcc.dg/ipa/inlinehint-1.c: Ditto.
+	* gcc.dg/ipa/inlinehint-2.c: Ditto.
+	* gcc.dg/ipa/inlinehint-3.c: Ditto.
+	* gcc.target/i386/pad-10.c: Ditto.
+	* gcc.target/i386/sse-23.c: Ditto.
+	* gcc.target/i386/sse-24.c: Ditto.
+	* gcc.dg/tm/nested-2.c: Declare foobar as transaction_safe.
+
 2013-07-08  Jakub Jelinek  <jakub@redhat.com>
 
 	PR target/57819
diff --git a/gcc/testsuite/g++.dg/pr48484.C b/gcc/testsuite/g++.dg/pr48484.C
index 3f17f39..7dad697 100644
--- a/gcc/testsuite/g++.dg/pr48484.C
+++ b/gcc/testsuite/g++.dg/pr48484.C
@@ -1,4 +1,4 @@
-/* { dg-do compile } */
+/* { dg-do compile { target nonpic } } */
 /* { dg-options "-O -finline-functions -finline-small-functions -Wuninitialized" }  */
 
 
diff --git a/gcc/testsuite/gcc.dg/ipa/inline-4.c b/gcc/testsuite/gcc.dg/ipa/inline-4.c
index 66019b3..22a856e 100644
--- a/gcc/testsuite/gcc.dg/ipa/inline-4.c
+++ b/gcc/testsuite/gcc.dg/ipa/inline-4.c
@@ -1,4 +1,4 @@
-/* { dg-do compile } */
+/* { dg-do compile { target nonpic } } */
 /* { dg-options "-Os -c -fdump-ipa-inline -fno-early-inlining -fno-partial-inlining -fno-ipa-cp"  } */
 
 void do_something (int shall_i_work)
diff --git a/gcc/testsuite/gcc.dg/ipa/inlinehint-1.c b/gcc/testsuite/gcc.dg/ipa/inlinehint-1.c
index 9810e25..a10adf7 100644
--- a/gcc/testsuite/gcc.dg/ipa/inlinehint-1.c
+++ b/gcc/testsuite/gcc.dg/ipa/inlinehint-1.c
@@ -1,3 +1,4 @@
+/* { dg-require-effective-target nonpic } */
 /* { dg-options "-O3 -c -fdump-ipa-inline-details -fno-early-inlining -fno-ipa-cp"  } */
 test (int a)
 {
diff --git a/gcc/testsuite/gcc.dg/ipa/inlinehint-2.c b/gcc/testsuite/gcc.dg/ipa/inlinehint-2.c
index a06d725..2cd4a08 100644
--- a/gcc/testsuite/gcc.dg/ipa/inlinehint-2.c
+++ b/gcc/testsuite/gcc.dg/ipa/inlinehint-2.c
@@ -1,3 +1,4 @@
+/* { dg-require-effective-target nonpic } */
 /* { dg-options "-O3 -c -fdump-ipa-inline-details -fno-early-inlining -fno-ipa-cp"  } */
 t(int s, void **p)
 {
diff --git a/gcc/testsuite/gcc.dg/ipa/inlinehint-3.c b/gcc/testsuite/gcc.dg/ipa/inlinehint-3.c
index 110ae44..21728d7 100644
--- a/gcc/testsuite/gcc.dg/ipa/inlinehint-3.c
+++ b/gcc/testsuite/gcc.dg/ipa/inlinehint-3.c
@@ -1,3 +1,4 @@
+/* { dg-require-effective-target nonpic } */
 /* { dg-options "-O3 -c -fdump-ipa-inline-details -fno-early-inlining -fno-ipa-cp"  } */
 void abort (void);
 int sum;
diff --git a/gcc/testsuite/gcc.dg/tm/nested-2.c b/gcc/testsuite/gcc.dg/tm/nested-2.c
index 205ca8d..7b4003b 100644
--- a/gcc/testsuite/gcc.dg/tm/nested-2.c
+++ b/gcc/testsuite/gcc.dg/tm/nested-2.c
@@ -1,6 +1,8 @@
 /* { dg-do compile } */
 /* { dg-options "-fgnu-tm" } */
 
+void foobar(void) __attribute__((transaction_safe));
+
 void foobar(void)
 {
     __transaction_atomic {
diff --git a/gcc/testsuite/gcc.target/i386/pad-10.c b/gcc/testsuite/gcc.target/i386/pad-10.c
index cd65041..e421174 100644
--- a/gcc/testsuite/gcc.target/i386/pad-10.c
+++ b/gcc/testsuite/gcc.target/i386/pad-10.c
@@ -1,4 +1,4 @@
-/* { dg-do compile } */
+/* { dg-do compile { target nonpic } } */
 /* { dg-skip-if "" { i?86-*-* x86_64-*-* } { "-march=*" } { "-march=atom" } } */
 /* { dg-options "-O2 -fomit-frame-pointer -march=atom" } */
 /* { dg-final { scan-assembler-not "nop" } } */
diff --git a/gcc/testsuite/gcc.target/i386/sse-23.c b/gcc/testsuite/gcc.target/i386/sse-23.c
index 069f8e7..7b816a9 100644
--- a/gcc/testsuite/gcc.target/i386/sse-23.c
+++ b/gcc/testsuite/gcc.target/i386/sse-23.c
@@ -1,4 +1,4 @@
-/* { dg-do compile } */
+/* { dg-do compile { target nonpic } } */
 /* { dg-options "-O2 -Werror-implicit-function-declaration -march=k8" } */
 
 #include <mm_malloc.h>
diff --git a/gcc/testsuite/gcc.target/i386/sse-24.c b/gcc/testsuite/gcc.target/i386/sse-24.c
index daeb968..4c2cfcf 100644
--- a/gcc/testsuite/gcc.target/i386/sse-24.c
+++ b/gcc/testsuite/gcc.target/i386/sse-24.c
@@ -1,5 +1,5 @@
 /* PR target/44338 */
-/* { dg-do compile } */
+/* { dg-do compile { target nonpic } } */
 /* { dg-options "-O2 -Werror-implicit-function-declaration -march=k8 -ffp-contract=off" } */
 
 #include "sse-23.c"

Re: [testsuite] Adding target nonpic to certain tests part. 2

[Alexander Ivchenko]

*Ping*

Richard, you approved adding "target nonpic" last time, could you
please take quick a look?

I regularly encounter failing due to "AVAIL_OVERWRITABLE" tests on
Android.. When people write tests they don't consider pic targets.

thanks,
Alexander

2013/7/8 Alexander Ivchenko <aivchenk@gmail.com>:
> *Ping*
>
>>>> Another bunch of tests that fails with -fpic.
>>>>
>>>> from here: http://gcc.gnu.org/ml/gcc-patches/2013-01/msg00539.html
>>>> "Since -fpic option is turned on by default in Android we have certain test
>>>> fails. The reason for that is that those tests rely on the
>>>> availability of functions, defined in them
>>>> and with -fpic compiler conservatively assumes that they are
>>>> AVAIL_OVERWRITABLE."
>>>>
>>>>  I added {target nonpic} to them as before.
>
> Is the attached patch ok?
>
> We already did that for some tests before here:
> http://gcc.gnu.org/ml/gcc-patches/2013-03/msg00975.html
> So, considering that, it should be a pretty obvious fix.
>
> thanks,
> Alexander
>
> 2013/6/11 Alexander Ivchenko <aivchenk@gmail.com>:
>> Yep, that also works for us. I updated the patch. Is it ok for trunk?
>>
>> --Alexander
>>
>> 2013/6/5 Patrick Marlier <patrick.marlier@gmail.com>:
>>> Hi Alexander,
>>>
>>> At least for TM testcase, I would prefer to add 'transaction_safe'
>>> attribute on foobar as in the attached patch.
>>> Aldy and Richard H: What do you think?
>>>
>>> Thanks,
>>> --
>>> Patrick
>>>
>>> On Wed, Jun 5, 2013 at 1:13 PM, Alexander Ivchenko <aivchenk@gmail.com> wrote:
>>>> Hi,
>>>>
>>>> Another bunch of tests that fails with -fpic.
>>>>
>>>> from here: http://gcc.gnu.org/ml/gcc-patches/2013-01/msg00539.html
>>>> "Since -fpic option is turned on by default in Android we have certain test
>>>> fails. The reason for that is that those tests rely on the
>>>> availability of functions, defined in them
>>>> and with -fpic compiler conservatively assumes that they are
>>>> AVAIL_OVERWRITABLE."
>>>>
>>>>  I added {target nonpic} to them as before.
>>>>
>>>>
>>>> Is it ok for trunk?
>>>>
>>>>
>>>> thanks,
>>>> Alexander