public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Bruce Korb <bkorb@gnu.org>
To: David Edelsohn <dje.gcc@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] AIX fixincludes for pthread.h
Date: Tue, 08 Nov 2011 17:01:00 -0000	[thread overview]
Message-ID: <CAKRnqN+zdUhkfuJk6_UMyfUrPG4oB-uS4pAyXL9vPcH3ECSrnw@mail.gmail.com> (raw)
In-Reply-To: <CAGWvnynRQ4OPvZci+ohtF=hXkQtK4Fmn0htQhD9006uzxjjX3g@mail.gmail.com>

On Mon, Nov 7, 2011 at 12:59 PM, David Edelsohn <dje.gcc@gmail.com> wrote:
> Okay?

Well, okay, but I'd prefer one fix something like the following (and I confess
I've not had any test time...) because it looks simpler to me:

/*
 *  pthread.h on AIX defines PTHREAD_ONCE_INIT without enough braces.
 *  Rewrite the define as a dual define with the original name now containing
 *  the missing braces.
 */
fix = {
    hackname  = aix_once_init;
    mach      = "*-*-aix*";
    files     = "pthread.h";
    select    = "(#define[ \t]+)(PTHREAD_ONCE_INIT)( \\\\\n"
		"\\{)";

    c_fix       = format;
    c_fix_arg = "%1%2 { %2_INTERNAL }\n%1%2_INTERNAL%3";

    test_text = <<- _EOF_
	#if FUMBLE
	#define PTHREAD_ONCE_INIT \
	{ \
	       ... _PTH_FLAGS_INIT64, \
	}
	#else
	#define PTHREAD_ONCE_INIT \
	{ \
	       ... 2, \
	}
	#endif
	_EOF_;
};

  reply	other threads:[~2011-11-08 16:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-07 21:04 David Edelsohn
2011-11-08 17:01 ` Bruce Korb [this message]
2011-11-08 17:26   ` David Edelsohn
2011-11-08 18:33   ` David Edelsohn
2011-11-08 19:18     ` Bruce Korb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKRnqN+zdUhkfuJk6_UMyfUrPG4oB-uS4pAyXL9vPcH3ECSrnw@mail.gmail.com \
    --to=bkorb@gnu.org \
    --cc=dje.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).