* [PATCH] Fix fixinclude common/non-common mix
@ 2013-01-14 14:43 Richard Biener
2013-01-14 14:47 ` Bruce Korb
0 siblings, 1 reply; 2+ messages in thread
From: Richard Biener @ 2013-01-14 14:43 UTC (permalink / raw)
To: gcc-patches
fixincludes mixes common declarations (in fixlib.h) and non-common
decls (where they are defined) for verbose_level and fixinc_mode.
XCode on Mountain Lion doesn't like this and its linker (rightfully)
complains.
Fixed with the following, committed as obvious.
Richard.
2013-01-14 Richard Biener <rguenther@suse.de>
* fixlib.h (verbose_level, fixinc_mode): Mark extern.
Index: fixincludes/fixlib.h
===================================================================
--- fixincludes/fixlib.h (revision 195140)
+++ fixincludes/fixlib.h (working copy)
@@ -223,7 +223,7 @@ typedef enum {
VERB_EVERYTHING
} te_verbose;
-te_verbose verbose_level;
+extern te_verbose verbose_level;
#define VLEVEL(l) ((unsigned int) verbose_level >= (unsigned int) l)
#define NOT_SILENT VLEVEL(VERB_FIXES)
@@ -233,7 +233,7 @@ typedef enum {
TESTING_ON = 1
} fixinc_mode_t;
-fixinc_mode_t fixinc_mode;
+extern fixinc_mode_t fixinc_mode;
#ifdef HAVE_MMAP_FILE
#define UNLOAD_DATA() do { if (curr_data_mapped) { \
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix fixinclude common/non-common mix
2013-01-14 14:43 [PATCH] Fix fixinclude common/non-common mix Richard Biener
@ 2013-01-14 14:47 ` Bruce Korb
0 siblings, 0 replies; 2+ messages in thread
From: Bruce Korb @ 2013-01-14 14:47 UTC (permalink / raw)
To: Richard Biener; +Cc: gcc-patches
Hi,
On Mon, Jan 14, 2013 at 12:42 AM, Richard Biener <rguenther@suse.de> wrote:
>
> fixincludes mixes common declarations (in fixlib.h) and non-common
> decls (where they are defined) for verbose_level and fixinc_mode.
> XCode on Mountain Lion doesn't like this and its linker (rightfully)
> complains.
It is not rightful that it complain, but it is rightful to accommodate
it. "approved."
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-14 14:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-14 14:43 [PATCH] Fix fixinclude common/non-common mix Richard Biener
2013-01-14 14:47 ` Bruce Korb
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).