From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8629 invoked by alias); 14 Jan 2013 14:47:58 -0000 Received: (qmail 8621 invoked by uid 22791); 14 Jan 2013 14:47:55 -0000 X-SWARE-Spam-Status: No, hits=-5.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-la0-f41.google.com (HELO mail-la0-f41.google.com) (209.85.215.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Jan 2013 14:47:43 +0000 Received: by mail-la0-f41.google.com with SMTP id em20so3949855lab.14 for ; Mon, 14 Jan 2013 06:47:42 -0800 (PST) Received: by 10.112.25.198 with SMTP id e6mr35809641lbg.63.1358174862217; Mon, 14 Jan 2013 06:47:42 -0800 (PST) MIME-Version: 1.0 Received: by 10.112.10.197 with HTTP; Mon, 14 Jan 2013 06:47:22 -0800 (PST) In-Reply-To: References: From: Bruce Korb Date: Mon, 14 Jan 2013 14:47:00 -0000 Message-ID: Subject: Re: [PATCH] Fix fixinclude common/non-common mix To: Richard Biener Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-01/txt/msg00689.txt.bz2 Hi, On Mon, Jan 14, 2013 at 12:42 AM, Richard Biener wrote: > > fixincludes mixes common declarations (in fixlib.h) and non-common > decls (where they are defined) for verbose_level and fixinc_mode. > XCode on Mountain Lion doesn't like this and its linker (rightfully) > complains. It is not rightful that it complain, but it is rightful to accommodate it. "approved."