From: Bruce Korb <bkorb@gnu.org>
To: David Edelsohn <dje.gcc@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] AIX fixincludes for pthread.h
Date: Tue, 08 Nov 2011 19:18:00 -0000 [thread overview]
Message-ID: <CAKRnqNL6784ovCTkeqGjawBSa3Bf+tOhahmjhqmTFDDXuR6ecw@mail.gmail.com> (raw)
In-Reply-To: <CAGWvnymczmfst1MN_agtaYw8HJJ0rWfh8c4wpKti6mNhDtuSWg@mail.gmail.com>
Hi David,
On Tue, Nov 8, 2011 at 10:20 AM, David Edelsohn <dje.gcc@gmail.com> wrote:
>>> Okay?
>>
>> Well, okay, but....
>
> Also, there are other fixincludes fixes for missing braces that
> directly add the braces, not a wrapper. They are not multi-line
> macros, but there is a precedent on the style of solution.
Like I said, "okay, but...". Each entry is some sort of compromise.
Each entry exacts a cost of operation. If inserting braces with a single
fix is easy, I think that's the preferred solution. Using two fixes to insert
a matched pair of braces just seems a bit dodgey. Especially given that
the selection expression feels so non-specific, at least to me:
"[ \t]0 \\\\\n\\}\n"
In the final analysis, AIX is your play area and you know the trade-offs,
so I leave it to you to decide.
Cheers - Bruce
prev parent reply other threads:[~2011-11-08 18:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 21:04 David Edelsohn
2011-11-08 17:01 ` Bruce Korb
2011-11-08 17:26 ` David Edelsohn
2011-11-08 18:33 ` David Edelsohn
2011-11-08 19:18 ` Bruce Korb [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKRnqNL6784ovCTkeqGjawBSa3Bf+tOhahmjhqmTFDDXuR6ecw@mail.gmail.com \
--to=bkorb@gnu.org \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).