From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by sourceware.org (Postfix) with ESMTPS id 5028F3858C83 for ; Wed, 11 Jan 2023 10:15:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5028F3858C83 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-f175.google.com with SMTP id w3so16293769ply.3 for ; Wed, 11 Jan 2023 02:15:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MHhnkjtW624GhE08iu0xeEmnxIkt/0OF91I7p6g0Y0E=; b=VTA46Pt8I6vznBjOcElJoXau5E0JqkzXSGQ3VLFWu/bKZLsAO/P94HNWV1Jpbiqv/F OhSH3zet7Ti/s+Rz4Oiop+miWEw6K/FbjG89UFAU+lhxOjbix3Huc3cIEQFKdq8fg2FK chWR8u2KQBw+NBgBbBhrCTbWyhz5/mQJ0btDydRx60UeipdHBcbfbmkkrL/T3LrrZIS1 li3FYAF4Zwi09skRRtmozSBqXESXMt4dvadoh4aPLM0thtuCiqxGQ1dP1jAYpdsJR9kM fLzyEDcVf7PAeJbDWRFX3jxt6RKVS1i50mRE/3g2OjAb9mrMrFqCdGxlvcrKgVAovZdZ TEcw== X-Gm-Message-State: AFqh2koQOSJXAOOefUQLmaYUfuc78m0WfPxtrJKaVyTOcU9qfWePP3Jp eccchISfnAEVAaIxZGJ+Y6VX4F3mcf+tAXkN878= X-Google-Smtp-Source: AMrXdXtGLnLghAb1carFc4dPcebXgxZFhR1kHGM7cPWThNXBuBbxWhnSI6ilhsp7fbQ9s6tVXotV+L90rFaqoQWeOvU= X-Received: by 2002:a17:90a:9313:b0:219:bf1a:9dcc with SMTP id p19-20020a17090a931300b00219bf1a9dccmr3975912pjo.56.1673432119140; Wed, 11 Jan 2023 02:15:19 -0800 (PST) MIME-Version: 1.0 References: <20230106103632.3951217-1-yunqiang.su@cipunited.com> In-Reply-To: From: YunQiang Su Date: Wed, 11 Jan 2023 18:15:07 +0800 Message-ID: Subject: Re: [PATCH] libsanitizer/mips: always build with largefile support To: Hans-Peter Nilsson Cc: YunQiang Su , gcc-patches@gcc.gnu.org, aurelien@aurel32.net, adhemerval.zanella@linaro.org, jiaxun.yang@flygoat.com, macro@orcam.me.uk, jakub@redhat.com, dodji@redhat.com, kcc@google.com, dvyukov@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,BODY_8BITS,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hans-Peter Nilsson =E4=BA=8E2023=E5=B9=B41=E6=9C=8811=E6= =97=A5=E5=91=A8=E4=B8=89 08:53=E5=86=99=E9=81=93=EF=BC=9A > > On Fri, 6 Jan 2023, YunQiang Su wrote: > > > -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=3D64 is always used for mips > > when build libsanitizer in LLVM. Thus > > FIRST_32_SECOND_64((_MIPS_SIM =3D=3D _ABIN32) ? 176 : 160, 216); > > instead of > > FIRST_32_SECOND_64((_MIPS_SIM =3D=3D _ABIN32) ? 160 : 144, 216); > > in sanitizer_platform_limits_posix.h. > > > > To keep sync with LLVM and to make the code simple, we use the > > largefile options always. > > > > libsanitizer/ > > * configure.ac: set -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=3D64 > > always for mips*. > > * configure: Regenerate. > > Hm, yes, that might be the most pragmatic way to solve the mips > stat-size issue... But shouldn't then largefile-options also be > forced when libsanitizer is *used*? IOW, mips*-linux > gcc-options be tweaked to include -D_LARGEFILE_SOURCE > -D_FILE_OFFSET_BITS=3D64 conditional on sanitizer-options? > Sound a good idea... While I am worrying about some application may fail to build or trigger some other problems. > brgds, H-P