* [PATCH] build: Fix missing variable quotes and typo
@ 2024-06-19 23:36 Collin Funk
2024-06-20 3:01 ` YunQiang Su
0 siblings, 1 reply; 2+ messages in thread
From: Collin Funk @ 2024-06-19 23:36 UTC (permalink / raw)
To: gcc-patches; +Cc: syq, Collin Funk
I've just fixed the quotes and that typo in one patch. I hope you don't
mind. When using Autoconf 2.69 and Automake 1.15.1 that copyright diff
goes away. I'm not familiar with the gcc-autoregen bot but I think this
should make it happy.
-- >8 --
When dlopen and pthread_create are in libc the variable is
set to "none required", therefore running configure will show
the following errors:
./configure: line 8997: test: too many arguments
./configure: line 8999: test: too many arguments
./configure: line 9003: test: too many arguments
./configure: line 9005: test: =: unary operator expected
ChangeLog:
PR bootstrap/115453
* configure.ac: Quote variable result of AC_SEARCH_LIBS. Fix
typo ac_cv_search_pthread_crate.
* configure: Regenerate.
Signed-off-by: Collin Funk <collin.funk1@gmail.com>
---
configure | 8 ++++----
configure.ac | 8 ++++----
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/configure b/configure
index 51576a41f30..51bf1d1add1 100755
--- a/configure
+++ b/configure
@@ -8994,15 +8994,15 @@ if test "$ac_res" != no; then :
fi
-if test $ac_cv_search_dlopen = -ldl; then
+if test "$ac_cv_search_dlopen" = -ldl; then
CRAB1_LIBS="$CRAB1_LIBS -ldl"
-elif test $ac_cv_search_dlopen = no; then
+elif test "$ac_cv_search_dlopen" = no; then
missing_rust_dynlibs="libdl"
fi
-if test $ac_cv_search_pthread_create = -lpthread; then
+if test "$ac_cv_search_pthread_create" = -lpthread; then
CRAB1_LIBS="$CRAB1_LIBS -lpthread"
-elif test $ac_cv_search_pthread_crate = no; then
+elif test "$ac_cv_search_pthread_create" = no; then
missing_rust_dynlibs="$missing_rust_dynlibs, libpthread"
fi
diff --git a/configure.ac b/configure.ac
index 5eda8dcdbf7..20457005e29 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2045,15 +2045,15 @@ missing_rust_dynlibs=none
AC_SEARCH_LIBS([dlopen], [dl])
AC_SEARCH_LIBS([pthread_create], [pthread])
-if test $ac_cv_search_dlopen = -ldl; then
+if test "$ac_cv_search_dlopen" = -ldl; then
CRAB1_LIBS="$CRAB1_LIBS -ldl"
-elif test $ac_cv_search_dlopen = no; then
+elif test "$ac_cv_search_dlopen" = no; then
missing_rust_dynlibs="libdl"
fi
-if test $ac_cv_search_pthread_create = -lpthread; then
+if test "$ac_cv_search_pthread_create" = -lpthread; then
CRAB1_LIBS="$CRAB1_LIBS -lpthread"
-elif test $ac_cv_search_pthread_crate = no; then
+elif test "$ac_cv_search_pthread_create" = no; then
missing_rust_dynlibs="$missing_rust_dynlibs, libpthread"
fi
--
2.45.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] build: Fix missing variable quotes and typo
2024-06-19 23:36 [PATCH] build: Fix missing variable quotes and typo Collin Funk
@ 2024-06-20 3:01 ` YunQiang Su
0 siblings, 0 replies; 2+ messages in thread
From: YunQiang Su @ 2024-06-20 3:01 UTC (permalink / raw)
To: CAKcpw6VR9OPpHgrah20y-E5YSWxo4mSrrV5mTSEtcBzLUrWYOA
Cc: gcc-patches, Collin Funk
Collin Funk <collin.funk1@gmail.com> 于2024年6月20日周四 07:40写道:
>
> I've just fixed the quotes and that typo in one patch. I hope you don't
> mind. When using Autoconf 2.69 and Automake 1.15.1 that copyright diff
> goes away. I'm not familiar with the gcc-autoregen bot but I think this
> should make it happy.
>
> -- >8 --
>
> When dlopen and pthread_create are in libc the variable is
> set to "none required", therefore running configure will show
> the following errors:
>
> ./configure: line 8997: test: too many arguments
> ./configure: line 8999: test: too many arguments
> ./configure: line 9003: test: too many arguments
> ./configure: line 9005: test: =: unary operator expected
>
> ChangeLog:
>
> PR bootstrap/115453
> * configure.ac: Quote variable result of AC_SEARCH_LIBS. Fix
> typo ac_cv_search_pthread_crate.
> * configure: Regenerate.
>
> Signed-off-by: Collin Funk <collin.funk1@gmail.com>
> ---
I committed it. And if you are using git format-patch, you can add
-V2/-V3/-V4 option if you are resending a updated patch.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-20 3:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-19 23:36 [PATCH] build: Fix missing variable quotes and typo Collin Funk
2024-06-20 3:01 ` YunQiang Su
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).