From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by sourceware.org (Postfix) with ESMTPS id 7AA903858CDB for ; Tue, 28 May 2024 18:32:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7AA903858CDB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7AA903858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716921178; cv=none; b=KKVnDDDaMxspwRJmUYPJLJLieh6g4GbUXJ73q6QeIEGsEeINAOhitHM3oDiuQmoOUwhhsBEaHky5pMm720zlTDPOs2RF12UC1dsxoJsWzRbehwZsdHZlXR1vuxGwR9TxxSGMsdGtNNcOXwJe7YJj21IhiEVjBbhd+lcs2u4CRQI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716921178; c=relaxed/simple; bh=GxagMPx9Zo1AuImPPUMcdQ9UqJ1+zqqe2bOn/cO3ZrI=; h=MIME-Version:From:Date:Message-ID:Subject:To; b=WDhfLXZ+6lp2Frp66LeZZwt0KFm01DU9MwUuxZKB5RSlqT1RJp7bbrcl/oIqhzvOmhePbrlH1G24lKO3JSW2f79t5KvljiRVtl2bvy/z+hLdZGTB4h2LGhxGvxqws6GiMv3k0ZkeZFcOZJM19qYqmyR0CLYBBfe92eSKVxOpEA4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1f4a52b9589so10581185ad.3 for ; Tue, 28 May 2024 11:32:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716921175; x=1717525975; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g6f6oT1EQdOTCyECCCh0eI7Tl5GT06fjJ2HC+H8rXkE=; b=oHbkpgf+0K8s6/vRIxzj6Ccq+0XzvgemVSTH05zkxTJw80p9cvS5mpdwEMV8gyPAWM UQrliKff3Ch1mgqMdg/uT3S/iXU9KkSZIoWUYuUO71wH4E+oI6R2UNlw/S8bn5lfetmr 4kKPztMj2X6Uwi91ovRr3D0yz7AsirINa4XufCmnUHufZAZ5b1E7B0Hro9EqMkqBUWHZ sogSuq3DJpkXAw4VYqwcPPHbipl2wjUocaM6sBOP8aZgH+4sAIkydwBJSBOw7lZpRnqc JN3/byabK1e6+XCTSQ/H4w77pPRoLWd9gz2ToIDus5IBYLGg3HeC0IJMmDJk2w7f1JAf 1Jfg== X-Gm-Message-State: AOJu0Yxog6RmBuLjU3ThZCq4b+BmM//OwcaVtzEi29YtjsGguYgSQKC3 k+O3a6kwrleBeQofBy+wt6Xj+REqkEdG2q3/ZpdhpXz4z4L9dK/5WYACF59w X-Google-Smtp-Source: AGHT+IE1d+pT1bxTBtDht8Kq2QaARSGHADNYKmRpI0n9GD+FHLTf4p68ae+IQiM7ZB78xJuIHfI8lA== X-Received: by 2002:a17:902:f688:b0:1f3:5ba:19b with SMTP id d9443c01a7336-1f4486d1d4dmr138621985ad.3.1716921174760; Tue, 28 May 2024 11:32:54 -0700 (PDT) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com. [209.85.214.171]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f478d2fb6esm58314885ad.70.2024.05.28.11.32.54 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 May 2024 11:32:54 -0700 (PDT) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1f32a3b9491so8526635ad.0 for ; Tue, 28 May 2024 11:32:54 -0700 (PDT) X-Received: by 2002:a17:902:ea0a:b0:1f2:fd9a:dbf3 with SMTP id d9443c01a7336-1f4486d1fa4mr150646295ad.11.1716921174301; Tue, 28 May 2024 11:32:54 -0700 (PDT) MIME-Version: 1.0 References: <20240522095404.1825269-1-syq@gcc.gnu.org> In-Reply-To: <20240522095404.1825269-1-syq@gcc.gnu.org> From: YunQiang Su Date: Wed, 29 May 2024 02:32:42 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/2] driver: Use -as/ld/objcopy as final fallback instead of native ones for cross To: gcc-patches@gcc.gnu.org Cc: pinskia@gmail.com, jeffreyalaw@gmail.com, doko@debian.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,BODY_8BITS,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: YunQiang Su =E4=BA=8E2024=E5=B9=B45=E6=9C=8822=E6=97=A5= =E5=91=A8=E4=B8=89 17:54=E5=86=99=E9=81=93=EF=BC=9A > > If `find_a_program` cannot find `as/ld/objcopy` and we are a cross toolch= ain, > the final fallback is `as/ld` of system. In fact, we can have a try with > -as/ld/objcopy before fallback to native as/ld/objcopy. > > This patch is derivatived from Debian's patch: > gcc-search-prefixed-as-ld.diff > > gcc > * gcc.cc(execute): Looks for -as/ld/objcopy before fallba= ck > to native as/ld/objcopy. ping. OK for the trunk? > --- > gcc/gcc.cc | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/gcc/gcc.cc b/gcc/gcc.cc > index 830a4700a87..3dc6348d761 100644 > --- a/gcc/gcc.cc > +++ b/gcc/gcc.cc > @@ -3293,6 +3293,26 @@ execute (void) > string =3D find_a_program(commands[0].prog); > if (string) > commands[0].argv[0] =3D string; > + else if (*cross_compile !=3D '0' > + && !strcmp (commands[0].argv[0], commands[0].prog) > + && (!strcmp (commands[0].prog, "as") > + || !strcmp (commands[0].prog, "ld") > + || !strcmp (commands[0].prog, "objcopy"))) > + { > + string =3D concat (DEFAULT_REAL_TARGET_MACHINE, "-", > + commands[0].prog, NULL); > + const char *string_args[] =3D {string, "--version", NULL}; > + int exit_status =3D 0; > + int err =3D 0; > + const char *errmsg =3D pex_one (PEX_SEARCH, string, > + CONST_CAST (char **, string_args), string, > + NULL, NULL, &exit_status, &err); > + if (errmsg =3D=3D NULL && exit_status =3D=3D 0 && err =3D=3D 0) > + { > + commands[0].argv[0] =3D string; > + commands[0].prog =3D string; > + } > + } > } > > for (n_commands =3D 1, i =3D 0; argbuf.iterate (i, &arg); i++) > -- > 2.39.2 >