From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=SQZg=AT=gmail.com=wzssyqa@sourceware.org>
Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172])
	by sourceware.org (Postfix) with ESMTPS id CEBCF3858D37
	for <gcc-patches@gcc.gnu.org>; Fri, 28 Apr 2023 13:07:22 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CEBCF3858D37
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=debian.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1a6762fd23cso79826075ad.3
        for <gcc-patches@gcc.gnu.org>; Fri, 28 Apr 2023 06:07:22 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20221208; t=1682687242; x=1685279242;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=zLZ15EprPzafBpz74hQgojvzs+/0F7TLGahIbXZJDrI=;
        b=XJgySAUepb+F4/xHxjPdr05Lc/QM7j4YWKU3Z6ZO6APemSnmAOiocZLufbpe8H/94i
         9I3dnyzdIbHzPSHF51md0jgPhajj8oKzl1a8T3bKGIhcry1KfTaQ+TYeAlVnBNWpiWBn
         2VqpAod0R4TZrWHubByOAZ1MS/AhMCjzmeTqF846a0jUEjZv4O1JQdvEgjY7RdsokBLR
         Wa00mPIUSxB4Io7ZJ5cflQi+a+96JOBXXHYx9pRfFCg9EvAMzDBatBNYvx6ALUZJGUnU
         yZW9SH0P54WpnXFgu+QWptuAqtpbhFlS47zyFdgMOh0zgnY4b0lLi+BEaRWe0StQaQv3
         Leyg==
X-Gm-Message-State: AC+VfDzEzCJrAuHMhR6G01fBvARHNzBqvvVGfUhbVV26J0sYxYy6JgRH
	qJfFcoNC+EtqwdWuMmCS9EiU8Qm+WnCZqhSnk98=
X-Google-Smtp-Source: ACHHUZ5rK4ECloVpx9cDaPIRGfJ2Qs2hzkTTwnZgq+O3rQy12sSu8xBhHPkhq4Gi3wCuUKyUlm/G8otCaPspUkUSeF8=
X-Received: by 2002:a17:902:ecd1:b0:1a9:c07f:93f4 with SMTP id
 a17-20020a170902ecd100b001a9c07f93f4mr3729954plh.55.1682687241329; Fri, 28
 Apr 2023 06:07:21 -0700 (PDT)
MIME-Version: 1.0
References: <20230428123327.686353-1-yunqiang.su@cipunited.com> <E961BF42-EC5B-4436-9913-FC2E6A468677@flygoat.com>
In-Reply-To: <E961BF42-EC5B-4436-9913-FC2E6A468677@flygoat.com>
From: YunQiang Su <syq@debian.org>
Date: Fri, 28 Apr 2023 21:07:09 +0800
Message-ID: <CAKcpw6WVPNE4KSrJoXsZkk=qvLkMzG_uLYU_usN0N_ErGee9CA@mail.gmail.com>
Subject: Re: [PATCH] MIPS: add speculation_barrier support
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: YunQiang Su <yunqiang.su@cipunited.com>, gcc-patches@gcc.gnu.org, 
	"Maciej W. Rozycki" <macro@orcam.me.uk>, richard.sandiford@arm.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,BODY_8BITS,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

Jiaxun Yang <jiaxun.yang@flygoat.com> =E4=BA=8E2023=E5=B9=B44=E6=9C=8828=E6=
=97=A5=E5=91=A8=E4=BA=94 20:36=E5=86=99=E9=81=93=EF=BC=9A
>
>
>
> > 2023=E5=B9=B44=E6=9C=8828=E6=97=A5 13:33=EF=BC=8CYunQiang Su <yunqiang.=
su@cipunited.com> =E5=86=99=E9=81=93=EF=BC=9A
> >
> > speculation_barrier for MIPS needs sync+jr.hb (r2+),
> > so we implement __speculation_barrier in libgcc, like arm32 does.
> >
> > gcc/ChangeLog:
> > * config/mips/mips-protos.h (mips_emit_speculation_barrier): New
> >        prototype.
> > * config/mips/mips.cc (speculation_barrier_libfunc): New static
> >        variable.
> > (mips_init_libfuncs): Initialize it.
> > (mips_emit_speculation_barrier): New function.
> > * config/arm/arm.md (speculation_barrier): Call
> >        mips_emit_speculation_barrier.
>
> ^ arm? Typo.
>

ohhh. You are right.
I copied the commit message from:
https://gcc.gnu.org/git/?p=3Dgcc.git;a=3Dcommit;h=3Debdb6f237772df251378d2c=
08350d345135bcb9e

New patch will be send.

> Thanks
> Jiaxun