[PATCH v3] MIPS: add .module mipsREV/.set arch= to all output asm file

[PATCH v3] MIPS: add .module mipsREV/.set arch= to all output asm file

[YunQiang Su]

Currently, the asm output file for MIPS has no rev info.
It can make some trouble, for example:

  assembler is mips1 by default,
  gcc is fpxx by default.

To assemble the output of gcc -S, we have to pass -mips2
to assembler.

The same situation is for some CPU has extension insn.
Octeon is an example.
So we can just add ".set arch=octeon".
---
 gcc/config/mips/mips.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gcc/config/mips/mips.c b/gcc/config/mips/mips.c
index 493d3de48..743a1d0fe 100644
--- a/gcc/config/mips/mips.c
+++ b/gcc/config/mips/mips.c
@@ -9896,6 +9896,12 @@ mips_file_start (void)
   else
     fputs ("\t.module\tnooddspreg\n", asm_out_file);
 
+  if (!global_options_set.x_mips_arch_option
+      || startswith(mips_arch_info->name, "mips"))
+    fprintf (asm_out_file, "\t.module\t%s\n", mips_arch_info->name);
+  else
+    fprintf (asm_out_file, "\t.set\tarch=%s\n", mips_arch_info->name);
+
 #else
 #ifdef HAVE_AS_GNU_ATTRIBUTE
   {
-- 
2.30.2

Re: [PATCH v3] MIPS: add .module mipsREV/.set arch= to all output asm file

[Maciej W. Rozycki]

On Thu, 2 Sep 2021, YunQiang Su wrote:

> diff --git a/gcc/config/mips/mips.c b/gcc/config/mips/mips.c
> index 493d3de48..743a1d0fe 100644
> --- a/gcc/config/mips/mips.c
> +++ b/gcc/config/mips/mips.c
> @@ -9896,6 +9896,12 @@ mips_file_start (void)
>    else
>      fputs ("\t.module\tnooddspreg\n", asm_out_file);
>  
> +  if (!global_options_set.x_mips_arch_option
> +      || startswith(mips_arch_info->name, "mips"))
> +    fprintf (asm_out_file, "\t.module\t%s\n", mips_arch_info->name);
> +  else
> +    fprintf (asm_out_file, "\t.set\tarch=%s\n", mips_arch_info->name);

 Why not consistently `.module' for both legs?  And actually why not just 
`.module arch=...' in all cases?

  Maciej

Re: [PATCH v3] MIPS: add .module mipsREV/.set arch= to all output asm file

[YunQiang Su]

Maciej W. Rozycki <macro@orcam.me.uk> 于2021年9月3日周五 上午9:48写道：
>
> On Thu, 2 Sep 2021, YunQiang Su wrote:
>
> > diff --git a/gcc/config/mips/mips.c b/gcc/config/mips/mips.c
> > index 493d3de48..743a1d0fe 100644
> > --- a/gcc/config/mips/mips.c
> > +++ b/gcc/config/mips/mips.c
> > @@ -9896,6 +9896,12 @@ mips_file_start (void)
> >    else
> >      fputs ("\t.module\tnooddspreg\n", asm_out_file);
> >
> > +  if (!global_options_set.x_mips_arch_option
> > +      || startswith(mips_arch_info->name, "mips"))

here is a code style problem. I will fix it.

> > +    fprintf (asm_out_file, "\t.module\t%s\n", mips_arch_info->name);
> > +  else
> > +    fprintf (asm_out_file, "\t.set\tarch=%s\n", mips_arch_info->name);
>
>  Why not consistently `.module' for both legs?  And actually why not just
> `.module arch=...' in all cases?
>

Thanks for your advisor. I will have a try.
The reason is that I don't know this method.

>   Maciej

Re: [PATCH v3] MIPS: add .module mipsREV/.set arch= to all output asm file

[YunQiang Su]

YunQiang Su <syq@debian.org> 于2021年9月3日周五 上午9:53写道：
>
> Maciej W. Rozycki <macro@orcam.me.uk> 于2021年9月3日周五 上午9:48写道：
> >
> > On Thu, 2 Sep 2021, YunQiang Su wrote:
> >
> > > diff --git a/gcc/config/mips/mips.c b/gcc/config/mips/mips.c
> > > index 493d3de48..743a1d0fe 100644
> > > --- a/gcc/config/mips/mips.c
> > > +++ b/gcc/config/mips/mips.c
> > > @@ -9896,6 +9896,12 @@ mips_file_start (void)
> > >    else
> > >      fputs ("\t.module\tnooddspreg\n", asm_out_file);
> > >
> > > +  if (!global_options_set.x_mips_arch_option
> > > +      || startswith(mips_arch_info->name, "mips"))
>
> here is a code style problem. I will fix it.
>
> > > +    fprintf (asm_out_file, "\t.module\t%s\n", mips_arch_info->name);
> > > +  else
> > > +    fprintf (asm_out_file, "\t.set\tarch=%s\n", mips_arch_info->name);
> >
> >  Why not consistently `.module' for both legs?  And actually why not just
> > `.module arch=...' in all cases?
> >
>
> Thanks for your advisor. I will have a try.

Ohh, it really works. woooo.
The testsuite is running.

> The reason is that I don't know this method.
>
> >   Maciej