From: YunQiang Su <syq@debian.org>
To: YunQiang Su <yunqiang.su@cipunited.com>
Cc: apinski--- via Gcc-patches <gcc-patches@gcc.gnu.org>,
"Maciej W. Rozycki" <macro@orcam.me.uk>
Subject: Re: [PATCH] MIPS: improve -march=native arch detection
Date: Wed, 24 Aug 2022 12:14:01 +0800 [thread overview]
Message-ID: <CAKcpw6Xugv=arBiWfBwwYrgHo+dKpz8OqfBOrZB0aNGWt+LARQ@mail.gmail.com> (raw)
In-Reply-To: <20220802111009.35536-1-yunqiang.su@cipunited.com>
YunQiang Su <yunqiang.su@cipunited.com> 于2022年8月2日周二 19:11写道:
>
> If we cannot get info from options and cpuinfo, we try to get from:
> 1. getauxval(AT_BASE_PLATFORM), introduced since Linux 5.7
> 2. _MIPS_ARCH from host compiler.
>
> This can fix the wrong loader usage on r5/r6 platform with
> -march=native.
>
Is it treat as minor fixes?
> gcc/ChangeLog:
> * config/mips/driver-native.cc (host_detect_local_cpu):
> try getauxval(AT_BASE_PLATFORM) and _MIPS_ARCH, too.
> ---
> gcc/config/mips/driver-native.cc | 22 +++++++++++++++++++---
> 1 file changed, 19 insertions(+), 3 deletions(-)
>
> diff --git a/gcc/config/mips/driver-native.cc b/gcc/config/mips/driver-native.cc
> index 47627f85ce1..9aa7044c0b8 100644
> --- a/gcc/config/mips/driver-native.cc
> +++ b/gcc/config/mips/driver-native.cc
> @@ -19,6 +19,7 @@ along with GCC; see the file COPYING3. If not see
>
> #define IN_TARGET_CODE 1
>
> +#include <sys/auxv.h>
> #include "config.h"
> #include "system.h"
> #include "coretypes.h"
> @@ -46,15 +47,15 @@ host_detect_local_cpu (int argc, const char **argv)
> bool arch;
>
> if (argc < 1)
> - return NULL;
> + goto fallback_cpu;
>
> arch = strcmp (argv[0], "arch") == 0;
> if (!arch && strcmp (argv[0], "tune"))
> - return NULL;
> + goto fallback_cpu;
>
> f = fopen ("/proc/cpuinfo", "r");
> if (f == NULL)
> - return NULL;
> + goto fallback_cpu;
>
> while (fgets (buf, sizeof (buf), f) != NULL)
> if (startswith (buf, "cpu model"))
> @@ -84,8 +85,23 @@ host_detect_local_cpu (int argc, const char **argv)
>
> fclose (f);
>
> +fallback_cpu:
> +/*FIXME: how about other OSes, like FreeBSD? */
> +#ifdef __linux__
> + /*Note: getauxval may return NULL as:
> + * AT_BASE_PLATFORM is supported since Linux 5.7
> + * Or from older version of qemu-user
> + * */
> + if (cpu == NULL)
> + cpu = (const char *) getauxval (AT_BASE_PLATFORM);
> +#endif
> +
> if (cpu == NULL)
> +#if defined (_MIPS_ARCH)
> + cpu = _MIPS_ARCH;
> +#else
> return NULL;
> +#endif
>
> return concat ("-m", argv[0], "=", cpu, NULL);
> }
> --
> 2.30.2
>
next prev parent reply other threads:[~2022-08-24 4:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 11:10 YunQiang Su
2022-08-14 10:36 ` YunQiang Su
2022-08-24 4:14 ` YunQiang Su [this message]
2022-08-24 5:56 ` Xi Ruoyao
2022-09-16 12:23 ` [PATCH v2] " YunQiang Su
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKcpw6Xugv=arBiWfBwwYrgHo+dKpz8OqfBOrZB0aNGWt+LARQ@mail.gmail.com' \
--to=syq@debian.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=macro@orcam.me.uk \
--cc=yunqiang.su@cipunited.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).